Generalize async_idents to all new keywords
#53685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This was referenced Aug 24, 2018
varkor
approved these changes
Aug 24, 2018
src/librustc_lint/builtin.rs
Outdated
| Edition::Edition2015 => { | ||
| match &ident.as_str()[..] { | ||
| "async" | | ||
| "try" => 2018, |
There was a problem hiding this comment.
Feels like this should be using Edition::Edition2018, which already implements Display.
| @@ -0,0 +1,21 @@ | |||
| // Copyright 2016 The Rust Project Developers. See the COPYRIGHT | |||
There was a problem hiding this comment.
You should just be able to remove this copyright header now (and with the other tests).
There was a problem hiding this comment.
Ah ok, good to know for the future!
(this'll be a hard habit to shake for me...)
scottmcm
reviewed
Aug 24, 2018
src/librustc_lint/builtin.rs
Outdated
| } | ||
|
|
||
| /// Checks for uses of `async` as an identifier | ||
| /// Checks for uses of future edtion keywords used as an identifier |
scottmcm
reviewed
Aug 24, 2018
src/librustc_lint/builtin.rs
Outdated
| Edition::Edition2015 => { | ||
| match &ident.as_str()[..] { | ||
| "async" | | ||
| "try" => 2018, |
There was a problem hiding this comment.
It should be if it isn't already
alexcrichton
force-pushed
the
more-keywords
branch
from
cd5bbe5
to
9e96419
Compare
|
@bors: r=varkor |
|
📌 Commit 9e96419 has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 28, 2018
Generalize `async_idents` to all new keywords This commit generalizes the existing `async_idents` lint to easily encompass other identifiers that will be keywords in future editions. The new lint is called `keyword_idents` and the old `async_idents` lint is registered as renamed to this new lint. As a proof of concept the `try` keyword was added to this list as it looks to be listed as a keyword in the 2018 edition only. The `await` keyword was not added as it's not listed as a keyword yet. Closes rust-lang#53077
|
⌛ Testing commit 9e96419 with merge 9119395c08158c67dffe36fbe0e0062c1ad577c7... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This commit generalizes the existing `async_idents` lint to easily encompass other identifiers that will be keywords in future editions. The new lint is called `keyword_idents` and the old `async_idents` lint is registered as renamed to this new lint. As a proof of concept the `try` keyword was added to this list as it looks to be listed as a keyword in the 2018 edition only. The `await` keyword was not added as it's not listed as a keyword yet. Closes rust-lang#53077
|
@bors: r=varkor |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 9e96419 has been approved by |
bors
added
S-waiting-on-bors
alexcrichton
force-pushed
the
more-keywords
branch
from
9e96419
to
003cab2
Compare
|
@bors: r=varkor |
|
📌 Commit 003cab2 has been approved by |
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Aug 29, 2018
Generalize `async_idents` to all new keywords This commit generalizes the existing `async_idents` lint to easily encompass other identifiers that will be keywords in future editions. The new lint is called `keyword_idents` and the old `async_idents` lint is registered as renamed to this new lint. As a proof of concept the `try` keyword was added to this list as it looks to be listed as a keyword in the 2018 edition only. The `await` keyword was not added as it's not listed as a keyword yet. Closes rust-lang#53077
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Aug 29, 2018
Generalize `async_idents` to all new keywords This commit generalizes the existing `async_idents` lint to easily encompass other identifiers that will be keywords in future editions. The new lint is called `keyword_idents` and the old `async_idents` lint is registered as renamed to this new lint. As a proof of concept the `try` keyword was added to this list as it looks to be listed as a keyword in the 2018 edition only. The `await` keyword was not added as it's not listed as a keyword yet. Closes rust-lang#53077
bors
added a commit
that referenced
this pull request
Aug 30, 2018
Generalize `async_idents` to all new keywords This commit generalizes the existing `async_idents` lint to easily encompass other identifiers that will be keywords in future editions. The new lint is called `keyword_idents` and the old `async_idents` lint is registered as renamed to this new lint. As a proof of concept the `try` keyword was added to this list as it looks to be listed as a keyword in the 2018 edition only. The `await` keyword was not added as it's not listed as a keyword yet. Closes #53077
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit generalizes the existing
async_identslint to easily encompassother identifiers that will be keywords in future editions. The new lint is
called
keyword_identsand the oldasync_identslint is registered as renamedto this new lint.
As a proof of concept the
trykeyword was added to this list as it looks to belisted as a keyword in the 2018 edition only. The
awaitkeyword was not addedas it's not listed as a keyword yet.
Closes #53077