Rollup of 15 pull requests #54146
Merged
Rollup of 15 pull requests #54146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow target specs to disable that attribute.
The error value now includes the type of the success. The success value now includes the type of the error.
map_or_else is now correctly labelled unstable and points to the tracking issue on rust-lang/rust
Brings the documentation in line with the BufReader implementation. Fixes rust-lang#48022.
This change is in response to rust-lang#53125. The patch makes the feature accepted and removes the tests that tested the non-accepted status of the feature.
Making it consistent across the board, as most of them already use `$`. Also split one continues bash run into two, to make it easier see different runs: one with warning and another with error.
modified to read "the first table overflows into the second, and the second into the first." plus smaller typos
Fix a few AMDGPU related issues * AMDGPU ignores `noinline` and sadly doesn't clear the attribute when it slaps `alwaysinline` on everything, * an AMDGPU related load bit range metadata assertion, * I didn't enable the `amdgpu` component in the `librustc_llvm` build script, * Add AMDGPU call abi info.
Document .0 to unpack integer from Wrapping
…xcrichton Implemented map_or_else for Result<T, E> Fulfills rust-lang#53268 The example is ripped from `Option::map_or_else`, with the types corrected.
A few cleanups and minor improvements to rustc_passes - prefer `if let` to `match` when only one branch matters - prefer equality checks to pattern matching - prefer `is_empty` to `len() == 0` - collapse a couple of `if` expressions - rename `label` to `destination` when destructuring `hir::ExprKind::Continue` - `derive Copy` for `Promotability` - `impl BitAndAssign` for `Promotability` - a few formatting fixes - a few other minor cleanups
Update documentation for fill_buf in std::io::BufRead Brings the documentation in line with the BufReader implementation. Fixes rust-lang#48022. This is my first PR, and I think the `E-easy` label is very cool, as so is the practice of describing the fix but leaving it for someone else; it really makes it a lot less intimidating to get started with something!
`&CStr`, not `CStr`, is the counterpart of `&str`
Stabilization change for mod.rs This change is in response to rust-lang#53125. The patch makes the feature accepted and removes the tests that tested the non-accepted status of the feature.
…etMisdreavus rustdoc: Remove generated blanket impls from trait pages rust-lang#53801 only deduped the generated blanket impls but they shouldn't be displayed at all because the original blanket impl is already in the "Implementors" section. This also removes the impls from the sidebar. Fixes rust-lang#53689 r? @QuietMisdreavus
…=Manishearth Reexport CheckLintNameResult Make the enum `CheckLintNameResult` public, so that lint tools (aka Clippy) can use it together with [`LintStore::check_lint_name`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/lint/struct.LintStore.html#method.check_lint_name), to handle the case that a scoped `tool_lint` doesn't exist in the tool. This is currently not handled by the compiler: https://github.com/rust-lang/rust/blob/595345419d12c3ea860151df52f78744a31bafff/src/librustc/lint/levels.rs#L309-L314 Needed for rust-lang/rust-clippy#3161 r? @Manishearth
…acrum Fix typos in libstd hash map modified growth algo description to read "the first table overflows into the second, and the second into the first." plus smaller typos
…alexcrichton Update LLVM to fix GlobalISel dbg.declare Fixes rust-lang#49807.
…278, r=wesleywiser Recover proper regression test for issue rust-lang#16278. Spawned from my note rust-lang#19955 (comment)
|
@bors r+ p=15 |
|
📌 Commit 1fed251 has been approved by |
bors
added
the
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
⌛ Testing commit 1fed251 with merge 289c63e897edc0a2fc53465f2141b7b0ad7172fb... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 12, 2018
Rollup of 15 pull requests Successful merges: - #52514 (Fix a few AMDGPU related issues) - #53703 (Document .0 to unpack integer from Wrapping) - #53777 (Implemented map_or_else for Result<T, E>) - #54031 (A few cleanups and minor improvements to rustc_passes) - #54046 (Update documentation for fill_buf in std::io::BufRead) - #54064 (`&CStr`, not `CStr`, is the counterpart of `&str`) - #54072 (Stabilization change for mod.rs) - #54073 (docs: Use dollar sign for all bash prompts) - #54074 (simplify ordering for Kind) - #54085 (Remove documentation about proc_macro being bare-bones) - #54087 (rustdoc: Remove generated blanket impls from trait pages) - #54106 (Reexport CheckLintNameResult) - #54107 (Fix typos in libstd hash map) - #54136 (Update LLVM to fix GlobalISel dbg.declare) - #54142 (Recover proper regression test for issue #16278.) Failed merges: r? @ghost
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Sep 12, 2018
Closed
kennytm
added
the
relnotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The
[relnote]tag refers to #54072.Successful merges:
&CStr, notCStr, is the counterpart of&str#54064 (&CStr, notCStr, is the counterpart of&str)Failed merges:
r? @ghost