Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document .0 to unpack integer from Wrapping #53703

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Document .0 to unpack integer from Wrapping #53703

merged 1 commit into from
Sep 12, 2018

Conversation

sourcefrog
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2018
frewsxcv
frewsxcv reviewed Aug 26, 2018
View reviewed changes
src/libcore/num/mod.rs Outdated
@@ -122,6 +122,9 @@ nonzero_integers! {
/// all standard arithmetic operations on the underlying value are
/// intended to have wrapping semantics.
///
/// The enclosed integer can be retrieved through the `.0` index of the
/// `Wrapping` tuple.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping isn't exclusively for integers – one can do Wrapping(0.0f32) if they want. So we may want this to say something like:

The underling value can be...

or

The enclosed number can be...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks, fixed.

@frewsxcv
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 26, 2018

📌 Commit 775f707669817f439c095ace0897c6ee8ba239fc has been approved by frewsxcv

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2018
@mzji
Copy link

mzji commented Aug 27, 2018

Seems like two submodules (binaryen and hoedown) are added... Do we really need those? I don't think a fix about documents requires two huge submodules to be added.

@frewsxcv
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 27, 2018
@frewsxcv
Copy link
Member

Good catch @mzji

@sourcefrog
Copy link
Contributor Author

Sorry, I'm confused by git submodules, and that was not intentional. I'll work out how to get them out.

@frewsxcv
Copy link
Member

You may be able to revert the submodule updates via git checkout master src/rt/hoedown sec/binaryen

@TimNN
Copy link
Contributor

TimNN commented Sep 4, 2018

Ping from triage, @sourcefrog: Do you think you'll be able to make the requested changes? If you prefer, members of the Rust team can also push the requested updates to your branch. (Let me know if that is the case, and I can do it).

@sourcefrog
Copy link
Contributor Author

@TimNN yes, doing that now.

I tried git checkout on the submodules but it seems more like I need to rm -r them to get git to forget about them. I'll push a new commit soon.

@sourcefrog
Copy link
Contributor Author

OK should be clean now, please take another look.

@frewsxcv
Copy link
Member

frewsxcv commented Sep 9, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 9, 2018

📌 Commit 597c065 has been approved by frewsxcv

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 9, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Sep 12, 2018
@kennytm
Rollup merge of rust-lang#53703 - sourcefrog:doc-wrapping, r=frewsxcv
605948f 
Document .0 to unpack integer from Wrapping
@kennytm kennytm mentioned this pull request Sep 12, 2018
Merged
bors added a commit that referenced this pull request Sep 12, 2018
@bors
Auto merge of #54146 - kennytm:rollup, r=kennytm
8586ec6 
Rollup of 15 pull requests

Successful merges:

 - #52514 (Fix a few AMDGPU related issues)
 - #53703 (Document .0 to unpack integer from Wrapping)
 - #53777 (Implemented map_or_else for Result<T, E>)
 - #54031 (A few cleanups and minor improvements to rustc_passes)
 - #54046 (Update documentation for fill_buf in std::io::BufRead)
 - #54064 (`&CStr`, not `CStr`, is the counterpart of `&str`)
 - #54072 (Stabilization change for mod.rs)
 - #54073 (docs: Use dollar sign for all bash prompts)
 - #54074 (simplify ordering for Kind)
 - #54085 (Remove documentation about proc_macro being bare-bones)
 - #54087 (rustdoc: Remove generated blanket impls from trait pages)
 - #54106 (Reexport CheckLintNameResult)
 - #54107 (Fix typos in libstd hash map)
 - #54136 (Update LLVM to fix GlobalISel dbg.declare)
 - #54142 (Recover proper regression test for issue #16278.)

Failed merges:

r? @ghost
@bors bors merged commit 597c065 into rust-lang:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees

@KodrAus KodrAus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sourcefrog @rust-highfive @frewsxcv @bors @mzji @TimNN @KodrAus