Skip to content

Conversation

alexcrichton
Copy link
Member

Should bring in some nice progress bars for compilations!

Should bring in some nice progress bars for compilations!
@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2018
@alexcrichton
Copy link
Member Author

r? @kennytm

@rust-highfive rust-highfive assigned kennytm and unassigned aturon Sep 14, 2018
@softprops
Copy link

The pull description piqued my interest. Do you have a screen shot to share?

@kennytm
Copy link
Member

kennytm commented Sep 14, 2018

@bors r+

@softprops There's an asciicast in rust-lang/cargo#5620. If you've got the nightly toolchain, you could turn it on with cargo build -Zcompile-progress.

@bors
Copy link
Collaborator

bors commented Sep 14, 2018

📌 Commit 7a1eed7 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Sep 14, 2018
Update Cargo

Should bring in some nice progress bars for compilations!
bors added a commit that referenced this pull request Sep 14, 2018
Rollup of 8 pull requests

Successful merges:

 - #53218 (Add a implementation of `From` for converting `&'a Option<T>` into `Option<&'a T>`)
 - #54024 (Fix compiling some rustc crates to wasm)
 - #54095 (Rename all mentions of `nil` to `unit`)
 - #54173 (Suggest valid crate type if invalid crate type is found)
 - #54194 (Remove println!() statement from HashMap unit test)
 - #54203 (Fix the stable release of os_str_str_ref_eq)
 - #54207 (re-mark the never docs as unstable)
 - #54210 (Update Cargo)

Failed merges:

r? @ghost
@bors bors merged commit 7a1eed7 into rust-lang:master Sep 14, 2018
flip1995 added a commit to rust-lang/rust-clippy that referenced this pull request Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants