Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Split `Liveness::users` into three. #54211
This reduces memory usage on some benchmarks because no space is wasted
r? @nikomatsakis, but I want to do a perf run. Locally, I had these results:
So I want to see how a different machine compares.
added a commit
this pull request
Sep 14, 2018
referenced this pull request
Sep 14, 2018
I think this is a rare case where instruction counts are misleading!
With all that in mind, here are the results just for
Instructions gets worse, but everything else gets better. And we have a simple theoretical explanation for this: less memory traffic. So I think we should land this, but I am happy to defer to @nikomatsakis's decision.
I think the other important bit to note is that it seems to be mostly the
Yes. Sorry if I wasn't clear: I'm very much in favor of merging this PR…
On Fri, Sep 14, 2018, 9:40 PM Nicholas Nethercote ***@***.***> wrote: A 5% regression on the clean incremental time is usually a very, very small At the risk of laboring the point: it's a win, not a regression on the *time*. It's only a regression on instruction counts. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#54211 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAyu2A32CcJ-YNT2Fe9kCE6Lq28iRpb2ks5ubFqfgaJpZM4Woia1> .