New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize `min_const_fn` #54835

Merged
merged 3 commits into from Oct 7, 2018

Conversation

Projects
None yet
6 participants
@oli-obk
Contributor

oli-obk commented Oct 5, 2018

tracking issue: #53555

r? @Centril

@rust-highfive

This comment was marked as resolved.

Show comment
Hide comment
@rust-highfive

rust-highfive Oct 5, 2018

Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:04:06] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:06] tidy error: /checkout/src/test/ui/consts/min_const_fn/cmp_fn_pointers.rs: missing trailing newline
[00:04:07] some tidy checks failed
[00:04:07] 
[00:04:07] 
[00:04:07] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:07] 
[00:04:07] 
[00:04:07] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:07] Build completed unsuccessfully in 0:00:47
[00:04:07] Build completed unsuccessfully in 0:00:47
[00:04:07] Makefile:79: recipe for target 'tidy' failed
[00:04:07] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:050f30e8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0c50f4c4:start=1538727904441354612,finish=1538727904446914695,duration=5560083
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:22809db0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1e69754c
travis_time:start:1e69754c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:05ea1fd2
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Collaborator

rust-highfive commented Oct 5, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:04:06] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:06] tidy error: /checkout/src/test/ui/consts/min_const_fn/cmp_fn_pointers.rs: missing trailing newline
[00:04:07] some tidy checks failed
[00:04:07] 
[00:04:07] 
[00:04:07] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:07] 
[00:04:07] 
[00:04:07] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:07] Build completed unsuccessfully in 0:00:47
[00:04:07] Build completed unsuccessfully in 0:00:47
[00:04:07] Makefile:79: recipe for target 'tidy' failed
[00:04:07] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:050f30e8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0c50f4c4:start=1538727904441354612,finish=1538727904446914695,duration=5560083
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:22809db0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1e69754c
travis_time:start:1e69754c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:05ea1fd2
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

Centril approved these changes Oct 5, 2018

@rust-highfive

This comment was marked as resolved.

Show comment
Hide comment
@rust-highfive

rust-highfive Oct 5, 2018

Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:51:07] ................................................................................................i... 2200/4551
[00:51:12] .................................................................................................... 2300/4551
[00:51:16] .................................................................................................... 2400/4551
[00:51:19] .................................................................................................... 2500/4551
[00:51:23] ........iiiiiiiii................................................................................... 2600/4551
[00:51:29] .................................................................................................... 2800/4551
[00:51:32] .................................................................................................... 2900/4551
[00:51:35] ...........................i........................................................................ 3000/4551
[00:51:38] .......................................................................................i.i..ii...... 3100/4551
---
[01:30:44] 
[01:30:44] failures:
[01:30:44] 
[01:30:44] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0022 (line 406) stdout ----
[01:30:44] thread '/checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0022 (line 406)' panicked at 'test compiled while it wasn't supposed to', librustdoc/test.rs:323:13
[01:30:44] 
[01:30:44] 
[01:30:44] failures:
[01:30:44]     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0022 (line 406)
---
[01:30:44] 
[01:30:44] 
[01:30:44] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:30:44] Build completed unsuccessfully in 0:44:14
[01:30:44] Makefile:58: recipe for target 'check' failed
[01:30:44] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0384fea0
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Collaborator

rust-highfive commented Oct 5, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:51:07] ................................................................................................i... 2200/4551
[00:51:12] .................................................................................................... 2300/4551
[00:51:16] .................................................................................................... 2400/4551
[00:51:19] .................................................................................................... 2500/4551
[00:51:23] ........iiiiiiiii................................................................................... 2600/4551
[00:51:29] .................................................................................................... 2800/4551
[00:51:32] .................................................................................................... 2900/4551
[00:51:35] ...........................i........................................................................ 3000/4551
[00:51:38] .......................................................................................i.i..ii...... 3100/4551
---
[01:30:44] 
[01:30:44] failures:
[01:30:44] 
[01:30:44] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0022 (line 406) stdout ----
[01:30:44] thread '/checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0022 (line 406)' panicked at 'test compiled while it wasn't supposed to', librustdoc/test.rs:323:13
[01:30:44] 
[01:30:44] 
[01:30:44] failures:
[01:30:44]     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0022 (line 406)
---
[01:30:44] 
[01:30:44] 
[01:30:44] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:30:44] Build completed unsuccessfully in 0:44:14
[01:30:44] Makefile:58: recipe for target 'check' failed
[01:30:44] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0384fea0
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@killercup

This comment has been minimized.

Show comment
Hide comment
@killercup

killercup Oct 5, 2018

Member

You constantly surprise me, Oli: TIL git(hub) apparently works well with unicode branch names.

Member

killercup commented Oct 5, 2018

You constantly surprise me, Oli: TIL git(hub) apparently works well with unicode branch names.

@Centril

This comment has been minimized.

Show comment
Hide comment
@Centril

Centril Oct 5, 2018

Contributor

Extra points for a great branch name =P

/me considers branch names in Swedish now

Contributor

Centril commented Oct 5, 2018

Extra points for a great branch name =P

/me considers branch names in Swedish now

@Centril Centril added the relnotes label Oct 5, 2018

@oli-obk

This comment has been minimized.

Show comment
Hide comment
@oli-obk

oli-obk Oct 5, 2018

Contributor

r? @RalfJung

The tracking issue has been FCPed and accepted for merging. @Centril already signed off.

Contributor

oli-obk commented Oct 5, 2018

r? @RalfJung

The tracking issue has been FCPed and accepted for merging. @Centril already signed off.

@rust-highfive rust-highfive assigned RalfJung and unassigned Centril Oct 5, 2018

@oli-obk

This comment has been minimized.

Show comment
Hide comment
@oli-obk

oli-obk Oct 5, 2018

Contributor

Oh wait

@bors r=Centril

😈

Contributor

oli-obk commented Oct 5, 2018

Oh wait

@bors r=Centril

😈

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 5, 2018

Contributor

📌 Commit fb04e26 has been approved by Centril

Contributor

bors commented Oct 5, 2018

📌 Commit fb04e26 has been approved by Centril

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 7, 2018

Contributor

⌛️ Testing commit fb04e26 with merge 0ee045e...

Contributor

bors commented Oct 7, 2018

⌛️ Testing commit fb04e26 with merge 0ee045e...

bors added a commit that referenced this pull request Oct 7, 2018

Auto merge of #54835 - oli-obk:mögen_konstante_funktionen_doch_bitte_…
…endlich_stabil_sein, r=Centril

Stabilize `min_const_fn`

tracking issue: #53555

r? @Centril
@Centril

This comment has been minimized.

Show comment
Hide comment
@Centril

Centril Oct 7, 2018

Contributor

🙏

Contributor

Centril commented Oct 7, 2018

🙏

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 7, 2018

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: Centril
Pushing 0ee045e to master...

Contributor

bors commented Oct 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Centril
Pushing 0ee045e to master...

@bors bors merged commit fb04e26 into rust-lang:master Oct 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bstrie bstrie referenced this pull request Oct 10, 2018

Closed

Tracking issue for a minimal subset of RFC 911, const fn #53555

4 of 4 tasks complete

@hannobraun hannobraun referenced this pull request Oct 10, 2018

Open

Support stable Rust #11

3 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment