New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `SmallVec` for the queue in `coerce_unsized`. #55383

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
5 participants
@nnethercote
Contributor

nnethercote commented Oct 26, 2018

This reduces the number of allocations done for the tuple-stress
benchmark by 4%.

Use `SmallVec` for the queue in `coerce_unsized`.
This reduces the number of allocations done for the `tuple-stress`
benchmark by 4%.
@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Oct 26, 2018

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@davidtwco

This comment has been minimized.

Member

davidtwco commented Oct 26, 2018

@bors r+ rollup

@bors

This comment has been minimized.

Contributor

bors commented Oct 26, 2018

📌 Commit 526dc14 has been approved by davidtwco

kennytm added a commit to kennytm/rust that referenced this pull request Oct 26, 2018

Rollup merge of rust-lang#55383 - nnethercote:coerce_unsized-SmallVec…
…, r=davidtwco

Use `SmallVec` for the queue in `coerce_unsized`.

This reduces the number of allocations done for the `tuple-stress`
benchmark by 4%.
@Mark-Simulacrum

This comment has been minimized.

Member

Mark-Simulacrum commented Oct 26, 2018

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Oct 26, 2018

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #55392
@bors

This comment has been minimized.

Contributor

bors commented Oct 26, 2018

📌 Commit 526dc14 has been approved by Mark-Simulacrum

bors added a commit that referenced this pull request Oct 26, 2018

Auto merge of #55382 - kennytm:rollup, r=kennytm
Rollup of 21 pull requests

Successful merges:

 - #54816 (Don't try to promote already promoted out temporaries)
 - #54824 (Cleanup rustdoc tests with `@!has` and `@!matches`)
 - #54921 (Add line numbers option to rustdoc)
 - #55167 (Add a "cheap" mode for `compute_missing_ctors`.)
 - #55258 (Fix Rustdoc ICE when checking blanket impls)
 - #55264 (Compile the libstd we distribute with -Ccodegen-unit=1)
 - #55271 (Unimplement ExactSizeIterator for MIR traversing iterators)
 - #55292 (Macro diagnostics tweaks)
 - #55298 (Point at macro definition when no rules expect token)
 - #55301 (List allowed tokens after macro fragments)
 - #55302 (Extend the impl_stable_hash_for! macro for miri.)
 - #55325 (Fix link to macros chapter)
 - #55343 (rustbuild: fix remap-debuginfo when building a release)
 - #55346 (Shrink `Statement`.)
 - #55358 (Remove redundant clone (2))
 - #55370 (Update mailmap for estebank)
 - #55375 (Typo fixes in configure_cmake comments)
 - #55378 (rustbuild: use configured linker to build boostrap)
 - #55379 (validity: assert that unions are non-empty)
 - #55383 (Use `SmallVec` for the queue in `coerce_unsized`.)
 - #55391 (bootstrap: clean up a few clippy findings)

@bors bors merged commit 526dc14 into rust-lang:master Oct 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nnethercote nnethercote deleted the nnethercote:coerce_unsized-SmallVec branch Oct 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment