New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an ICE in the min_const_fn analysis #55412

Merged
merged 1 commit into from Oct 28, 2018

Conversation

Projects
None yet
7 participants
@oli-obk
Contributor

oli-obk commented Oct 27, 2018

fixes #55395

cc @Centril

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Oct 27, 2018

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril

This comment has been minimized.

Contributor

Centril commented Oct 27, 2018

Tests look good; that's about it wrt. what I can comment on :)

@estebank

This comment has been minimized.

Contributor

estebank commented Oct 27, 2018

@bors r+ rollup

@bors

This comment has been minimized.

Contributor

bors commented Oct 27, 2018

📌 Commit c04893a has been approved by estebank

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 27, 2018

bors added a commit that referenced this pull request Oct 27, 2018

Auto merge of #55425 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 13 pull requests

Successful merges:

 - #54683 (lint reasons (RFC 2883, part 1))
 - #54965 (update tcp stream documentation)
 - #55148 (Implement FromStr for PathBuf)
 - #55185 (path suggestions in Rust 2018 should point out the change in semantics )
 - #55252 (Add MaybeUninit::new)
 - #55257 (Allow extern statics with an extern type)
 - #55262 (Change the ICE from #55223 to a hard error)
 - #55269 (fix typos in various places)
 - #55330 (Add support for bound types)
 - #55349 (Move collect_and_partition_mono_items to rustc_mir)
 - #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…)
 - #55406 (Update string.rs)
 - #55412 (Fix an ICE in the min_const_fn analysis)

Failed merges:

r? @ghost

kennytm added a commit to kennytm/rust that referenced this pull request Oct 28, 2018

kennytm added a commit to kennytm/rust that referenced this pull request Oct 28, 2018

bors added a commit that referenced this pull request Oct 28, 2018

Auto merge of #55433 - kennytm:rollup, r=kennytm
Rollup of 8 pull requests

Successful merges:

 - #55148 (Implement FromStr for PathBuf)
 - #55191 (Fix sub-variant doc display)
 - #55244 (Don't rerun MIR passes when inlining)
 - #55252 (Add MaybeUninit::new)
 - #55304 (ci: Move global credentials to web configuration)
 - #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…)
 - #55406 (Update string.rs)
 - #55412 (Fix an ICE in the min_const_fn analysis)

Failed merges:

r? @ghost

kennytm added a commit to kennytm/rust that referenced this pull request Oct 28, 2018

bors added a commit that referenced this pull request Oct 28, 2018

Auto merge of #55433 - kennytm:rollup, r=kennytm
Rollup of 11 pull requests

Successful merges:

 - #55148 (Implement FromStr for PathBuf)
 - #55185 (path suggestions in Rust 2018 should point out the change in semantics)
 - #55191 (Fix sub-variant doc display)
 - #55199 (Impl items have generics)
 - #55244 (Don't rerun MIR passes when inlining)
 - #55252 (Add MaybeUninit::new)
 - #55257 (Allow extern statics with an extern type)
 - #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…)
 - #55406 (Update string.rs)
 - #55412 (Fix an ICE in the min_const_fn analysis)
 - #55421 (Add ManuallyDrop::take)

@bors bors merged commit c04893a into rust-lang:master Oct 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@oli-obk oli-obk deleted the oli-obk:min_const_fn_ice branch Oct 29, 2018

@oli-obk

This comment has been minimized.

Contributor

oli-obk commented Oct 29, 2018

Nominating for beta, as otherwise we'd have an ICE instead of an error in the first stable that has const fn.

bors added a commit that referenced this pull request Nov 1, 2018

Auto merge of #55554 - pietroalbini:beta-rollup, r=pietroalbini
[beta] Rollup backports

Merged and approved:

* #55494: borrowck=migrate must look at parents of closures
* #55343: rustbuild: fix remap-debuginfo when building a release
* #55412: Fix an ICE in the min_const_fn analysis

Rolled up PRs:

* #55550: [beta] Update the boostrap compiler

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment