New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `-Z ls` list the actual filename of external dependencies #55555

Merged
merged 1 commit into from Nov 3, 2018

Conversation

Projects
None yet
6 participants
@aidanhs
Member

aidanhs commented Oct 31, 2018

The hash is pointless for external consumers - extra_filename is the thing that actually gets used, per https://github.com/rust-lang/rust/blob/ca2639e/src/librustc_metadata/locator.rs#L312-L313

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Oct 31, 2018

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb

This comment has been minimized.

Member

eddyb commented Nov 2, 2018

@rust-highfive rust-highfive assigned nikomatsakis and unassigned eddyb Nov 2, 2018

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Nov 2, 2018

@bors: r+ rollup

@bors

This comment has been minimized.

Contributor

bors commented Nov 2, 2018

📌 Commit e84f461 has been approved by alexcrichton

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 3, 2018

Rollup merge of rust-lang#55555 - aidanhs:aphs-better-z-ls, r=alexcri…
…chton

Make `-Z ls` list the actual filename of external dependencies

The hash is pointless for external consumers - extra_filename is the thing that actually gets used, per https://github.com/rust-lang/rust/blob/ca2639e/src/librustc_metadata/locator.rs#L312-L313

bors added a commit that referenced this pull request Nov 3, 2018

Auto merge of #55646 - GuillaumeGomez:rollup, r=GuillaumeGomez
Rollup of 5 pull requests

Successful merges:

 - #54162 (Hide default impls items)
 - #55555 (Make `-Z ls` list the actual filename of external dependencies)
 - #55567 (add test for deriving Debug on uninhabited enum)
 - #55568 (test that rustdoc doesn't overflow on a big enum)
 - #55598 (publish-toolstate: ping maintainers when a tool builds again)

Failed merges:

r? @ghost

@bors bors merged commit e84f461 into rust-lang:master Nov 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aidanhs aidanhs deleted the aidanhs:aphs-better-z-ls branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment