New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak `MatcherPos::matches` #55558

Merged
merged 2 commits into from Nov 1, 2018

Conversation

Projects
None yet
4 participants
@nnethercote
Contributor

nnethercote commented Nov 1, 2018

These changes reduce instruction counts on sentry-cli-check incremental builds by up to 2%.

nnethercote added some commits Oct 31, 2018

Share empty `Vec`s more within `MatcherPos::matches`.
`create_matches` creates a `Vec<Rc<Vec<NamedMatch>>>`. Even though all the
inner `Vec`s are empty, each one is created separately.

This commit changes `create_matches` so it instead creates one empty inner
`Vec`, and shares it.

The commit also changes `MatcherPos::matches` to a boxed slice, because its
length doesn't change.
@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Nov 1, 2018

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@nnethercote nnethercote changed the title from Tweak matcher pos matches to Tweak `MatcherPos::matches` Nov 1, 2018

@petrochenkov

This comment has been minimized.

Contributor

petrochenkov commented Nov 1, 2018

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Nov 1, 2018

📌 Commit 0d2abe4 has been approved by petrochenkov

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 1, 2018

Rollup merge of rust-lang#55558 - nnethercote:tweak-MatcherPos-matche…
…s, r=petrochenkov

Tweak `MatcherPos::matches`

These changes reduce instruction counts on `sentry-cli-check` incremental builds by up to 2%.

bors added a commit that referenced this pull request Nov 1, 2018

Auto merge of #55579 - pietroalbini:rollup, r=pietroalbini
Rollup of 10 pull requests

Successful merges:

 - #55280 (Add libproc_macro to rust-src distribution)
 - #55469 (Regression tests for issue #54477.)
 - #55504 (Use vec![x; n] instead of iter::repeat(x).take(n).collect())
 - #55518 (std: Improve codegen size of accessing TLS)
 - #55522 (use String::from() instead of format!() macro to construct Strings.)
 - #55536 (Pass suggestions as impl Iterator instead of Vec)
 - #55542 (syntax: improve a few allocations)
 - #55558 (Tweak `MatcherPos::matches`)
 - #55574 (Use `SmallVec` within `MoveData`.)
 - #55575 (Fix invalid_const_promotion test on some archs)

Failed merges:

r? @ghost

kennytm added a commit to pietroalbini/rust that referenced this pull request Nov 1, 2018

Rollup merge of rust-lang#55558 - nnethercote:tweak-MatcherPos-matche…
…s, r=petrochenkov

Tweak `MatcherPos::matches`

These changes reduce instruction counts on `sentry-cli-check` incremental builds by up to 2%.

bors added a commit that referenced this pull request Nov 1, 2018

Auto merge of #55579 - pietroalbini:rollup, r=kennytm
Rollup of 13 pull requests

Successful merges:

 - #55280 (Add libproc_macro to rust-src distribution)
 - #55469 (Regression tests for issue #54477.)
 - #55504 (Use vec![x; n] instead of iter::repeat(x).take(n).collect())
 - #55522 (use String::from() instead of format!() macro to construct Strings.)
 - #55536 (Pass suggestions as impl Iterator instead of Vec)
 - #55542 (syntax: improve a few allocations)
 - #55558 (Tweak `MatcherPos::matches`)
 - #55561 (Fix double_check tests on big-endian targets)
 - #55573 (Make sure the `aws` executable is in $PATH on macOS)
 - #55574 (Use `SmallVec` within `MoveData`.)
 - #55575 (Fix invalid_const_promotion test on some archs)
 - #55578 (Made doc example of `impl Default for …` use `-> Self` instead of explicit self type)
 - #55582 (Remove unused import copy from publish_toolstate.py)
@bors

This comment has been minimized.

Contributor

bors commented Nov 1, 2018

☔️ The latest upstream changes (presumably #55579) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit 0d2abe4 into rust-lang:master Nov 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nnethercote nnethercote deleted the nnethercote:tweak-MatcherPos-matches branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment