Skip to content

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Nov 5, 2018

With emscripten removed in #55626, we no longer need to support building against LLVM 4.

With emscripten removed in rust-lang#55626, we no longer need to support
building against LLVM 4.
@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2018
@nikic nikic mentioned this pull request Nov 5, 2018
@cramertj
Copy link
Member

cramertj commented Nov 5, 2018

r? @alexcrichton

@alexcrichton
Copy link
Member

Awesome cleanup! r=me as soon as #55626

Thanks so much for all the LLVM work on our end, it's so greatly appreciated :)

@bors: delegate+

@bors
Copy link
Collaborator

bors commented Nov 5, 2018

✌️ @nikic can now approve this pull request

@nikic
Copy link
Contributor Author

nikic commented Nov 10, 2018

@bors r=alexcrichton as #55626 has landed.

@bors
Copy link
Collaborator

bors commented Nov 10, 2018

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove [WIP] from this PR's title when it is ready for review.

@nikic nikic changed the title [WIP] Remove support for building against LLVM 4 Remove support for building against LLVM 4 Nov 10, 2018
@nikic
Copy link
Contributor Author

nikic commented Nov 10, 2018

@bors r=alexcrichton with WIP removed...

@bors
Copy link
Collaborator

bors commented Nov 10, 2018

📌 Commit 3cc8b17 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2018
@bors
Copy link
Collaborator

bors commented Nov 11, 2018

⌛ Testing commit 3cc8b17 with merge 775eab5...

bors added a commit that referenced this pull request Nov 11, 2018
Remove support for building against LLVM 4

With emscripten removed in #55626, we no longer need to support building against LLVM 4.
@bors
Copy link
Collaborator

bors commented Nov 12, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 775eab5 to master...

@bors bors merged commit 3cc8b17 into rust-lang:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants