New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume optimization fuel from the MIR inliner #55739

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
5 participants
@wesleywiser
Member

wesleywiser commented Nov 7, 2018

This makes it easier to debug mis-optimizations that occur during
inlining. Thanks to @nikomatsakis for the suggestion!

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Nov 7, 2018

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb

This comment has been minimized.

Member

eddyb commented Nov 7, 2018

@rust-highfive rust-highfive assigned nikomatsakis and unassigned eddyb Nov 7, 2018

@nikomatsakis

r=me with the order switched

Consume optimization fuel from the MIR inliner
This makes it easier to debug mis-optimizations that occur during
inlining. Thanks to @nikomatsakis for the suggestion!

@wesleywiser wesleywiser force-pushed the wesleywiser:mir_inline_fuel branch from 9384b1e to e72afa9 Nov 7, 2018

@wesleywiser

This comment has been minimized.

Member

wesleywiser commented Nov 7, 2018

@bors r=nikomatsakis

@bors

This comment has been minimized.

Contributor

bors commented Nov 7, 2018

📌 Commit e72afa9 has been approved by nikomatsakis

kennytm added a commit to kennytm/rust that referenced this pull request Nov 8, 2018

Rollup merge of rust-lang#55739 - wesleywiser:mir_inline_fuel, r=niko…
…matsakis

Consume optimization fuel from the MIR inliner

This makes it easier to debug mis-optimizations that occur during
inlining. Thanks to @nikomatsakis for the suggestion!

bors added a commit that referenced this pull request Nov 8, 2018

Auto merge of #55789 - kennytm:rollup, r=kennytm
Rollup of 16 pull requests

Successful merges:

 - #54993 (Support for the program data address space option of LLVM's Target Datalayout)
 - #55576 (Clarify error message for -C opt-level)
 - #55638 (Fix ICE in msg_span_from_free_region on ReEmpty)
 - #55650 (Implement rotate using funnel shift on LLVM >= 7)
 - #55672 (miri: accept extern types in structs if they are the only field)
 - #55719 (Sidestep link error from rustfix'ed code by using a *defined* static.)
 - #55722 (impl_stable_hash_for: support enums and tuple structs with generic parameters)
 - #55736 (Elide anon lifetimes in conflicting impl note)
 - #55739 (Consume optimization fuel from the MIR inliner)
 - #55753 (borrow_set: remove a helper function and a clone it uses)
 - #55755 (Improve creation of 3 IndexVecs)
 - #55758 ([regression - rust2018]: unused_mut lint false positives on nightly)
 - #55760 (Remove intermediate font specs)
 - #55761 (mir: remove a hacky recursive helper function)
 - #55774 (wasm32-unknown-emscripten expects the rust_eh_personality symbol)
 - #55788 (rustc: Request ansi colors if stderr isn't a tty)

Failed merges:

r? @ghost

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Nov 9, 2018

Rollup merge of rust-lang#55739 - wesleywiser:mir_inline_fuel, r=niko…
…matsakis

Consume optimization fuel from the MIR inliner

This makes it easier to debug mis-optimizations that occur during
inlining. Thanks to @nikomatsakis for the suggestion!

bors added a commit that referenced this pull request Nov 9, 2018

Auto merge of #55803 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 17 pull requests

Successful merges:

 - #55576 (Clarify error message for -C opt-level)
 - #55633 (Support memcpy/memmove with differing src/dst alignment)
 - #55638 (Fix ICE in msg_span_from_free_region on ReEmpty)
 - #55659 (rustc: Delete grouping logic from the musl target)
 - #55719 (Sidestep link error from rustfix'ed code by using a *defined* static.)
 - #55736 (Elide anon lifetimes in conflicting impl note)
 - #55739 (Consume optimization fuel from the MIR inliner)
 - #55742 (Avoid panic when matching function call)
 - #55753 (borrow_set: remove a helper function and a clone it uses)
 - #55755 (Improve creation of 3 IndexVecs)
 - #55758 ([regression - rust2018]: unused_mut lint false positives on nightly)
 - #55760 (Remove intermediate font specs)
 - #55761 (mir: remove a hacky recursive helper function)
 - #55774 (wasm32-unknown-emscripten expects the rust_eh_personality symbol)
 - #55777 (Use `Lit` rather than `P<Lit>` in `ast::ExprKind`.)
 - #55783 (Deprecate mpsc channel selection)
 - #55788 (rustc: Request ansi colors if stderr isn't a tty)

Failed merges:

r? @ghost

@bors bors merged commit e72afa9 into rust-lang:master Nov 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment