New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE in `const` slice patterns #55922

Merged
merged 4 commits into from Dec 5, 2018

Conversation

Projects
None yet
4 participants
@oli-obk
Copy link
Contributor

oli-obk commented Nov 13, 2018

fixes #55911

based on #55915

New commits start at eabc155

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Nov 13, 2018

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@oli-obk oli-obk force-pushed the oli-obk:slice_pat_ice branch from 8eec717 to 5463ee1 Nov 13, 2018

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Nov 13, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:037b8eb4:start=1542122792656641651,finish=1542122849251124918,duration=56594483267
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---

[00:12:26] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:4: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:5: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:6: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:7: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:8: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:9: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:10: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs: missing trailing newline
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:4: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:5: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:6: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:7: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:8: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:9: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:10: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs: missing trailing newline
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:4: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:5: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:6: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:7: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:8: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:9: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:10: tab character
[00:12:26] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs: missing trailing newline
[00:12:27] some tidy checks failed
[00:12:27] 
[00:12:27] 
[00:12:27] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:12:27] 
[00:12:27] 
[00:12:27] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:12:27] Build completed unsuccessfully in 0:00:49
[00:12:27] Build completed unsuccessfully in 0:00:49
[00:12:27] Makefile:79: recipe for target 'tidy' failed
[00:12:27] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:135bec9d
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Nov 13 15:40:07 UTC 2018
---
travis_time:end:0b42748e:start=1542123607937563409,finish=1542123607943313751,duration=5750342
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:25a8f066
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:07f182a4
travis_time:start:07f182a4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:28fac8f0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Nov 13, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:245d2eb6:start=1542127325185023795,finish=1542127389658019596,duration=64472995801
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---

[00:04:11] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:4: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:5: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:6: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:7: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:8: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:9: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:10: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:4: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:5: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:6: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:7: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:8: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:9: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:10: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:4: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:5: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:6: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:7: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:8: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:9: tab character
[00:04:12] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:10: tab character
[00:04:13] some tidy checks failed
[00:04:13] 
[00:04:13] 
[00:04:13] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:13] 
[00:04:13] 
[00:04:13] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:13] Build completed unsuccessfully in 0:00:47
[00:04:13] Build completed unsuccessfully in 0:00:47
[00:04:13] Makefile:79: recipe for target 'tidy' failed
[00:04:13] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:18a39739
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Nov 13 16:47:32 UTC 2018
---
travis_time:end:000198a0:start=1542127652628369441,finish=1542127652633428431,duration=5058990
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:10c6c6c4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0d0c1967
travis_time:start:0d0c1967
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:05bb5a2d
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk oli-obk added the S-blocked label Nov 19, 2018

@bors

This comment was marked as outdated.

Copy link
Contributor

bors commented Nov 19, 2018

☔️ The latest upstream changes (presumably #56051) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk force-pushed the oli-obk:slice_pat_ice branch from 02433d3 to 46fe504 Nov 25, 2018

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Nov 25, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:25e066e7:start=1543160769096265255,finish=1543160771241673609,duration=2145408354
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---

[00:03:16] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:4: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:5: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:6: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:7: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:8: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:9: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const.rs:10: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:4: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:5: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:6: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:7: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:8: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:9: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-3.rs:10: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:4: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:5: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:6: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:7: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:8: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:9: tab character
[00:03:17] tidy error: /checkout/src/test/ui/pattern/slice-pattern-const-2.rs:10: tab character
[00:03:18] some tidy checks failed
[00:03:18] 
[00:03:18] 
[00:03:18] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:18] 
[00:03:18] 
[00:03:18] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:18] Build completed unsuccessfully in 0:00:57
[00:03:18] Build completed unsuccessfully in 0:00:57
[00:03:18] Makefile:79: recipe for target 'tidy' failed
[00:03:18] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:016f21c6
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Nov 25 15:49:38 UTC 2018
---
travis_time:end:1c017eb4:start=1543160978809796135,finish=1543160978815142920,duration=5346785
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:16017eee
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0d1c3c45
travis_time:start:0d1c3c45
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:01149576
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk oli-obk removed the S-blocked label Nov 29, 2018

@oli-obk oli-obk force-pushed the oli-obk:slice_pat_ice branch from 7d7c5f5 to 8f9a093 Nov 29, 2018

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Dec 3, 2018

cc @zackmdavis this could use a review in the next days so it makes the beta branchoff

@zackmdavis

This comment has been minimized.

Copy link
Member

zackmdavis commented Dec 3, 2018

@oli-obk oh, thanks for the reminder; I hereby pledge to review this tonight (UTC -8, so like 12ish hours from now)

@zackmdavis

This comment has been minimized.

Copy link
Member

zackmdavis commented Dec 4, 2018

(I have some lingering uncertainty about exactly how deep of an understanding reviewers are morally obligated to exercise before r+ing; I don't personally have a lot of context on MIR/HAIR yet. But as code that looks sane, from a core contributor, that's fixing an ICE (rather than architecting new functionality), that passes Travis, I'm pretty sure this is fine.)

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 4, 2018

📌 Commit 8f9a093 has been approved by zackmdavis

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 5, 2018

⌛️ Testing commit 8f9a093 with merge 21cb46a...

bors added a commit that referenced this pull request Dec 5, 2018

Auto merge of #55922 - oli-obk:slice_pat_ice, r=zackmdavis
Fix ICE in `const` slice patterns

fixes #55911

based on #55915

New commits start at eabc155
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: zackmdavis
Pushing 21cb46a to master...

@bors bors merged commit 8f9a093 into rust-lang:master Dec 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment