Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace HashMap implementation with SwissTable #56241
Conversation
rust-highfive
assigned
sfackler
Nov 26, 2018
This comment has been minimized.
This comment has been minimized.
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
label
Nov 26, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors try cc @rust-lang/infra, this should get a perf run as soon as the try build finishes (it's needed for the second day of impl days at rustfest rome) |
added a commit
that referenced
this pull request
Nov 26, 2018
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
@bors try delegate+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Nov 26, 2018
This comment was marked as outdated.
This comment was marked as outdated.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment was marked as outdated.
This comment was marked as outdated.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-author
and removed
S-waiting-on-review
labels
Nov 26, 2018
This comment was marked as outdated.
This comment was marked as outdated.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Amanieu
referenced this pull request
Nov 26, 2018
Open
compare compiler performance with `hashbrown` #55514
This comment has been minimized.
This comment has been minimized.
|
It seems that the new |
This comment has been minimized.
This comment has been minimized.
|
@Amanieu The workaround is to remove |
This comment has been minimized.
This comment has been minimized.
|
Oh, wait a second, this PR doesn't actually modify |
This comment has been minimized.
This comment has been minimized.
|
Did the previous |
This comment has been minimized.
This comment has been minimized.
|
@petrochenkov There are no ordering guarantees in I am currently trying to narrow down the exact hash map that is causing the issue. I can confirm that switching only Note that it is also possible that there is a bug in the new |
This comment has been minimized.
This comment has been minimized.
Fix: order of elements with a hash collision, not the general order.
Yes, it's better to bisect all uses of |
gnzlbg
reviewed
Nov 27, 2018
gnzlbg
reviewed
Nov 27, 2018
gnzlbg
reviewed
Nov 27, 2018
Amanieu
added some commits
Nov 28, 2018
Amanieu
force-pushed the
Amanieu:hashbrown2
branch
from
f770977
to
ec35c14
Dec 11, 2018
Amanieu
force-pushed the
Amanieu:hashbrown2
branch
from
ec35c14
to
3bee3c0
Dec 11, 2018
Amanieu
referenced this pull request
Dec 18, 2018
Open
Use the parking_lot locking primitives #56410
nnethercote
referenced this pull request
Dec 18, 2018
Merged
Use an `FxHashMap` in `RegDiversions`. #626
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
(my review is currently on hold as i deal with some medical issues, sorry) |
Amanieu
referenced this pull request
Dec 24, 2018
Closed
Drop impl for RawTable should be #[may_dangle] #39
mati865
referenced this pull request
Dec 29, 2018
Closed
internal lint: forbid HashMap and HashSet and suggest the FxHash* variants #2853
This comment has been minimized.
This comment has been minimized.
stokhos
commented
Jan 14, 2019
|
Ping from triage @sfackler have you had time to review this pr? |
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton suggested that instead of copying hashbrown into libstd, we could have libstd import hashbrown directly as an |
This comment has been minimized.
This comment has been minimized.
|
Ping from triage @Amanieu / @alexcrichton: What are the plans for this PR? |
This comment has been minimized.
This comment has been minimized.
|
(still on medical leave) i do not think we should extern hashbrown without the review we would require to merge this code |
This comment has been minimized.
This comment has been minimized.
|
I would prefer to:
@Gankro get well soon and don't stress yourself about the review ! |
This comment has been minimized.
This comment has been minimized.
|
I'm going to leave the PR as it is until the review is finished. I will be integrating any feedback back into the hashbrown repo. |
This comment has been minimized.
This comment has been minimized.
panaman67
commented
Jan 24, 2019
|
Really excited for this commit. Great work! |
TimNN
added
S-blocked
and removed
S-waiting-on-author
labels
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
Thanks for the update!
Couldn't agree more, get better soon! I'm marking this as blocked for the moment, so it doesn't show up during the regular PR triage. |
Amanieu commentedNov 26, 2018
•
edited
The implementation is from the hashbrown crate.
This is mostly complete, however it is missing 2 features:
try_reserve-- DONEcc @pietroalbini @Gankro