Replace HashMap implementation with SwissTable (as an external crate) #58623

Amanieu · Feb 21, 2019

This is the same as #56241 except that it imports hashbrown as an external crate instead of copying the implementation into libstd.

This includes a few API changes (all unstable):

try_reserve is added to HashSet.
Some trait bounds have been changed in the raw_entry API.
search_bucket has been removed from the raw_entry API (doesn't work with SwissTable).

rust-highfive · Feb 21, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · Feb 21, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

Amanieu · Feb 21, 2019

r? @alexcrichton

rust-highfive · Feb 21, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0b7b47fa:start=1550783174954297002,finish=1550783175943995694,duration=989698692
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:01:57] 
######################################################################## 100.0%
[00:01:57] extracting /checkout/obj/build/cache/2019-02-17/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:57]     Updating crates.io index
[00:02:09]     Updating git repository `https://github.com/Amanieu/hashbrown`
[00:02:10]   Downloaded cmake v0.1.35
[00:02:10]   Downloaded lazy_static v0.2.11
[00:02:10]   Downloaded num_cpus v1.10.0
[00:02:10]   Downloaded serde_json v1.0.38
---

[00:04:05] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:06] tidy error: /checkout/src/libstd/collections/hash/map.rs:440: TODO is deprecated; use FIXME
[00:04:07] Dependencies not on the whitelist:
[00:04:07] * autocfg 
[00:04:07] * fuchsia-cprng 
[00:04:07] * rand_os 
[00:04:07] * rdrand 
[00:04:07] * rdrand 
[00:04:07] invalid source: "git+https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0afdac18e6ece8c74f38e5e78e1c68ee17"
[00:04:07] some tidy checks failed
[00:04:07] 
[00:04:07] 
[00:04:07] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:07] 
[00:04:07] 
[00:04:07] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:07] Build completed unsuccessfully in 0:00:48
[00:04:07] Build completed unsuccessfully in 0:00:48
[00:04:07] Makefile:68: recipe for target 'tidy' failed
[00:04:07] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:23336ad2
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu Feb 21 21:10:34 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

gnzlbg · Feb 21, 2019

Is this blocked on the review of #56241 ?

rust-highfive · Feb 22, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:00b4c8b5:start=1550836397319031263,finish=1550836695311659100,duration=297992627837
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:02:49] 
######################################################################## 100.0%
[00:02:49] extracting /checkout/obj/build/cache/2019-02-17/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:02:49]     Updating crates.io index
[00:03:24]     Updating git repository `https://github.com/Amanieu/hashbrown`
[00:03:25]   Downloaded petgraph v0.4.13
[00:03:25]   Downloaded serde_derive v1.0.81
[00:03:25]   Downloaded time v0.1.40
[00:03:25]   Downloaded getopts v0.2.17
---
[00:06:00]    Compiling rustc-demangle v0.1.10
[00:06:00]    Compiling panic_abort v0.0.0 (/checkout/src/libpanic_abort)
[00:06:04]    Compiling rustc-std-workspace-alloc v1.0.0 (/checkout/src/tools/rustc-std-workspace-alloc)
[00:06:04]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:06:05]    Compiling hashbrown v0.1.8 (https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0a)
[00:06:22] Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
[00:06:22] travis_fold:end:stage0-std

[00:06:22] travis_time:end:stage0-std:start=1550837029522207392,finish=1550837086562098635,duration=57039891243
---
[00:28:55]    Compiling panic_abort v0.0.0 (/checkout/src/libpanic_abort)
[00:28:55]    Compiling rustc-demangle v0.1.10
[00:29:01]    Compiling rustc-std-workspace-alloc v1.0.0 (/checkout/src/tools/rustc-std-workspace-alloc)
[00:29:01]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:29:01]    Compiling hashbrown v0.1.8 (https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0a)
[00:29:22] Copying stage1 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
[00:29:22] travis_fold:end:stage1-std

[00:29:22] travis_time:end:stage1-std:start=1550838395939538339,finish=1550838467114885749,duration=71175347410
---
[01:05:13]     Checking rustc_asan v0.0.0 (/checkout/src/librustc_asan)
[01:05:13]     Checking panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[01:05:13]     Checking rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[01:05:13]     Checking rustc_msan v0.0.0 (/checkout/src/librustc_msan)
[01:05:13]     Checking hashbrown v0.1.8 (https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0a)
[01:05:36]     Finished release [optimized] target(s) in 29.02s
[01:05:36] Documenting stage2 test (x86_64-unknown-linux-gnu)
[01:05:37]     Checking term v0.0.0 (/checkout/src/libterm)
[01:05:37]     Checking getopts v0.2.17
---
[01:11:19] .................................................................................................... 1900/5409
[01:11:23] .................................................................................................... 2000/5409
[01:11:27] ..................................................i................................................. 2100/5409
[01:11:31] .................................................................................................... 2200/5409
[01:11:35] ..................................F................................................................. 2300/5409
[01:11:44] .................................................................................................... 2500/5409
[01:11:48] .................................................................................................... 2600/5409
[01:11:52] .................................................................................................... 2700/5409
[01:11:57] .................................................................................................... 2800/5409
---
[01:13:42] 
[01:13:42] ---- [ui] ui/issues/issue-21763.rs stdout ----
[01:13:42] diff of stderr:
[01:13:42] 
[01:13:42] 4 LL |     foo::<HashMap<Rc<()>, Rc<()>>>();
[01:13:42] 5    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `std::rc::Rc<()>` cannot be sent between threads safely
[01:13:42] 6    |
[01:13:42] -    = help: within `std::collections::HashMap<std::rc::Rc<()>, std::rc::Rc<()>>`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`
[01:13:42] +    = help: within `(std::rc::Rc<()>, std::rc::Rc<()>)`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`
[01:13:42] 8    = note: required because it appears within the type `(std::rc::Rc<()>, std::rc::Rc<()>)`
[01:13:42] -    = note: required because it appears within the type `std::marker::PhantomData<(std::rc::Rc<()>, std::rc::Rc<()>)>`
[01:13:42] -    = note: required because it appears within the type `std::collections::hash::table::RawTable<std::rc::Rc<()>, std::rc::Rc<()>>`
[01:13:42] +    = note: required because of the requirements on the impl of `std::marker::Send` for `hashbrown::raw::RawTable<(std::rc::Rc<()>, std::rc::Rc<()>)>`
[01:13:42] +    = note: required because it appears within the type `hashbrown::map::HashMap<std::rc::Rc<()>, std::rc::Rc<()>, std::collections::hash_map::RandomState>`
[01:13:42] 11    = note: required because it appears within the type `std::collections::HashMap<std::rc::Rc<()>, std::rc::Rc<()>>`
[01:13:42] 12 note: required by `foo`
[01:13:42] 
[01:13:42] 
[01:13:42] The actual stderr differed from the expected stderr.
[01:13:42] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-21763/issue-21763.stderr
[01:13:42] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-21763/issue-21763.stderr
[01:13:42] To update references, rerun the tests and pass the `--bless` flag
[01:13:42] To only update this specific test, also pass `--test-args issues/issue-21763.rs`
[01:13:42] error: 1 errors occurred comparing output.
[01:13:42] status: exit code: 1
[01:13:42] status: exit code: 1
[01:13:42] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-21763.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-21763/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-21763/auxiliary" "-A" "unused"
[01:13:42] ------------------------------------------
[01:13:42] 
[01:13:42] ------------------------------------------
[01:13:42] stderr:
[01:13:42] stderr:
[01:13:42] ------------------------------------------
[01:13:42] {"message":"`std::rc::Rc<()>` cannot be sent between threads safely","code":{"code":"E0277","explanation":"\nYou tried to use a type which doesn't implement some trait in a place which\nexpected that trait. Erroneous code example:\n\n```compile_fail,E0277\n// here we declare the Foo trait with a bar method\ntrait Foo {\n    fn bar(&self);\n}\n\n// we now declare a function which takes an object implementing the Foo trait\nfn some_func<T: Foo>(foo: T) {\n    foo.bar();\n}\n\nfn main() {\n    // we now call the method with the i32 type, which doesn't implement\n    // the Foo trait\n    some_func(5i32); // error: the trait bound `i32 : Foo` is not satisfied\n}\n```\n\nIn order to fix this error, verify that the type you're using does implement\nthe trait. Example:\n\n```\ntrait Foo {\n    fn bar(&self);\n}\n\nfn some_func<T: Foo>(foo: T) {\n    foo.bar(); // we can now use this method since i32 implements the\n               // Foo trait\n}\n\n// we implement the trait on the i32 type\nimpl Foo for i32 {\n    fn bar(&self) {}\n}\n\nfn main() {\n    some_func(5i32); // ok!\n}\n```\n\nOr in a generic context, an erroneous code example would look like:\n\n```compile_fail,E0277\nfn some_func<T>(foo: T) {\n    println!(\"{:?}\", foo); // error: the trait `core::fmt::Debug` is not\n                           //        implemented for the type `T`\n}\n\nfn main() {\n    // We now call the method with the i32 type,\n    // which *does* implement the Debug trait.\n    some_func(5i32);\n}\n```\n\nNote that the error here is in the definition of the generic function: Although\nwe only call it with a parameter that does implement `Debug`, the compiler\nstill rejects the function: It must work with all possible input types. In\norder to make this example compile, we need to restrict the generic type we're\naccepting:\n\n```\nuse std::fmt;\n\n// Restrict the input type to types that implement Debug.\nfn some_func<T: fmt::Debug>(foo: T) {\n    println!(\"{:?}\", foo);\n}\n\nfn main() {\n    // Calling the method is still fine, as i32 implements Debug.\n    some_func(5i32);\n\n    // This would fail to compile now:\n    // struct WithoutDebug;\n    // some_func(WithoutDebug);\n}\n```\n\nRust only looks at the signature of the called function, as such it must\nalready specify all requirements that will be used for every type parameter.\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-21763.rs","byte_start":162,"byte_end":192,"line_start":9,"line_end":9,"column_start":5,"column_end":35,"is_primary":true,"text":[{"text":"    foo::<HashMap<Rc<()>, Rc<()>>>();","highlight_start":5,"highlight_end":35}],"label":"`std::rc::Rc<()>` cannot be sent between threads safely","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"within `(std::rc::Rc<()>, std::rc::Rc<()>)`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"required because it appears within the type `(std::rc::Rc<()>, std::rc::Rc<()>)`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"required because of the requirements on the impl of `std::marker::Send` for `hashbrown::raw::RawTable<(std::rc::Rc<()>, std::rc::Rc<()>)>`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"required because it appears within the type `hashbrown::map::HashMap<std::rc::Rc<()>, std::rc::Rc<()>, std::collections::hash_map::RandomState>`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"required because it appears within the type `std::collections::HashMap<std::rc::Rc<()>, std::rc::Rc<()>>`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"required by `foo`","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-21763.rs","byte_start":124,"byte_end":141,"line_start":6,"line_end":6,"column_start":1,"column_end":18,"is_primary":true,"text":[{"text":"fn foo<T: Send>() {}","highlight_start":1,"highlight_end":18}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0277]: `std::rc::Rc<()>` cannot be sent between threads safely\n  --> /checkout/src/test/ui/issues/issue-21763.rs:9:5\n   |\nLL |     foo::<HashMap<Rc<()>, Rc<()>>>();\n   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `std::rc::Rc<()>` cannot be sent between threads safely\n   |\n   = help: within `(std::rc::Rc<()>, std::rc::Rc<()>)`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`\n   = note: required because it appears within the type `(std::rc::Rc<()>, std::rc::Rc<()>)`\n   = note: required because of the requirements on the impl of `std::marker::Send` for `hashbrown::raw::RawTable<(std::rc::Rc<()>, std::rc::Rc<()>)>`\n   = note: required because it appears within the type `hashbrown::map::HashMap<std::rc::Rc<()>, std::rc::Rc<()>, std::collections::hash_map::RandomState>`\n   = note: required because it appears within the type `std::collections::HashMap<std::rc::Rc<()>, std::rc::Rc<()>>`\nnote: required by `foo`\n  --> /checkout/src/test/ui/issues/issue-21763.rs:6:1\n   |\nLL | fn foo<T: Send>() {}\n   | ^^^^^^^^^^^^^^^^^\n\n"}
[01:13:42] {"message":"For more information about this error, try `rustc --explain E0277`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0277`.\n"}
[01:13:42] 
[01:13:42] ------------------------------------------
[01:13:42] 
---
[01:13:42] 
[01:13:42] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:13:42] 
[01:13:42] 
[01:13:42] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:13:42] 
[01:13:42] 
[01:13:42] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:13:42] Build completed unsuccessfully in 0:04:35
[01:13:42] Build completed unsuccessfully in 0:04:35
[01:13:42] Makefile:48: recipe for target 'check' failed
[01:13:42] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:06b3f925
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Feb 22 13:12:07 UTC 2019
---
travis_time:end:080df13e:start=1550841129040537997,finish=1550841129045782102,duration=5244105
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0ce829d0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1b437d90
travis_time:start:1b437d90
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:06c2cfb8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · Feb 22, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:08945f30:start=1550841979055942243,finish=1550842064074396060,duration=85018453817
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
################################################                          67.6%
######################################################################## 100.0%
[00:05:45] extracting /checkout/obj/build/cache/2019-02-17/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:05:45]     Updating crates.io index
[00:05:56]     Updating git repository `https://github.com/Amanieu/hashbrown`
[00:05:58]   Downloaded cmake v0.1.33
[00:05:58]   Downloaded serde_derive v1.0.81
[00:05:58]   Downloaded getopts v0.2.17
[00:05:58]   Downloaded toml v0.4.10
---
[00:08:30]    Compiling panic_abort v0.0.0 (/checkout/src/libpanic_abort)
[00:08:30]    Compiling rustc-demangle v0.1.10
[00:08:34]    Compiling rustc-std-workspace-alloc v1.0.0 (/checkout/src/tools/rustc-std-workspace-alloc)
[00:08:34]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:08:34]    Compiling hashbrown v0.1.8 (https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0a)
[00:08:51] Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
[00:08:51] travis_fold:end:stage0-std

[00:08:51] travis_time:end:stage0-std:start=1550842548305667454,finish=1550842603804697380,duration=55499029926
---
[00:31:10]    Compiling panic_abort v0.0.0 (/checkout/src/libpanic_abort)
[00:31:10]    Compiling rustc-demangle v0.1.10
[00:31:15]    Compiling rustc-std-workspace-alloc v1.0.0 (/checkout/src/tools/rustc-std-workspace-alloc)
[00:31:15]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:31:15]    Compiling hashbrown v0.1.8 (https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0a)
[00:31:36] Copying stage1 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
[00:31:36] travis_fold:end:stage1-std

[00:31:36] travis_time:end:stage1-std:start=1550843900013830045,finish=1550843968736650178,duration=68722820133
---
[01:07:02]     Checking rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[01:07:02]     Checking panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[01:07:02]     Checking rustc_asan v0.0.0 (/checkout/src/librustc_asan)
[01:07:02]     Checking rustc_msan v0.0.0 (/checkout/src/librustc_msan)
[01:07:02]     Checking hashbrown v0.1.8 (https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0a)
[01:07:23]     Finished release [optimized] target(s) in 26.61s
[01:07:23] Documenting stage2 test (x86_64-unknown-linux-gnu)
[01:07:24]     Checking getopts v0.2.17
[01:07:24]     Checking proc_macro v0.0.0 (/checkout/src/libproc_macro)
---
[01:12:59] .................................................................................................... 1900/5409
[01:13:02] .................................................................................................... 2000/5409
[01:13:05] ..................................................i................................................. 2100/5409
[01:13:09] .................................................................................................... 2200/5409
[01:13:13] ..................................F................................................................. 2300/5409
[01:13:21] .................................................................................................... 2500/5409
[01:13:25] .................................................................................................... 2600/5409
[01:13:28] .................................................................................................... 2700/5409
[01:13:33] .................................................................................................... 2800/5409
---
[01:15:08] ---- [ui] ui/issues/issue-21763.rs stdout ----
[01:15:08] diff of stderr:
[01:15:08] 
[01:15:08] 6    |
[01:15:08] 7    = help: within `(std::rc::Rc<()>, std::rc::Rc<()>)`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`
[01:15:08] 8    = note: required because it appears within the type `(std::rc::Rc<()>, std::rc::Rc<()>)`
[01:15:08] -    = note: required because of the requirements on the impl of `std::marker::Send` for `std::collections::hash::raw::RawTable<(std::rc::Rc<()>, std::rc::Rc<()>)>`
[01:15:08] +    = note: required because of the requirements on the impl of `std::marker::Send` for `hashbrown::raw::RawTable<(std::rc::Rc<()>, std::rc::Rc<()>)>`
[01:15:08] +    = note: required because it appears within the type `hashbrown::map::HashMap<std::rc::Rc<()>, std::rc::Rc<()>, std::collections::hash_map::RandomState>`
[01:15:08] 10    = note: required because it appears within the type `std::collections::HashMap<std::rc::Rc<()>, std::rc::Rc<()>>`
[01:15:08] 11 note: required by `foo`
[01:15:08] 
[01:15:08] 
[01:15:08] The actual stderr differed from the expected stderr.
[01:15:08] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-21763/issue-21763.stderr
[01:15:08] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-21763/issue-21763.stderr
[01:15:08] To update references, rerun the tests and pass the `--bless` flag
[01:15:08] To only update this specific test, also pass `--test-args issues/issue-21763.rs`
[01:15:08] error: 1 errors occurred comparing output.
[01:15:08] status: exit code: 1
[01:15:08] status: exit code: 1
[01:15:08] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-21763.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-21763/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-21763/auxiliary" "-A" "unused"
[01:15:08] ------------------------------------------
[01:15:08] 
[01:15:08] ------------------------------------------
[01:15:08] stderr:
[01:15:08] stderr:
[01:15:08] ------------------------------------------
[01:15:08] {"message":"`std::rc::Rc<()>` cannot be sent between threads safely","code":{"code":"E0277","explanation":"\nYou tried to use a type which doesn't implement some trait in a place which\nexpected that trait. Erroneous code example:\n\n```compile_fail,E0277\n// here we declare the Foo trait with a bar method\ntrait Foo {\n    fn bar(&self);\n}\n\n// we now declare a function which takes an object implementing the Foo trait\nfn some_func<T: Foo>(foo: T) {\n    foo.bar();\n}\n\nfn main() {\n    // we now call the method with the i32 type, which doesn't implement\n    // the Foo trait\n    some_func(5i32); // error: the trait bound `i32 : Foo` is not satisfied\n}\n```\n\nIn order to fix this error, verify that the type you're using does implement\nthe trait. Example:\n\n```\ntrait Foo {\n    fn bar(&self);\n}\n\nfn some_func<T: Foo>(foo: T) {\n    foo.bar(); // we can now use this method since i32 implements the\n               // Foo trait\n}\n\n// we implement the trait on the i32 type\nimpl Foo for i32 {\n    fn bar(&self) {}\n}\n\nfn main() {\n    some_func(5i32); // ok!\n}\n```\n\nOr in a generic context, an erroneous code example would look like:\n\n```compile_fail,E0277\nfn some_func<T>(foo: T) {\n    println!(\"{:?}\", foo); // error: the trait `core::fmt::Debug` is not\n                           //        implemented for the type `T`\n}\n\nfn main() {\n    // We now call the method with the i32 type,\n    // which *does* implement the Debug trait.\n    some_func(5i32);\n}\n```\n\nNote that the error here is in the definition of the generic function: Although\nwe only call it with a parameter that does implement `Debug`, the compiler\nstill rejects the function: It must work with all possible input types. In\norder to make this example compile, we need to restrict the generic type we're\naccepting:\n\n```\nuse std::fmt;\n\n// Restrict the input type to types that implement Debug.\nfn some_func<T: fmt::Debug>(foo: T) {\n    println!(\"{:?}\", foo);\n}\n\nfn main() {\n    // Calling the method is still fine, as i32 implements Debug.\n    some_func(5i32);\n\n    // This would fail to compile now:\n    // struct WithoutDebug;\n    // some_func(WithoutDebug);\n}\n```\n\nRust only looks at the signature of the called function, as such it must\nalready specify all requirements that will be used for every type parameter.\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-21763.rs","byte_start":162,"byte_end":192,"line_start":9,"line_end":9,"column_start":5,"column_end":35,"is_primary":true,"text":[{"text":"    foo::<HashMap<Rc<()>, Rc<()>>>();","highlight_start":5,"highlight_end":35}],"label":"`std::rc::Rc<()>` cannot be sent between threads safely","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"within `(std::rc::Rc<()>, std::rc::Rc<()>)`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"required because it appears within the type `(std::rc::Rc<()>, std::rc::Rc<()>)`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"required because of the requirements on the impl of `std::marker::Send` for `hashbrown::raw::RawTable<(std::rc::Rc<()>, std::rc::Rc<()>)>`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"required because it appears within the type `hashbrown::map::HashMap<std::rc::Rc<()>, std::rc::Rc<()>, std::collections::hash_map::RandomState>`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"required because it appears within the type `std::collections::HashMap<std::rc::Rc<()>, std::rc::Rc<()>>`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"required by `foo`","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-21763.rs","byte_start":124,"byte_end":141,"line_start":6,"line_end":6,"column_start":1,"column_end":18,"is_primary":true,"text":[{"text":"fn foo<T: Send>() {}","highlight_start":1,"highlight_end":18}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0277]: `std::rc::Rc<()>` cannot be sent between threads safely\n  --> /checkout/src/test/ui/issues/issue-21763.rs:9:5\n   |\nLL |     foo::<HashMap<Rc<()>, Rc<()>>>();\n   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `std::rc::Rc<()>` cannot be sent between threads safely\n   |\n   = help: within `(std::rc::Rc<()>, std::rc::Rc<()>)`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`\n   = note: required because it appears within the type `(std::rc::Rc<()>, std::rc::Rc<()>)`\n   = note: required because of the requirements on the impl of `std::marker::Send` for `hashbrown::raw::RawTable<(std::rc::Rc<()>, std::rc::Rc<()>)>`\n   = note: required because it appears within the type `hashbrown::map::HashMap<std::rc::Rc<()>, std::rc::Rc<()>, std::collections::hash_map::RandomState>`\n   = note: required because it appears within the type `std::collections::HashMap<std::rc::Rc<()>, std::rc::Rc<()>>`\nnote: required by `foo`\n  --> /checkout/src/test/ui/issues/issue-21763.rs:6:1\n   |\nLL | fn foo<T: Send>() {}\n   | ^^^^^^^^^^^^^^^^^\n\n"}
[01:15:08] {"message":"For more information about this error, try `rustc --explain E0277`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0277`.\n"}
[01:15:08] 
[01:15:08] ------------------------------------------
[01:15:08] 
---
[01:15:08] 
[01:15:08] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:15:08] 
[01:15:08] 
[01:15:08] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:15:08] 
[01:15:08] 
[01:15:08] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:15:08] Build completed unsuccessfully in 0:04:14
[01:15:08] Build completed unsuccessfully in 0:04:14
[01:15:08] make: *** [check] Error 1
[01:15:08] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:044d37da
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Feb 22 14:43:01 UTC 2019
---
travis_time:end:12c8ad82:start=1550846583040003467,finish=1550846583047892883,duration=7889416
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0706f548
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0a593634
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · Feb 22, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0cf42d8c:start=1550847506732434047,finish=1550847647656849386,duration=140924415339
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
#######################################################################   98.9%
######################################################################## 100.0%
[00:01:29] extracting /checkout/obj/build/cache/2019-02-17/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:29]     Updating crates.io index
[00:01:41]     Updating git repository `https://github.com/Amanieu/hashbrown`
[00:01:42]   Downloaded filetime v0.2.4
[00:01:42]   Downloaded libc v0.2.46
[00:01:42]   Downloaded toml v0.4.10
[00:01:42]   Downloaded serde_derive v1.0.81
---
[00:04:09]    Compiling rustc-demangle v0.1.10
[00:04:10]    Compiling panic_abort v0.0.0 (/checkout/src/libpanic_abort)
[00:04:14]    Compiling rustc-std-workspace-alloc v1.0.0 (/checkout/src/tools/rustc-std-workspace-alloc)
[00:04:14]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:04:14]    Compiling hashbrown v0.1.8 (https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0a)
[00:04:31] Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
[00:04:31] travis_fold:end:stage0-std

[00:04:31] travis_time:end:stage0-std:start=1550847892598802010,finish=1550847947562097407,duration=54963295397
---
[00:26:36]    Compiling rustc-demangle v0.1.10
[00:26:36]    Compiling panic_abort v0.0.0 (/checkout/src/libpanic_abort)
[00:26:41]    Compiling rustc-std-workspace-alloc v1.0.0 (/checkout/src/tools/rustc-std-workspace-alloc)
[00:26:41]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:26:41]    Compiling hashbrown v0.1.8 (https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0a)
[00:27:02] Copying stage1 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
[00:27:02] travis_fold:end:stage1-std

[00:27:02] travis_time:end:stage1-std:start=1550849231240092681,finish=1550849298840313806,duration=67600221125
---
[01:01:48]     Checking rustc_asan v0.0.0 (/checkout/src/librustc_asan)
[01:01:48]     Checking rustc_lsan v0.0.0 (/checkout/src/librustc_lsan)
[01:01:48]     Checking rustc_msan v0.0.0 (/checkout/src/librustc_msan)
[01:01:48]     Checking rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[01:01:48]     Checking hashbrown v0.1.8 (https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0a)
[01:02:07]     Finished release [optimized] target(s) in 24.97s
[01:02:07] Documenting stage2 test (x86_64-unknown-linux-gnu)
[01:02:08]     Checking proc_macro v0.0.0 (/checkout/src/libproc_macro)
[01:02:08]     Checking getopts v0.2.17
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:17:06] 
[01:17:06] running 119 tests
[01:17:31] .iiiii...i.....i..i...i..i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i.i. 100/119
[01:17:35] i......iii.i.....ii
[01:17:35] 
[01:17:35]  finished in 28.736
[01:17:35] travis_fold:end:test_debuginfo

---
[01:32:44] travis_fold:start:test_stage1-std
travis_time:start:test_stage1-std
Testing std stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:32:44]    Compiling std v0.0.0 (/checkout/src/libstd)
[01:32:50] error[E0599]: no method named `raw_capacity` found for type `collections::hash::map::HashMap<_, _>` in the current scope
[01:32:50]      |
[01:32:50]      |
[01:32:50] 205  | pub struct HashMap<K, V, S = RandomState> {
[01:32:50]      | ----------------------------------------- method `raw_capacity` not found for this
[01:32:50] ...
[01:32:50] 3121 |         let old_raw_cap = m.raw_capacity();
[01:32:50]      |                             ^^^^^^^^^^^^ help: did you mean: `capacity`
[01:32:50] 
[01:32:50] error[E0599]: no method named `raw_capacity` found for type `collections::hash::map::HashMap<_, _>` in the current scope
[01:32:50]      |
[01:32:50]      |
[01:32:50] 205  | pub struct HashMap<K, V, S = RandomState> {
[01:32:50]      | ----------------------------------------- method `raw_capacity` not found for this
[01:32:50] ...
[01:32:50] 3122 |         while old_raw_cap == m.raw_capacity() {
[01:32:50]      |                                ^^^^^^^^^^^^ help: did you mean: `capacity`
[01:32:50] 
[01:32:50] error[E0599]: no method named `raw_capacity` found for type `collections::hash::map::HashMap<_, _>` in the current scope
[01:32:50]      |
[01:32:50]      |
[01:32:50] 205  | pub struct HashMap<K, V, S = RandomState> {
[01:32:50]      | ----------------------------------------- method `raw_capacity` not found for this
[01:32:50] ...
[01:32:50] 3136 |         assert_eq!(m.raw_capacity(), 1);
[01:32:50]      |                      ^^^^^^^^^^^^ help: did you mean: `capacity`
[01:32:50] 
[01:32:50] error[E0599]: no method named `raw_capacity` found for type `collections::hash::map::HashMap<{integer}, {integer}>` in the current scope
[01:32:50]      |
[01:32:50]      |
[01:32:50] 205  | pub struct HashMap<K, V, S = RandomState> {
[01:32:50]      | ----------------------------------------- method `raw_capacity` not found for this
[01:32:50] ...
[01:32:50] 3142 |         let initial_raw_cap = m.raw_capacity();
[01:32:50]      |                                 ^^^^^^^^^^^^ help: did you mean: `capacity`
[01:32:50] 
[01:32:50] error[E0599]: no method named `raw_capacity` found for type `collections::hash::map::HashMap<{integer}, {integer}>` in the current scope
[01:32:50]      |
[01:32:50]      |
[01:32:50] 205  | pub struct HashMap<K, V, S = RandomState> {
[01:32:50]      | ----------------------------------------- method `raw_capacity` not found for this
[01:32:50] ...
[01:32:50] 3144 |         let raw_cap = m.raw_capacity();
[01:32:50]      |                         ^^^^^^^^^^^^ help: did you mean: `capacity`
[01:32:50] 
[01:32:50] error[E0599]: no method named `raw_capacity` found for type `collections::hash::map::HashMap<usize, usize>` in the current scope
[01:32:50]      |
[01:32:50]      |
[01:32:50] 205  | pub struct HashMap<K, V, S = RandomState> {
[01:32:50]      | ----------------------------------------- method `raw_capacity` not found for this
[01:32:50] ...
[01:32:50] 3156 |         assert_eq!(m.raw_capacity(), raw_cap);
[01:32:50]      |                      ^^^^^^^^^^^^ help: did you mean: `capacity`
[01:32:50] 
[01:32:50] error[E0599]: no method named `raw_capacity` found for type `collections::hash::map::HashMap<usize, usize>` in the current scope
[01:32:50]      |
[01:32:50]      |
[01:32:50] 205  | pub struct HashMap<K, V, S = RandomState> {
[01:32:50]      | ----------------------------------------- method `raw_capacity` not found for this
[01:32:50] ...
[01:32:50] 3164 |         let new_raw_cap = m.raw_capacity();
[01:32:50]      |                             ^^^^^^^^^^^^ help: did you mean: `capacity`
[01:32:50] 
[01:32:50] error[E0599]: no method named `raw_capacity` found for type `collections::hash::map::HashMap<usize, usize>` in the current scope
[01:32:50]      |
[01:32:50]      |
[01:32:50] 205  | pub struct HashMap<K, V, S = RandomState> {
[01:32:50]      | ----------------------------------------- method `raw_capacity` not found for this
[01:32:50] ...
[01:32:50] 3170 |             assert_eq!(m.raw_capacity(), new_raw_cap);
[01:32:50]      |                          ^^^^^^^^^^^^ help: did you mean: `capacity`
[01:32:50] 
[01:32:50] error[E0599]: no method named `raw_capacity` found for type `collections::hash::map::HashMap<usize, usize>` in the current scope
[01:32:50]      |
[01:32:50]      |
[01:32:50] 205  | pub struct HashMap<K, V, S = RandomState> {
[01:32:50]      | ----------------------------------------- method `raw_capacity` not found for this
[01:32:50] ...
[01:32:50] 3174 |         assert_eq!(m.raw_capacity(), raw_cap);
[01:32:50]      |                      ^^^^^^^^^^^^ help: did you mean: `capacity`
[01:32:50] 
[01:32:50] error[E0599]: no method named `raw_capacity` found for type `collections::hash::map::HashMap<usize, usize>` in the current scope
[01:32:50]      |
[01:32:50]      |
[01:32:50] 205  | pub struct HashMap<K, V, S = RandomState> {
[01:32:50]      | ----------------------------------------- method `raw_capacity` not found for this
[01:32:50] ...
[01:32:50] 3184 |         assert_eq!(m.raw_capacity(), initial_raw_cap);
[01:32:50]      |                      ^^^^^^^^^^^^ help: did you mean: `capacity`
[01:32:56] error: aborting due to 10 previous errors
[01:32:56] 
[01:32:56] For more information about this error, try `rustc --explain E0599`.
[01:32:56] error: Could not compile `std`.
[01:32:56] error: Could not compile `std`.
[01:32:56] 
[01:32:56] To learn more, run the command again with --verbose.
[01:32:56] 
[01:32:56] 
[01:32:56] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "std" "--" "--quiet"
[01:32:56] 
[01:32:56] 
[01:32:56] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:32:56] Build completed unsuccessfully in 0:27:25
[01:32:56] Build completed unsuccessfully in 0:27:25
[01:32:56] make: *** [check] Error 1
[01:32:56] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1f97819a
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Feb 22 16:34:13 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · Feb 22, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:27256134:start=1550855847061037770,finish=1550855986444044834,duration=139383007064
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:03:52] 
######################################################################## 100.0%
[00:03:53] extracting /checkout/obj/build/cache/2019-02-17/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:03:53]     Updating crates.io index
[00:04:05]     Updating git repository `https://github.com/Amanieu/hashbrown`
[00:04:07]   Downloaded toml v0.4.10
[00:04:07]   Downloaded lazy_static v0.2.11
[00:04:07]   Downloaded petgraph v0.4.13
[00:04:07]   Downloaded cc v1.0.28
---
[00:06:52]    Compiling panic_abort v0.0.0 (/checkout/src/libpanic_abort)
[00:06:52]    Compiling rustc-demangle v0.1.10
[00:06:57]    Compiling rustc-std-workspace-alloc v1.0.0 (/checkout/src/tools/rustc-std-workspace-alloc)
[00:06:57]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:06:57]    Compiling hashbrown v0.1.8 (https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0a)
[00:07:15] Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
[00:07:15] travis_fold:end:stage0-std

[00:07:15] travis_time:end:stage0-std:start=1550856370233384723,finish=1550856431085034599,duration=60851649876
---
[00:31:29]    Compiling panic_abort v0.0.0 (/checkout/src/libpanic_abort)
[00:31:29]    Compiling rustc-demangle v0.1.10
[00:31:35]    Compiling rustc-std-workspace-alloc v1.0.0 (/checkout/src/tools/rustc-std-workspace-alloc)
[00:31:35]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:31:35]    Compiling hashbrown v0.1.8 (https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0a)
[00:31:58] Copying stage1 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
[00:31:58] travis_fold:end:stage1-std

[00:31:58] travis_time:end:stage1-std:start=1550857839309315208,finish=1550857914259204906,duration=74949889698
---
[01:10:11]     Checking rustc_asan v0.0.0 (/checkout/src/librustc_asan)
[01:10:11]     Checking panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[01:10:11]     Checking rustc_lsan v0.0.0 (/checkout/src/librustc_lsan)
[01:10:11]     Checking rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[01:10:11]     Checking hashbrown v0.1.8 (https://github.com/Amanieu/hashbrown?branch=libstd#4f1cfb0a)
[01:10:32]     Finished release [optimized] target(s) in 27.93s
[01:10:33] Documenting stage2 test (x86_64-unknown-linux-gnu)
[01:10:33]     Checking term v0.0.0 (/checkout/src/libterm)
[01:10:33]     Checking getopts v0.2.17
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:27:21] 
[01:27:21] running 119 tests
[01:27:50] .iiiii...i.....i..i...i..i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i.i. 100/119
[01:27:55] i......iii.i.....ii
[01:27:55] 
[01:27:55]  finished in 33.860
[01:27:55] travis_fold:end:test_debuginfo

---
[01:47:11] thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
[01:47:11]   left: `1`,
[01:47:11]  right: `2`', src/libstd/collections/hash/map.rs:3152:9
[01:47:11] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:47:11] ..........F......................................................................................... 100/763
[01:47:11] thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/buffered.rs:1290:17
[01:47:11] thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/buffered.rs:1277:9
[01:47:11] thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/stdio.rs:793:13
[01:47:11] .................................................................................................... 300/763
---
[01:47:23] 
[01:47:23] error: test failed, to rerun pass '--lib'
[01:47:23] 
[01:47:23] 
[01:47:23] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "std" "--" "--quiet"
[01:47:23] 
[01:47:23] 
[01:47:23] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:47:23] Build completed unsuccessfully in 0:33:11
[01:47:23] Build completed unsuccessfully in 0:33:11
[01:47:23] make: *** [check] Error 1
[01:47:23] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:10327b84
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Feb 22 19:07:20 UTC 2019
---
travis_time:end:189cfc80:start=1550862442226217131,finish=1550862442232160897,duration=5943766
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0dafe3d7
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:05e73a4c
travis_time:start:05e73a4c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

stjepang · Feb 23, 2019

Can we do a crater run to see if there are any regressions?

Amanieu · Feb 24, 2019

Is this blocked on the review of #56241 ?

Sort-of. I've been including most of the feedback from that thread into hashbrown itself.

bors · Feb 25, 2019

☔️ The latest upstream changes (presumably #58714) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · Feb 25, 2019

@bors: try

While review progresses let's in parallel start some programmatic analysis! (aka perf runs, crater runs, etc)

bors · Feb 25, 2019

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout hashbrown3 (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self hashbrown3 --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

warning: Cannot merge binary files: Cargo.lock (HEAD vs. heads/homu-tmp)
Auto-merging src/libstd/lib.rs
Removing src/libstd/collections/hash/table.rs
Auto-merging src/libstd/collections/hash/set.rs
CONFLICT (content): Merge conflict in src/libstd/collections/hash/set.rs
Auto-merging src/libstd/collections/hash/map.rs
CONFLICT (content): Merge conflict in src/libstd/collections/hash/map.rs
Auto-merging Cargo.lock
CONFLICT (content): Merge conflict in Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

Amanieu · Feb 25, 2019

This issue should probably be addressed before merging: Amanieu/hashbrown#47

alexcrichton · Feb 25, 2019

@bors: try

bors · Feb 25, 2019

⌛️ Trying commit 76003ba with merge abade53...

bors · Feb 26, 2019

💥 Test timed out

alexcrichton · Feb 26, 2019

@rust-timer build abade53

Amanieu · Mar 7, 2019

The test failures for FlixCoder.EvoResNN and clinuxrulz.sodium-rust-push-pull don't reproduce locally, so I'm just going to mark them as spurious.

cargo-lichking seems to be a real regression though, and I might need a bit of help figuring it out.

There is a compile error on this line:

error[E0597]: `packages` does not live long enough
  --> src/load.rs:43:30
   |
43 |         if let Ok(package) = packages.get_one(id) {
   |                              ^^^^^^^^ borrowed value does not live long enough
...
60 | }
   | - `packages` dropped here while still borrowed
   |
   = note: values in a scope are dropped in the opposite order they are created

This error does not happen on master. Adding #![feature(nll)] to the crate fixes the error.

Any ideas?

Amanieu · Mar 7, 2019

I think this may be related to #[may_dangle] on RawTable. The old implementation has this:

unsafe impl<#[may_dangle] K, #[may_dangle] V> Drop for RawTable<K, V> {
    ...
}

While hashbrown has this instead:

unsafe impl<#[may_dangle] T> Drop for RawTable<T> {
    ...
}

(HashMap<K, V> contains a RawTable<(K, V)>)

alexcrichton · Mar 7, 2019

@gnzlbg or @RalfJung would y'all be up for helping out getting miri working/running on hashbrown's CI?

@Amanieu at least for me I have barely any idea what #[may_dangle] does much less how it'd change for K, V vs (K, V), but maybe folks on the compiler channel on discord know?

Gankro · Mar 7, 2019

It sounds like a bug in may_dangle.

cc @nikomatsakis @pnkfelix -- there shouldn't be any difference with Foo<(K, V)> and Foo<K, V> with #[may_dangle], right?

gnzlbg · Mar 7, 2019

@alexcrichton

would y'all be up for helping out getting miri working/running on hashbrown's CI?

Amanieu/hashbrown#51 cc @RalfJung

Once hashbrown is moved into the rust-lang org I can work on setting up better CI for it.

RalfJung · Mar 8, 2019

would y'all be up for helping out getting miri working/running on hashbrown's CI?

@gnzlbg already took care of that, awesome. :)

matthewjasper · Mar 8, 2019

OK, I've had a look at the drop check issue. There are two problems:

RawIntoIter<T> is missing #[may_dangle] for its Drop implementation.
RawTable<T> and RawIntoIter<T> are missing PhantomData<T>. For RawIntoIter<T> this only matters after 1 is fixed.

I've checked all of the remaining structs, and everything else looks good.

Full review

Live means that all lifetimes in this type argument must be live
Owned means that only the dropck live lifetimes in the type argument must be live
Unused means that there is no restriction

`hash_map`

Current

Type	Live	Owned	Unused
`HashMap<K, V, S>`		`K`, `V`, `S`
`Drain<'a, K, V>`	`'a`, `K`, `V`
`Entry<'a, K, V>`		`K`	`'a`, `V`
`IntoIter<K, V>`		`K`, `V`
`Iter<'a, K, V>`			`'a`, `K`, `V`
`IterMut<'a, K, V>`			`'a`, `K`, `V`
`Keys<'a, K, V>`			`'a`, `K`, `V`
`OccupiedEntry<'a, K, V>`		`K`	`'a`, `V`
`VacantEntry<'a, K, V>`		`K`	`'a`, `V`
`Values<'a, K, V>`			`'a`, `K`, `V`
`ValuesMut<'a, K, V>`			`'a`, `K`, `V`

hashbrown

Type	Live	Owned	Unused
`HashMap<K, V, S>`		`S`	`K`, `V`
`Drain<'a, K, V>`	`'a`, `K`, `V`
`Entry<'a, K, V>`		`K`	`'a`, `V`
`IntoIter<K, V>`	`K`, `V`
`Iter<'a, K, V>`			`'a`, `K`, `V`
`IterMut<'a, K, V>`			`'a`, `K`, `V`
`Keys<'a, K, V>`			`'a`, `K`, `V`
`OccupiedEntry<'a, K, V>`		`K`	`'a`, `V`
`VacantEntry<'a, K, V>`		`K`	`'a`, `V`
`Values<'a, K, V>`			`'a`, `K`, `V`
`ValuesMut<'a, K, V>`			`'a`, `K`, `V`

`hash_set`

Current

Type	Live	Owned	Unused
`HashSet<T, S>`		`S`, `T`
`Difference<'a, T, S>`			`'a`, `T`, `S`
`Drain<'a, K>`	`'a`, `K`
`Intersection<'a, T, S>`			`'a`, `T`, `S`
`IntoIter<K>`		`K`
`Iter<'a, K>`			`'a`, `K`
`SymmetricDifference<'a, T, S>`			`'a`, `T`, `S`
`Union<'a, T, S>`			`'a`, `T`, `S`

hashbrown

Type	Live	Owned	Unused
`HashSet<T, S>`		`S`	`T`
`Difference<'a, T, S>`			`'a`, `T`, `S`
`Drain<'a, K>`	`'a`, `K`
`Intersection<'a, T, S>`			`'a`, `T`, `S`
`IntoIter<K>`	`K`
`Iter<'a, K>`			`'a`, `K`
`SymmetricDifference<'a, T, S>`			`'a`, `T`, `S`
`Union<'a, T, S>`			`'a`, `T`, `S`

Example tests (independant of NLL)

Test case for 1.

fn check_hash_set() {
    fn equate<T>(
        _: &mut Option<std::collections::hash_set::IntoIter<T>>,
        _: &mut T
    ) {}
    let (mut x, a, mut k);
    x = None;
    a = 0;
    k = &a;
    equate(&mut x, &mut k);
}

fn check_hash_map() {
    fn equate<K, V>(
        _: &mut Option<std::collections::hash_map::IntoIter<K, V>>,
        _: &mut (K, V)
    ) {}
    let (mut x, a, mut k);
    x = None;
    a = 0;
    k = (&a, &a);
    equate(&mut x, &mut k);
}

Test case for 2. (I'm not sure if we add ui tests for the standard library)

struct D<'a>(&'a i32);

impl Drop for D<'_> {
    fn drop(&mut self) {}
}

fn check_hash_set() {
    fn equate<T>(
        _: &mut Option<std::collections::HashSet<T>>,  // and likewise for hash_map::IntoIter
        _: &mut T
    ) {}
    let (mut x, a);
    let mut k;
    x = None;
    a = 0;
    k = D(&a); //~ ERROR
    equate(&mut x, &mut k);
}


fn check_hash_map() {
    fn equate<K, V>(
        _: &mut Option<std::collections::HashMap<K, V>>, // and likewise for hash_map::IntoIter
        _: &mut (K, V)
    ) {}
    let (mut x, a, b);
    let mut k;
    x = None;
    a = 0;
    b = 0;
    k = (
        D(&a), //~ ERROR
        D(&b), //~ ERROR
    );
    equate(&mut x, &mut k);
}

bors · Mar 9, 2019

☔️ The latest upstream changes (presumably #59012) made this pull request unmergeable. Please resolve the merge conflicts.

Amanieu · Mar 9, 2019

@matthewjasper Thanks! I've done the changes you suggested and the regression on cargo-lichking is now fixed!

bors · Mar 16, 2019

☔️ The latest upstream changes (presumably #59226) made this pull request unmergeable. Please resolve the merge conflicts.

Centril · Mar 30, 2019

@Amanieu you have some rebasing to do; @alexcrichton you have some reviewing to do?

rust-highfive · Mar 30, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0e6d61c0:start=1553954328847513400,finish=1553954331334151334,duration=2486637934
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[00:01:55] 
######################################################################## 100.0%
[00:01:56] extracting /checkout/obj/build/cache/2019-03-20/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:56]     Updating crates.io index
[00:02:09]     Updating git repository `https://github.com/Amanieu/hashbrown`
[00:02:11]   Downloaded cmake v0.1.33
[00:02:11]   Downloaded toml v0.4.10
[00:02:11]   Downloaded time v0.1.40
[00:02:11]   Downloaded cc v1.0.28
---
tidy check
[00:04:04] * 569 error codes
[00:04:04] * highest error code: E0725
[00:04:05] * 252 features
[00:04:06] invalid source: "git+https://github.com/Amanieu/hashbrown?branch=libstd#a0dfde50e2be7dbba39b86154d7362c4801cdea1"
[00:04:06] some tidy checks failed
[00:04:06] 
[00:04:06] 
[00:04:06] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:06] 
[00:04:06] 
[00:04:06] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:06] Build completed unsuccessfully in 0:00:46
[00:04:06] Build completed unsuccessfully in 0:00:46
[00:04:06] Makefile:67: recipe for target 'tidy' failed
[00:04:06] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:05fdae58
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sat Mar 30 14:03:08 UTC 2019
---
travis_time:end:1b0eeaf0:start=1553954589503298319,finish=1553954589508286723,duration=4988404
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:175fbf96
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0a135065
travis_time:start:0a135065
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:03ad80ac
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · Mar 31, 2019

☔️ The latest upstream changes (presumably #59584) made this pull request unmergeable. Please resolve the merge conflicts.

Amanieu · Apr 2, 2019

I just published hashbrown 0.2.0 which includes the changes necessary for inclusion in libstd. This PR is ready for merging.

alexcrichton · Apr 3, 2019

Nice!

Since we're so close to a release (next Thursday), @Amanieu would you be ok delaying this for a week to ensure we maximize the amount of testing time?

rust-highfive assigned nikomatsakis Feb 21, 2019

rust-highfive added the S-waiting-on-review label Feb 21, 2019

rust-highfive assigned alexcrichton and unassigned nikomatsakis Feb 21, 2019

Amanieu referenced this pull request Feb 21, 2019
Closed
Replace HashMap implementation with SwissTable #56241
2 of 2 tasks complete

Amanieu force-pushed the Amanieu:hashbrown3 branch from 23d4b1f to 98ef879 Feb 22, 2019

Amanieu force-pushed the Amanieu:hashbrown3 branch from b42286f to e08307b Feb 22, 2019

Amanieu force-pushed the Amanieu:hashbrown3 branch from e08307b to 4ba6550 Feb 22, 2019

Amanieu force-pushed the Amanieu:hashbrown3 branch from 2b917d0 to 76003ba Feb 25, 2019

Amanieu referenced this pull request Feb 25, 2019
Merged
Prepare hashbrown for inclusion in the standard library #46

Amanieu force-pushed the Amanieu:hashbrown3 branch from 0aac051 to a238a95 Mar 9, 2019

Zoxc referenced this pull request Mar 9, 2019
Open
HirIdification: rework Map #59042

jugglerchris referenced this pull request Mar 11, 2019
Open
next() function #15

vthriller referenced this pull request Mar 20, 2019
Closed
Compatibility with hashbrown #2

Amanieu force-pushed the Amanieu:hashbrown3 branch from a238a95 to 1d30c64 Mar 30, 2019

bors bot added a commit to Amanieu/hashbrown that referenced this pull request Mar 30, 2019

Merge #46
46: Prepare hashbrown for inclusion in the standard library r=Amanieu a=Amanieu See rust-lang/rust#58623. Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>

Loading status checks…

c3571f8

bors bot added a commit to Amanieu/hashbrown that referenced this pull request Mar 30, 2019

Merge #46
46: Prepare hashbrown for inclusion in the standard library r=Amanieu a=Amanieu See rust-lang/rust#58623. Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>

Loading status checks…

83ce3d5

Amanieu force-pushed the Amanieu:hashbrown3 branch from 1d30c64 to f69c116 Apr 2, 2019

rust-lang/rust

Join GitHub today

Replace HashMap implementation with SwissTable (as an external crate) #58623

Conversation

Amanieu commented Feb 21, 2019

rust-highfive assigned nikomatsakis Feb 21, 2019

This comment has been minimized.

rust-highfive commented Feb 21, 2019

rust-highfive added the S-waiting-on-review label Feb 21, 2019

This comment was marked as outdated.

rust-highfive commented Feb 21, 2019

This comment has been minimized.

Amanieu commented Feb 21, 2019

rust-highfive assigned alexcrichton and unassigned nikomatsakis Feb 21, 2019

Amanieu referenced this pull request Feb 21, 2019

Replace HashMap implementation with SwissTable #56241

This comment was marked as outdated.

rust-highfive commented Feb 21, 2019

This comment has been minimized.

gnzlbg commented Feb 21, 2019 • edited by Amanieu

Amanieu force-pushed the Amanieu:hashbrown3 branch from 23d4b1f to 98ef879 Feb 22, 2019

This comment was marked as outdated.

rust-highfive commented Feb 22, 2019

This comment was marked as outdated.

rust-highfive commented Feb 22, 2019

Amanieu force-pushed the Amanieu:hashbrown3 branch from b42286f to e08307b Feb 22, 2019

This comment was marked as outdated.

rust-highfive commented Feb 22, 2019

Amanieu force-pushed the Amanieu:hashbrown3 branch from e08307b to 4ba6550 Feb 22, 2019

This comment was marked as outdated.

rust-highfive commented Feb 22, 2019

This comment has been minimized.

stjepang commented Feb 23, 2019

This comment has been minimized.

Amanieu commented Feb 24, 2019

This comment was marked as resolved.

bors commented Feb 25, 2019

This comment has been minimized.

alexcrichton commented Feb 25, 2019

This comment was marked as resolved.

bors commented Feb 25, 2019

Amanieu force-pushed the Amanieu:hashbrown3 branch from 2b917d0 to 76003ba Feb 25, 2019

Amanieu referenced this pull request Feb 25, 2019

Prepare hashbrown for inclusion in the standard library #46

This comment has been minimized.

Amanieu commented Feb 25, 2019

This comment has been minimized.

alexcrichton commented Feb 25, 2019

This comment has been minimized.

bors commented Feb 25, 2019

bors added a commit that referenced this pull request Feb 25, 2019

This comment has been minimized.

bors commented Feb 26, 2019

This comment has been minimized.

alexcrichton commented Feb 26, 2019

This comment has been minimized.

Amanieu commented Mar 7, 2019

This comment has been minimized.

Amanieu commented Mar 7, 2019

This comment has been minimized.

alexcrichton commented Mar 7, 2019

This comment has been minimized.

Gankro commented Mar 7, 2019 • edited

This comment has been minimized.

gnzlbg commented Mar 7, 2019

This comment has been minimized.

RalfJung commented Mar 8, 2019

This comment has been minimized.

matthewjasper commented Mar 8, 2019

hash_map

hash_set

This comment was marked as resolved.

bors commented Mar 9, 2019

This comment has been minimized.

Amanieu commented Mar 9, 2019

Amanieu force-pushed the Amanieu:hashbrown3 branch from 0aac051 to a238a95 Mar 9, 2019

Zoxc referenced this pull request Mar 9, 2019

HirIdification: rework Map #59042

jugglerchris referenced this pull request Mar 11, 2019

next() function #15

gnzlbg commented Feb 21, 2019 •

edited by Amanieu

Amanieu force-pushed the Amanieu:hashbrown3 branch from `23d4b1f` to `98ef879` Feb 22, 2019

Amanieu force-pushed the Amanieu:hashbrown3 branch from `b42286f` to `e08307b` Feb 22, 2019

Amanieu force-pushed the Amanieu:hashbrown3 branch from `e08307b` to `4ba6550` Feb 22, 2019

Amanieu force-pushed the Amanieu:hashbrown3 branch from `2b917d0` to `76003ba` Feb 25, 2019

Gankro commented Mar 7, 2019 •

edited

`hash_map`

`hash_set`

Amanieu force-pushed the Amanieu:hashbrown3 branch from `0aac051` to `a238a95` Mar 9, 2019

Amanieu force-pushed the Amanieu:hashbrown3 branch from `a238a95` to `1d30c64` Mar 30, 2019

Amanieu force-pushed the Amanieu:hashbrown3 branch from `1d30c64` to `f69c116` Apr 2, 2019