Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Simplify serialize::{En,De}coder, add support for serializing maps, and other misc fns #5630

Closed
wants to merge 22 commits into from

4 participants

Erick Tryzelaar Niko Matsakis bors Patrick Walton
Erick Tryzelaar
Collaborator

@nikomatsakis and I were talking about how the serializers were a bit too complicated. None of the users of With the emit_option and read_option functions, the serializers are now moving more high level. This patch series continues that trend. I've removed support for emitting specific string and vec types, and added support for emitting mapping types.

Niko Matsakis

I'd give this r+, but it's already bit-rotted...

Erick Tryzelaar
Collaborator

@nikomatsakis: It's back to mergable. I also fleshed out serialization support for the other container types.

Patrick Walton
Owner

r+

carrying forward from @nikomatsakis

Collaborator

saw approval from pcwalton
at erickt@909d8f0

Collaborator

merging erickt/rust/serial = 909d8f0 into auto

Collaborator

erickt/rust/serial = 909d8f0 merged ok, testing candidate = 44de87cf

bors bors referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Erick Tryzelaar
Collaborator

@bors: retry

Erick Tryzelaar
Collaborator

r+

Collaborator

saw approval from erickt
at erickt@810c4d8

Collaborator

merging erickt/rust/serial = 810c4d8 into auto

Collaborator

erickt/rust/serial = 810c4d8 merged ok, testing candidate = 6dd20c8

Collaborator

fast-forwarding incoming to auto = 6dd20c8

bors bors referenced this pull request from a commit
bors bors auto merge of #5630 : erickt/rust/serial, r=erickt
@nikomatsakis and I were talking about how the serializers were a bit too complicated. None of the users of With the `emit_option` and `read_option` functions, the serializers are now moving more high level. This patch series continues that trend. I've removed support for emitting specific string and vec types, and added support for emitting mapping types.
6dd20c8
bors bors closed this
Jay Anderson jayanderson referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 29, 2013
  1. Erick Tryzelaar

    core: Inline mallocing wrapper functions

    erickt authored
    As far as I can tell, this doesn't make rust compile any
    faster, but it does at least remove one level of indirection
    on malloc, which might help speed up some operations.
  2. Erick Tryzelaar

    std: change Decoder::read_option to return a generic type

    erickt authored
    This allows read_option to be used with a custom option type instead
    of just core::Option.
  3. Erick Tryzelaar

    std: remove prettyprint

    erickt authored
    Everyone uses fmt!("%?", ...) instead of the prettyprint
    module, so I'm removing this file.
  4. Erick Tryzelaar
  5. Erick Tryzelaar
  6. Erick Tryzelaar
  7. Erick Tryzelaar
  8. Erick Tryzelaar
  9. Erick Tryzelaar
  10. Erick Tryzelaar

    core: add consume_reverse

    erickt authored
  11. Erick Tryzelaar
  12. Erick Tryzelaar
  13. Erick Tryzelaar
  14. Erick Tryzelaar
Commits on Mar 30, 2013
  1. Erick Tryzelaar
  2. Erick Tryzelaar
  3. Erick Tryzelaar
  4. Erick Tryzelaar
  5. Erick Tryzelaar
  6. Erick Tryzelaar

    syntax: fix auto_encode test.

    erickt authored
  7. Erick Tryzelaar
  8. Erick Tryzelaar

    rustc: fix astencode test

    erickt authored
Something went wrong with that request. Please try again.