Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Stabilise disable minification #56359
Rustdoc also minifies any user-supplied themes as well as the search index. It also adds an extra line to
This is a debugging flag that @GuillaumeGomez uses personally, and the original PR for this was among a handful of no-comment stabilization PRs that he started at the same time, alongside threads for
It looks like you've added docs since the original PR, but i'm not aware of any tests in this repo for the minifier functionality. (How much is the
Regardless, we should hold an FCP before merging this, since it's a feature stabilization.
Testing is complicated directly on rustdoc since everytime there is an update, we'll have to update the minification tests as well. I added tests (maybe not enough?) in the minifier crate directly. I'll let you judge if there are enough, and if not, I'll add even more! :D