New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arena: speed up TypedArena::clear and improve common patterns #56378

Merged
merged 2 commits into from Dec 2, 2018

Conversation

Projects
None yet
6 participants
@ljedrz
Contributor

ljedrz commented Nov 30, 2018

  • speed up TypedArena::clear: improves its performance by up to 33% (in case of a single entry)
  • simplify DroplessArena::in_arena
@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Nov 30, 2018

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

Show resolved Hide resolved src/libarena/lib.rs Outdated

@ljedrz ljedrz force-pushed the ljedrz:arena_tweaks branch from e7cee29 to 95f32f1 Dec 2, 2018

@ljedrz

This comment has been minimized.

Contributor

ljedrz commented Dec 2, 2018

Comments addressed.

@nagisa

This comment has been minimized.

Contributor

nagisa commented Dec 2, 2018

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Dec 2, 2018

📌 Commit 95f32f1 has been approved by nagisa

@bors

This comment has been minimized.

Contributor

bors commented Dec 2, 2018

⌛️ Testing commit 95f32f1 with merge 9abc231...

bors added a commit that referenced this pull request Dec 2, 2018

Auto merge of #56378 - ljedrz:arena_tweaks, r=nagisa
arena: speed up TypedArena::clear and improve common patterns

- speed up `TypedArena::clear`: improves its performance by up to **33%** (in case of a single entry)
- simplify `DroplessArena::in_arena`
@bors

This comment has been minimized.

Contributor

bors commented Dec 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nagisa
Pushing 9abc231 to master...

@bors bors merged commit 95f32f1 into rust-lang:master Dec 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@ljedrz ljedrz deleted the ljedrz:arena_tweaks branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment