New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix span for invalid number of parameters in trait method #56641

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
4 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Dec 8, 2018

Fixes #56582.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 8, 2018

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

...
LL | / &mut self, //~ ERROR
LL | | x: i32,
| |______________^ expected 3 parameters, found 2

This comment has been minimized.

@estebank

estebank Dec 10, 2018

Contributor

I think this could be tweaked to actually include either the fn signature or the entire block in order to provide enough context when generating this error in the terminal, but that would be a good follow up tweak.

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Dec 10, 2018

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 10, 2018

📌 Commit 05cea31 has been approved by estebank

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 10, 2018

Rollup merge of rust-lang#56641 - GuillaumeGomez:span-trait-method-in…
…valid-nb-parameters, r=estebank

fix span for invalid number of parameters in trait method

Fixes rust-lang#56582.

bors added a commit that referenced this pull request Dec 10, 2018

Auto merge of #56688 - GuillaumeGomez:rollup, r=GuillaumeGomez
Rollup of 5 pull requests

Successful merges:

 - #56491 (emit error with span for empty asserts)
 - #56633 (Fix right arrow size for crate filter)
 - #56641 (fix span for invalid number of parameters in trait method)
 - #56656 (Fix typo)
 - #56661 (Add regression test for ICE)

Failed merges:

r? @ghost

@bors bors merged commit 05cea31 into rust-lang:master Dec 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:span-trait-method-invalid-nb-parameters branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment