Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix js errors #56876

Merged
merged 2 commits into from Dec 16, 2018
Merged

Fix js errors #56876

merged 2 commits into from Dec 16, 2018

Conversation

GuillaumeGomez
Copy link
Member

Fix JS error (you can see it on the iterator doc page) and the invalid theme switch.

r? @QuietMisdreavus

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 16, 2018
Copy link
Member

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes the issues in personal testing. (The Iterator page is still really laggy though >_>)

@QuietMisdreavus
Copy link
Member

@bors r+ p=1 (major rendering error on nightly)

@bors
Copy link
Contributor

bors commented Dec 16, 2018

📌 Commit fa9c823 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2018
@bors
Copy link
Contributor

bors commented Dec 16, 2018

⌛ Testing commit fa9c823 with merge 19dc2ca...

bors added a commit that referenced this pull request Dec 16, 2018
Fix js errors

Fix JS error (you can see it on the iterator doc page) and the invalid theme switch.

r? @QuietMisdreavus
@bors
Copy link
Contributor

bors commented Dec 16, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing 19dc2ca to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants