New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cycle::try_fold override #56904

Merged
merged 1 commit into from Dec 17, 2018

Conversation

Projects
None yet
6 participants
@sinkuu
Copy link
Contributor

sinkuu commented Dec 17, 2018

Fixes #56883

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 17, 2018

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

Remove `<Cycle as Iterator>::try_fold` override
It was a incorrect optimization.

@sinkuu sinkuu force-pushed the sinkuu:cycle_fold branch from 7ceba9a to f0483f7 Dec 17, 2018

@sinkuu sinkuu changed the title Fix Cycle::try_fold Remove Cycle::try_fold override Dec 17, 2018

@sinkuu

This comment has been minimized.

Copy link
Contributor

sinkuu commented Dec 17, 2018

After fixing the bug, it no longer improves benchmark. So, now this PR just removes the override.

@bluss

This comment has been minimized.

Copy link
Contributor

bluss commented Dec 17, 2018

@bors r+ rollup

Makes sense. Thanks!

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 17, 2018

📌 Commit f0483f7 has been approved by bluss

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Dec 17, 2018

IMHO this should be p=1 and landed ASAP, @bluss, not as part of rollup, as it fixes invalid behaviour in valid code (i.e. problem as bad as soundness issues).

@bluss

This comment has been minimized.

Copy link
Contributor

bluss commented Dec 17, 2018

@bors p=1 rollup-

Yes. Let's see if bors can do that. There are several bugfixes queued, but looks like we're not overtaking something more critical.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 17, 2018

⌛️ Testing commit f0483f7 with merge adbfec2...

bors added a commit that referenced this pull request Dec 17, 2018

Auto merge of #56904 - sinkuu:cycle_fold, r=bluss
Remove Cycle::try_fold override

Fixes #56883
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 17, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: bluss
Pushing adbfec2 to master...

@bors bors merged commit f0483f7 into rust-lang:master Dec 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment