New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the private generic NonZero<T> wrapper type #57133

Merged
merged 1 commit into from Dec 27, 2018

Conversation

Projects
None yet
6 participants
@SimonSapin
Copy link
Contributor

SimonSapin commented Dec 26, 2018

Instead, use #[rustc_layout_scalar_valid_range_start(1)] directly on relevant libcore types.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 26, 2018

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@SimonSapin

This comment has been minimized.

Copy link
Contributor

SimonSapin commented Dec 26, 2018

r? @oli-obk, who replaced the non_zero lang item by this attribute in #54032.

@rust-highfive rust-highfive assigned oli-obk and unassigned Kimundi Dec 26, 2018

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Dec 26, 2018

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 26, 2018

☔️ The latest upstream changes (presumably #57108) made this pull request unmergeable. Please resolve the merge conflicts.

Remove the private generic NonZero<T> wrapper type.
Instead, use `#[rustc_layout_scalar_valid_range_start(1)]` directly
on relevant libcore types.

@SimonSapin SimonSapin force-pushed the SimonSapin:zero branch from c39a719 to 7a09115 Dec 26, 2018

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Dec 27, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 27, 2018

📌 Commit 7a09115 has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 27, 2018

⌛️ Testing commit 7a09115 with merge d174173...

bors added a commit that referenced this pull request Dec 27, 2018

Auto merge of #57133 - SimonSapin:zero, r=oli-obk
Remove the private generic NonZero<T> wrapper type

Instead, use `#[rustc_layout_scalar_valid_range_start(1)]` directly on relevant libcore types.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing d174173 to master...

@bors bors merged commit 7a09115 into rust-lang:master Dec 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment