New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unpin to std prelude, not just core #57137

Merged
merged 1 commit into from Dec 28, 2018

Conversation

Projects
None yet
7 participants
@cramertj
Copy link
Member

cramertj commented Dec 26, 2018

@cramertj

This comment has been minimized.

Copy link
Member

cramertj commented Dec 27, 2018

(note to reviewers: this is just a bugfix to the API that was exposed previously)

@SimonSapin

This comment has been minimized.

Copy link
Contributor

SimonSapin commented Dec 27, 2018

I’ll assume that the since value of #[stable] attributes doesn’t matter on re-exports.

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 27, 2018

📌 Commit 11f4d3e has been approved by SimonSapin

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 28, 2018

⌛️ Testing commit 11f4d3e with merge b26e296...

bors added a commit that referenced this pull request Dec 28, 2018

Auto merge of #57137 - cramertj:unpin-prelude, r=SimonSapin
Add Unpin to std prelude, not just core

r? @alexcrichton
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 28, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 28, 2018

The job dist-i586-gnu-i586-i686-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:19:42] test atomic::uint_xor ... ok
[01:19:42] test cell::cell_default ... ok
[01:19:42] test cell::as_ptr ... ok
[01:19:42] test atomic::uint_or ... ok
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Dec 28, 2018

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 28, 2018

⌛️ Testing commit 11f4d3e with merge 5e3fa89...

bors added a commit that referenced this pull request Dec 28, 2018

Auto merge of #57137 - cramertj:unpin-prelude, r=SimonSapin
Add Unpin to std prelude, not just core

r? @alexcrichton
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 28, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 28, 2018

The job dist-i686-freebsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Building stage2 tool cargo (i686-unknown-freebsd)
[01:15:27]  Downloading crates ...
[01:15:47] warning: spurious network error (2 tries remaining): [6] Couldn't resolve host name (Could not resolve host: crates.io)
[01:16:08] warning: spurious network error (1 tries remaining): [6] Couldn't resolve host name (Could not resolve host: crates.io)
[01:16:28] error: failed to download from `https://crates.io/api/v1/crates/openssl-src/111.1.0+1.1.1a/download`
[01:16:28] Caused by:
[01:16:28]   [6] Couldn't resolve host name (Could not resolve host: crates.io)
[01:16:28] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "i686-unknown-freebsd" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/cargo/Cargo.toml" "--features" "rustc-workspace-hack/all-static" "--message-format" "json"
[01:16:28] expected success, got: exit code: 101
---
travis_time:end:003c5a36:start=1545979869302975644,finish=1545979869315334977,duration=12359333
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:025b2d24
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0a11c024
travis_time:start:0a11c024
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:07d360d4
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Dec 28, 2018

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 28, 2018

⌛️ Testing commit 11f4d3e with merge 48742c6...

bors added a commit that referenced this pull request Dec 28, 2018

Auto merge of #57137 - cramertj:unpin-prelude, r=SimonSapin
Add Unpin to std prelude, not just core

r? @alexcrichton
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: SimonSapin
Pushing 48742c6 to master...

@bors bors merged commit 11f4d3e into rust-lang:master Dec 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@cramertj cramertj deleted the cramertj:unpin-prelude branch Dec 28, 2018

@taiki-e taiki-e referenced this pull request Jan 15, 2019

Merged

Remove import of Unpin #1416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment