New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to format string diagnostics #57140

Merged
merged 2 commits into from Dec 29, 2018

Conversation

Projects
None yet
6 participants
@estebank
Copy link
Contributor

estebank commented Dec 27, 2018

Add label spans and fix incorrect spans.

Fix #55155, fix #55350.

estebank added some commits Dec 27, 2018

Point at correct span for arguments in format strings
When a format string has escaped whitespace characters format
arguments were shifted by one per each escaped character. Account
for these escaped characters when synthesizing the spans.

Fix #55155.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 27, 2018

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@varkor

This comment has been minimized.

Copy link
Member

varkor commented Dec 27, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 27, 2018

📌 Commit 5e952e3 has been approved by varkor

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Dec 28, 2018

@bors rollup

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Dec 29, 2018

@bors rollup-

Please don't rollup PRs that change diagnostics, because it may affect UI tests of unrelated PRs in the same rollup.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 29, 2018

⌛️ Testing commit 5e952e3 with merge 35a64f8...

bors added a commit that referenced this pull request Dec 29, 2018

Auto merge of #57140 - estebank:str-err, r=varkor
Tweaks to format string diagnostics

Add label spans and fix incorrect spans.

Fix #55155, fix #55350.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 29, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: varkor
Pushing 35a64f8 to master...

@bors bors merged commit 5e952e3 into rust-lang:master Dec 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 29, 2018

📣 Toolstate changed by #57140!

Tested on commit 35a64f8.
Direct link to PR: #57140

💔 rls on windows: test-pass → test-fail (cc @nrc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Dec 29, 2018

📣 Toolstate changed by rust-lang/rust#57140!
Tested on commit rust-lang/rust@35a64f8.
Direct link to PR: <rust-lang/rust#57140>

💔 rls on windows: test-pass → test-fail (cc @nrc @Xanewok, @rust-lang/infra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment