Skip to content

Do not complain about missing crate named as a keyword #57208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 31, 2018
Merged

Do not complain about missing crate named as a keyword #57208

merged 2 commits into from
Dec 31, 2018

Conversation

estebank
Copy link
Contributor

Fix #57198.

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 30, 2018
petrochenkov
petrochenkov reviewed Dec 30, 2018
View reviewed changes
petrochenkov
petrochenkov reviewed Dec 30, 2018
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2018
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 30, 2018
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 30, 2018

📌 Commit cef919e has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2018
@bors
Copy link
Collaborator

bors commented Dec 31, 2018

⌛ Testing commit cef919e with merge aeed63b...

bors added a commit that referenced this pull request Dec 31, 2018
@bors
Auto merge of #57208 - estebank:issue-57198, r=petrochenkov
aeed63b 
Do not complain about missing crate named as a keyword

Fix #57198.
@bors
Copy link
Collaborator

bors commented Dec 31, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing aeed63b to master...

@bors bors merged commit cef919e into rust-lang:master Dec 31, 2018
@estebank estebank deleted the issue-57198 branch November 9, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estebank @rust-highfive @petrochenkov @bors @michaelwoerister