New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Uniform path backports #57483

Merged
merged 9 commits into from Jan 11, 2019

Conversation

Projects
None yet
8 participants
@petrochenkov
Copy link
Contributor

petrochenkov commented Jan 10, 2019

What's included:

  • c658d73 ("resolve: Avoid "self-confirming" resolutions in import validation", prerequisite for the following items)
  • #57160 ("resolve: Fix an ICE in import validation")
  • #56759 ("Stabilize uniform_paths")

r? @Mark-Simulacrum

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 10, 2019

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Jan 10, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 10, 2019

⌛️ Trying commit bc232d3 with merge 0d8b5d1...

bors added a commit that referenced this pull request Jan 10, 2019

Auto merge of #57483 - petrochenkov:beta, r=<try>
[beta] Uniform path backports

What's included:
- c658d73 ("resolve: Avoid "self-confirming" resolutions in import validation", prerequisite for the following items)
- #57160 ("resolve: Fix an ICE in import validation")
- #56759 ("Stabilize `uniform_paths`")

r? @Mark-Simulacrum
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jan 10, 2019

cc @Aaronepower (for #57471) -- I think it's likely this will land and if necessary I can take on backing it out of stable last minute

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Jan 10, 2019

@ 💂 craterbot run start=master#2bde39b8edce6463e1c37f8a8082a875e7b536b1 end=try#0d8b5d1f16bab9e975695518ff8705bdab9fe94c mode=check-only

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 10, 2019

☀️ Test successful - checks-travis
State: approved= try=True

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jan 10, 2019

@craterbot run start=master#2bde39b8edce6463e1c37f8a8082a875e7b536b1 end=try#0d8b5d1f16bab9e975695518ff8705bdab9fe94c mode=check-only

@craterbot

This comment has been minimized.

Copy link
Collaborator

craterbot commented Jan 10, 2019

👌 Experiment pr-57483 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Copy link
Collaborator

craterbot commented Jan 10, 2019

🚧 Experiment pr-57483 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Jan 10, 2019

Discussed in the @rust-lang/compiler meeting. We decided we're definitely ok with backporting the first two PRs. As for the third PR, we don't typically backport stabilizations, but in this case this would help close a source of active problems around migration (see this list of related bugs). Therefore, 👍 to backport if the crater run results look good.

@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Jan 11, 2019

I included c658d73 and #57160 in the rollup (#57516), so we'll only need to backport the stabilization if crater is ok.

@craterbot

This comment has been minimized.

Copy link
Collaborator

craterbot commented Jan 11, 2019

🎉 Experiment pr-57483 is completed!
📊 0 regressed and 1 fixed (50551 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Jan 11, 2019

Crater results looks good!

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 11, 2019

📌 Commit bc232d3 has been approved by pietroalbini

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jan 11, 2019

@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Jan 11, 2019

Rolled up inside #57516.

bors added a commit that referenced this pull request Jan 11, 2019

Auto merge of #57516 - pietroalbini:beta-rollup, r=pietroalbini
[beta] Rollup backports

Cherry-picked:

* #57355: use the correct supertrait substitution in `object_ty_for_trait`
* #57471: Updated RELEASES.md for 1.32.0

Rolled up:

* #57483: [beta] Uniform path backports
  * c658d73: resolve: Avoid "self-confirming" resolutions in import validation
  * #57160: resolve: Fix an ICE in import validation
  * #56759: Stabilize `uniform_paths`

r? @ghost

@bors bors merged commit bc232d3 into rust-lang:beta Jan 11, 2019

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment