New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint for copyright headers to 'tidy' tool #57520

Merged
merged 4 commits into from Jan 17, 2019

Conversation

Projects
None yet
6 participants
@alexreg
Copy link
Contributor

alexreg commented Jan 11, 2019

r? @Mark-Simulacrum

CC @Centril

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 11, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1e9c9657:start=1547227639049377999,finish=1547227640088590484,duration=1039212485
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:03:58] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:58] tidy error: /checkout/src/libcore/slice/memchr.rs:3: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/convert_quotes.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/remove_links.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/link2print.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/concat_chapters.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/remove_markup.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/lfp.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/ci/stable-check/src/main.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/2018-edition/tools/src/bin/convert_quotes.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/2018-edition/tools/src/bin/remove_links.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/2018-edition/tools/src/bin/link2print.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/2018-edition/tools/src/bin/concat_chapters.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/2018-edition/tools/src/bin/remove_markup.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/2018-edition/tools/src/bin/lfp.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/tools/src/bin/convert_quotes.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/tools/src/bin/remove_links.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/tools/src/bin/link2print.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/tools/src/bin/concat_chapters.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/tools/src/bin/remove_markup.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/book/tools/src/bin/lfp.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/doc/reference/stable-check/src/main.rs:1: copyright notices are deprecated
[00:03:58] tidy error: /checkout/src/libserialize/json.rs:2: copyright notices are deprecated
[00:03:59] tidy error: /checkout/src/libstd/memchr.rs:3: copyright notices are deprecated
[00:03:59] tidy error: /checkout/src/libstd/sys/cloudabi/abi/cloudabi.rs:1: copyright notices are deprecated
[00:03:59] tidy error: /checkout/src/libstd/sys/cloudabi/abi/bitflags.rs:1: copyright notices are deprecated
[00:03:59] tidy error: /checkout/src/libstd/sys/redox/memchr.rs:3: copyright notices are deprecated
[00:03:59] tidy error: /checkout/src/libstd/sys/windows/memchr.rs:3: copyright notices are deprecated
[00:03:59] tidy error: /checkout/src/libstd/sys/unix/memchr.rs:3: copyright notices are deprecated
[00:03:59] tidy error: /checkout/src/test/ui/feature-gates/feature-gate-type_alias_enum_variants.rs:1: copyright notices are deprecated
[00:03:59] tidy error: /checkout/src/test/rustdoc/no-crate-filter.rs:1: copyright notices are deprecated
[00:03:59] tidy error: /checkout/src/test/rustdoc/auxiliary/enum_primitive.rs:1: copyright notices are deprecated
[00:03:59] tidy error: /checkout/src/test/compile-fail-fulldeps/auxiliary/lint_group_plugin_test.rs:1: copyright notices are deprecated
[00:03:59] tidy error: /checkout/src/test/rustdoc-ui/deny-missing-docs-crate.rs:1: copyright notices are deprecated
[00:03:59] tidy error: /checkout/src/test/rustdoc-ui/deny-missing-docs-macro.rs:1: copyright notices are deprecated
[00:04:00] some tidy checks failed
[00:04:00] 
[00:04:00] 
[00:04:00] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:00] 
[00:04:00] 
[00:04:00] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:00] Build completed unsuccessfully in 0:00:46
[00:04:00] Build completed unsuccessfully in 0:00:46
[00:04:00] make: *** [tidy] Error 1
[00:04:00] Makefile:69: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0004c54a
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Jan 11 17:31:31 UTC 2019
---
travis_time:end:0236dec0:start=1547227892566365623,finish=1547227892570702030,duration=4336407
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:12d8cc94
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:09c56fe0
travis_time:start:09c56fe0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0d8bc99e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 11, 2019

Looks to be working. I’ll fix those files shortly.

@alexreg alexreg force-pushed the alexreg:tidy-copyright-lint branch from dd58319 to cade87c Jan 11, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 11, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0971eb08:start=1547235021307466662,finish=1547235022270282226,duration=962815564
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
#####################################################                     74.5%
######################################################################## 100.0%
[00:01:48] extracting /checkout/obj/build/cache/2019-01-04/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:48]     Updating crates.io index
[00:01:58] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:01:58] Build completed unsuccessfully in 0:00:29
[00:01:58] make: *** [prepare] Error 1
[00:01:58] Makefile:71: recipe for target 'prepare' failed
[00:01:59] Command failed. Attempt 2/5:
[00:01:59] Command failed. Attempt 2/5:
[00:02:00] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:00] Build completed unsuccessfully in 0:00:00
[00:02:00] make: *** [prepare] Error 1
[00:02:00] Makefile:71: recipe for target 'prepare' failed
[00:02:02] Command failed. Attempt 3/5:
[00:02:02] Command failed. Attempt 3/5:
[00:02:02] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:02] Build completed unsuccessfully in 0:00:00
[00:02:02] Makefile:71: recipe for target 'prepare' failed
[00:02:02] make: *** [prepare] Error 1
[00:02:05] Command failed. Attempt 4/5:
[00:02:05] Command failed. Attempt 4/5:
[00:02:05] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:05] Build completed unsuccessfully in 0:00:00
[00:02:05] Makefile:71: recipe for target 'prepare' failed
[00:02:05] make: *** [prepare] Error 1
[00:02:09] Command failed. Attempt 5/5:
[00:02:09] Command failed. Attempt 5/5:
[00:02:10] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:10] Build completed unsuccessfully in 0:00:00
[00:02:10] Makefile:71: recipe for target 'prepare' failed
[00:02:10] The command has failed after 5 attempts.
[00:02:10] make: *** [prepare] Error 1
---
travis_time:end:0d462fec:start=1547235165061478606,finish=1547235165067477498,duration=5998892
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1844a2e0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2609a383
travis_time:start:2609a383
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1b2f37ea
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jan 11, 2019

Looks like Travis failed but this looks good to me in general - it might be worth including a check for "Rust" in the copyright line?

@alexreg alexreg force-pushed the alexreg:tidy-copyright-lint branch from cade87c to 869ea16 Jan 11, 2019

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 11, 2019

Looks like Travis failed but this looks good to me in general - it might be worth including a check for "Rust" in the copyright line?

Yep, I actually went further than this and made a regex for the copyright line, but let me know if that's overkill...

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 11, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:2fc0438d:start=1547240863930085381,finish=1547240866986974954,duration=3056889573
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:02:55]    Compiling syn v0.15.22
[00:02:57]    Compiling serde_json v1.0.33
[00:03:16]    Compiling serde_derive v1.0.81
[00:03:33]    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
[00:03:33] error: expected one of `:`, `;`, `=`, or `@`, found `==`
[00:03:33]   --> src/tools/tidy/src/style.rs:96:22
[00:03:33]    |
[00:03:33] 96 |     let copyright_re == Regex::new(r"^(// )? Copyright .+ The Rust Developers").unwrap();
[00:03:33]    |                      ^^ expected one of `:`, `;`, `=`, or `@` here
[00:03:33] error: unused import: `std::fs::File`
[00:03:33]   --> src/tools/tidy/src/style.rs:15:5
[00:03:33]    |
[00:03:33] 15 | use std::fs::File;
---
[00:03:33]    |         ^^^^^^^^^^^^
[00:03:33] 
[00:03:33] error: aborting due to 4 previous errors
[00:03:33] 
[00:03:33] error: Could not compile `tidy`.
[00:03:33] To learn more, run the command again with --verbose.
[00:03:33] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/tidy/Cargo.toml" "--message-format" "json"
[00:03:33] expected success, got: exit code: 101
[00:03:33] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:33] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:33] Build completed unsuccessfully in 0:00:55
[00:03:33] make: *** [tidy] Error 1
[00:03:33] Makefile:69: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:08971234
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Jan 11 21:11:30 UTC 2019
---
travis_time:end:0204fab0:start=1547241091613143848,finish=1547241091617665556,duration=4521708
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:06a8a4f4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:09c39d5b
travis_time:start:09c39d5b
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1353f6d2
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the alexreg:tidy-copyright-lint branch from 869ea16 to 8faeb69 Jan 11, 2019

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jan 12, 2019

I think the regex is a bit overkill - especially because as far as I can tell it can be replaced with ~3 contains nearly equivalently. But if that's not actually the case, then let's put it in a lazy_static and call it good.

@alexreg alexreg force-pushed the alexreg:tidy-copyright-lint branch from 8faeb69 to 1080464 Jan 12, 2019

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 12, 2019

Yeah, I thought originally I would need a more complicated regex to distinguish between Rust Developers and other sorts of copyright notices, but probably not. Let's see if this works...

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 12, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:2f4870f8:start=1547259088866311308,finish=1547259091098189787,duration=2231878479
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:03:44] 
[00:03:44] error: aborting due to previous error
[00:03:44] 
[00:03:44] For more information about this error, try `rustc --explain E0463`.
[00:03:45] error: Could not compile `tidy`.
[00:03:45] To learn more, run the command again with --verbose.
[00:03:45] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/tidy/Cargo.toml" "--message-format" "json"
[00:03:45] expected success, got: exit code: 101
[00:03:45] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:45] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:45] Build completed unsuccessfully in 0:00:39
[00:03:45] make: *** [tidy] Error 1
[00:03:45] Makefile:69: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:18936552
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sat Jan 12 02:15:26 UTC 2019
---
travis_time:end:011e61d0:start=1547259327492358199,finish=1547259327497102939,duration=4744740
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:080a56b4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:181cb7bc
travis_time:start:181cb7bc
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:11ba6860
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the alexreg:tidy-copyright-lint branch from 1080464 to 0ec1266 Jan 12, 2019

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 12, 2019

@Mark-Simulacrum Looking good now. (Tidy checks would have failed this far into the tests.) r+ if you're happy with things?

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jan 12, 2019

r=me with notes fixed.

Thanks for taking this on!

Let's also @bors p=1 to hopefully help avoid some rebase pain.

@alexreg alexreg force-pushed the alexreg:tidy-copyright-lint branch from 0ec1266 to cbd0d86 Jan 12, 2019

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 12, 2019

@rust-lang rust-lang deleted a comment from bors Jan 12, 2019

@rust-lang rust-lang deleted a comment from bors Jan 12, 2019

@rust-lang rust-lang deleted a comment from bors Jan 12, 2019

@rust-lang rust-lang deleted a comment from bors Jan 12, 2019

@rust-lang rust-lang deleted a comment from bors Jan 12, 2019

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 12, 2019

@alexreg: 🔑 Insufficient privileges: Not in reviewers

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 12, 2019

@Mark-Simulacrum Did your above r=me have any meaning to Bors or just a reminder?

Also, @nikomatsakis, was I added to the reviewers list yet? I tried to do @bors r=@Mark-Simulacrum p=1...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 12, 2019

@alexreg: 🔑 Insufficient privileges: not in try users

@bors

This comment was marked as outdated.

Copy link
Contributor

bors commented Jan 12, 2019

@alexreg: 🔑 Insufficient privileges: Not in reviewers

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 12, 2019

(Ugh, @bors should really ignore commands within backticks.)

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 13, 2019

@Mark-Simulacrum Fair enough. Do you have merge rights on the Book? It turns out there are some copyright notices in the code there blocking it. rust-lang/book#1765 fixes it, so maybe you could approve that if possible (once CI passes)...

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jan 13, 2019

Merged book PR.

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 13, 2019

@Mark-Simulacrum Okay, everything should be good now. Just r+ when Travis goes green please. :-)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 13, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:017e366e:start=1547353405901665940,finish=1547353477393620426,duration=71491954486
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:03:19] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:19] tidy error: /checkout/src/doc/book/second-edition/convert-quotes.sh:2: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/second-edition/nostarch.sh:2: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/convert_quotes.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/remove_links.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/link2print.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/concat_chapters.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/remove_markup.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/lfp.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/second-edition/doc-to-md.sh:2: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/convert-quotes.sh:2: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/nostarch.sh:2: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/ci/build.sh:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/ci/stable-check/src/main.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/ci/spellcheck.sh:2: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/2018-edition/convert-quotes.sh:2: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/2018-edition/nostarch.sh:2: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/2018-edition/tools/src/bin/convert_quotes.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/2018-edition/tools/src/bin/remove_links.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/2018-edition/tools/src/bin/link2print.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/2018-edition/tools/src/bin/concat_chapters.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/2018-edition/tools/src/bin/remove_markup.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/2018-edition/tools/src/bin/lfp.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/tools/src/bin/convert_quotes.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/tools/src/bin/remove_links.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/tools/src/bin/link2print.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/tools/src/bin/concat_chapters.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/tools/src/bin/remove_markup.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/book/tools/src/bin/lfp.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:19] tidy error: /checkout/src/doc/reference/stable-check/src/main.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:21] some tidy checks failed
[00:03:21] 
[00:03:21] 
[00:03:21] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:21] 
[00:03:21] 
[00:03:21] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:21] Build completed unsuccessfully in 0:00:46
[00:03:21] Build completed unsuccessfully in 0:00:46
[00:03:21] Makefile:69: recipe for target 'tidy' failed
[00:03:21] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1091902b
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Jan 13 04:28:08 UTC 2019
---
travis_time:end:2dccadb2:start=1547353688849966677,finish=1547353688854685795,duration=4719118
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:16883bd4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:01aafe07
travis_time:start:01aafe07
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:089852d9
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 13, 2019

☔️ The latest upstream changes (presumably #57568) made this pull request unmergeable. Please resolve the merge conflicts.

@alexreg alexreg force-pushed the alexreg:tidy-copyright-lint branch from 114ba30 to 5a9693b Jan 13, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 13, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:019b5235:start=1547394276768158902,finish=1547394278952829708,duration=2184670806
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:09:02] 
[01:09:02] running 118 tests
[01:09:26] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii..........i...ii...i.......ii.i.i.i 100/118
[01:09:30] ......iii.i.....ii
[01:09:30] 
[01:09:30]  finished in 27.403
[01:09:30] travis_fold:end:test_debuginfo

---
[01:34:43] travis_fold:end:stage0-linkchecker

[01:34:43] travis_time:end:stage0-linkchecker:start=1547399970296735306,finish=1547399972161129373,duration=1864394067

[01:34:43] book/appendix-01-keywords.html:246: broken link - book/appendix-05-editions.md
[01:34:43] book/print.html:1837: broken link - book/ch09-01-unrecoverable-errors-with-panic.md
[01:34:43] book/print.html:3124: broken link fragment `#derivable-traits` pointing to `book/appendix-03-derivable-traits.html`
[01:34:43] book/print.html:10016: broken link fragment `#derivable-traits` pointing to `book/appendix-03-derivable-traits.html`
[01:34:43] book/print.html:19948: broken link - book/ch16-04-extensible-concurrency-sync-and-sen.html
[01:34:43] book/print.html:23975: broken link - book/appendix-05-editions.md
[01:34:43] book/ch19-01-unsafe-rust.html:583: broken link - book/ch16-04-extensible-concurrency-sync-and-sen.html
[01:34:43] book/ch04-01-what-is-ownership.html:500: broken link fragment `#derivable-traits` pointing to `book/appendix-03-derivable-traits.html`
[01:34:43] book/ch03-02-data-types.html:228: broken link - book/ch09-01-unrecoverable-errors-with-panic.md
[01:34:43] book/ch11-01-writing-tests.html:542: broken link fragment `#derivable-traits` pointing to `book/appendix-03-derivable-traits.html`
[01:34:50] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:39:9
[01:34:50] 
[01:34:50] 
[01:34:50] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:34:50] expected success, got: exit code: 101
[01:34:50] expected success, got: exit code: 101
[01:34:50] 
[01:34:50] 
[01:34:50] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:34:50] Build completed unsuccessfully in 0:36:48
[01:34:50] make: *** [check] Error 1
[01:34:50] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2c2a740c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Jan 13 17:19:40 UTC 2019
---
travis_time:end:125e379c:start=1547399981411342328,finish=1547399981415621156,duration=4278828
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2c043cdb
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0593195f
travis_time:start:0593195f
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:06fb607f
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 13, 2019

@Mark-Simulacrum @Centril I don't get the above errors when running locally... what's going on?

@alexreg alexreg force-pushed the alexreg:tidy-copyright-lint branch from 5a9693b to 130d7d0 Jan 13, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 13, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:217149d8:start=1547408923101408579,finish=1547408925215166922,duration=2113758343
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:09:59] 
[01:09:59] running 118 tests
[01:10:22] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii..........i...ii...i.......ii.i.i.i 100/118
[01:10:26] ......iii.i.....ii
[01:10:26] 
[01:10:26]  finished in 27.847
[01:10:26] travis_fold:end:test_debuginfo

---
[01:36:29] travis_fold:end:stage0-linkchecker

[01:36:29] travis_time:end:stage0-linkchecker:start=1547414722609670812,finish=1547414724656122279,duration=2046451467

[01:36:29] book/appendix-01-keywords.html:246: broken link - book/appendix-05-editions.md
[01:36:29] book/print.html:1837: broken link - book/ch09-01-unrecoverable-errors-with-panic.md
[01:36:29] book/print.html:3124: broken link fragment `#derivable-traits` pointing to `book/appendix-03-derivable-traits.html`
[01:36:29] book/print.html:10016: broken link fragment `#derivable-traits` pointing to `book/appendix-03-derivable-traits.html`
[01:36:29] book/print.html:19948: broken link - book/ch16-04-extensible-concurrency-sync-and-sen.html
[01:36:29] book/print.html:23975: broken link - book/appendix-05-editions.md
[01:36:29] book/ch19-01-unsafe-rust.html:583: broken link - book/ch16-04-extensible-concurrency-sync-and-sen.html
[01:36:29] book/ch04-01-what-is-ownership.html:500: broken link fragment `#derivable-traits` pointing to `book/appendix-03-derivable-traits.html`
[01:36:29] book/ch03-02-data-types.html:228: broken link - book/ch09-01-unrecoverable-errors-with-panic.md
[01:36:29] book/ch11-01-writing-tests.html:542: broken link fragment `#derivable-traits` pointing to `book/appendix-03-derivable-traits.html`
[01:36:36] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:39:9
[01:36:36] 
[01:36:36] 
[01:36:36] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:36:36] expected success, got: exit code: 101
[01:36:36] expected success, got: exit code: 101
[01:36:36] 
[01:36:36] 
[01:36:36] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:36:36] Build completed unsuccessfully in 0:37:56
[01:36:36] Makefile:48: recipe for target 'check' failed
[01:36:36] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1808635e
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Jan 13 21:25:33 UTC 2019
---
travis_time:end:012a89af:start=1547414734706512112,finish=1547414734776098306,duration=69586194
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:04558968
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1b809538
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 13, 2019

@Mark-Simulacrum @rust-lang/docs Could one of you kindly fix the links in the book, per above, so we can get this merged? Thanks.

@carols10cents

This comment has been minimized.

Copy link
Member

carols10cents commented Jan 16, 2019

@alexreg The broken links in the book should be fixed now: rust-lang/book@0e9061c

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 16, 2019

@carols10cents Thanks a lot. I'll go ahead and update the submodule in this PR then. Appreciate you working with us despite that surprising merge to your repo over the weekend!

@alexreg alexreg force-pushed the alexreg:tidy-copyright-lint branch from 130d7d0 to 4d18023 Jan 16, 2019

@alexreg

This comment has been minimized.

Copy link
Contributor

alexreg commented Jan 16, 2019

@Mark-Simulacrum @Centril Okay, this should be ready to merge now... when CI passes, at least.

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 17, 2019

@bors r=Mark-Simulacrum p=10

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 17, 2019

📌 Commit 4d18023 has been approved by Mark-Simulacrum

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 17, 2019

⌛️ Testing commit 4d18023 with merge 6599946...

bors added a commit that referenced this pull request Jan 17, 2019

Auto merge of #57520 - alexreg:tidy-copyright-lint, r=Mark-Simulacrum
Add lint for copyright headers to 'tidy' tool

r? @Mark-Simulacrum

CC @Centril

@bors bors referenced this pull request Jan 17, 2019

Closed

Prepare beta 1.33.0 #57670

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing 6599946 to master...

@bors bors merged commit 4d18023 into rust-lang:master Jan 17, 2019

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment