New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unaccept `extern_in_paths` #57572

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
4 participants
@Centril
Copy link
Contributor

Centril commented Jan 13, 2019

Based on completed fcp-close in #55600, this removes extern_in_path (e.g. extern::foo::bar) from the language. The changes are primarily reversing 32db83b.

Closes #55600

r? @petrochenkov

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Jan 14, 2019

My only concern is that this makes r#extern legal, so in theory we won't be able to make extern a path segment keyword again if it becomes necessary.

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 14, 2019

📌 Commit c4f6ef2 has been approved by petrochenkov

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57572 - Centril:unaccept-extern-in-path, r=…
…petrochenkov

Unaccept `extern_in_paths`

Based on completed fcp-close in rust-lang#55600, this removes `extern_in_path` (e.g. `extern::foo::bar`) from the language. The changes are primarily reversing rust-lang@32db83b.

Closes rust-lang#55600

r? @petrochenkov

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57572 - Centril:unaccept-extern-in-path, r=…
…petrochenkov

Unaccept `extern_in_paths`

Based on completed fcp-close in rust-lang#55600, this removes `extern_in_path` (e.g. `extern::foo::bar`) from the language. The changes are primarily reversing rust-lang@32db83b.

Closes rust-lang#55600

r? @petrochenkov

bors added a commit that referenced this pull request Jan 14, 2019

Auto merge of #57607 - Centril:rollup, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #57043 (Fix poor worst case performance of set intersection)
 - #57480 (Clean up and fix a bug in query plumbing)
 - #57481 (provide suggestion for invalid boolean cast)
 - #57540 (Modify some parser diagnostics to continue evaluating beyond the parser)
 - #57570 (Querify local `plugin_registrar_fn` and `proc_macro_decls_static`)
 - #57572 (Unaccept `extern_in_paths`)
 - #57585 (Recover from item trailing semicolon)
 - #57589 (Add a debug_assert to Vec::set_len)

Failed merges:

r? @ghost

@bors bors merged commit c4f6ef2 into rust-lang:master Jan 15, 2019

@Centril Centril deleted the Centril:unaccept-extern-in-path branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment