New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the fake stack frame for reading from constants #57606

Merged
merged 5 commits into from Jan 25, 2019

Conversation

Projects
None yet
6 participants
@oli-obk
Copy link
Contributor

oli-obk commented Jan 14, 2019

r? @RalfJung

fixes the ice in #53708 but still keeps around the wrong "non-exhaustive match" error

cc @varkor

@RalfJung

This comment has been minimized.

Copy link
Member

RalfJung commented Jan 14, 2019

(I'm on a conference, and will start catching up with my emails on Jan 22nd.)

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

oli-obk commented Jan 15, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 15, 2019

⌛️ Trying commit b805232 with merge a5a18a4...

bors added a commit that referenced this pull request Jan 15, 2019

Auto merge of #57606 - oli-obk:shrink, r=<try>
Get rid of the fake stack frame for reading from constants

r? @RalfJung

fixes the ice in #53708 but still keeps around the wrong "non-exhaustive match" error

cc @varkor
@oli-obk

This comment has been minimized.

Copy link
Contributor Author

oli-obk commented Jan 15, 2019

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 15, 2019

Success: Queued a5a18a4 with parent 33e6df4, comparison URL.

@kennytm

This comment was marked as resolved.

Copy link
Member

kennytm commented Jan 15, 2019

@bors retry try

Bors hiccup.

@bors

This comment was marked as off-topic.

Copy link
Contributor

bors commented Jan 15, 2019

⌛️ Trying commit b805232 with merge c5b89bf...

bors added a commit that referenced this pull request Jan 15, 2019

Auto merge of #57606 - oli-obk:shrink, r=<try>
Get rid of the fake stack frame for reading from constants

r? @RalfJung

fixes the ice in #53708 but still keeps around the wrong "non-exhaustive match" error

cc @varkor
@bors

This comment was marked as off-topic.

Copy link
Contributor

bors commented Jan 15, 2019

💔 Test failed - checks-travis

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 15, 2019

Finished benchmarking try commit a5a18a4

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 22, 2019

☔️ The latest upstream changes (presumably #57830) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk force-pushed the oli-obk:shrink branch from b805232 to d4ee556 Jan 23, 2019

@RalfJung

This comment has been minimized.

Copy link
Member

RalfJung commented Jan 23, 2019

Thanks!

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 23, 2019

📌 Commit d4ee556 has been approved by RalfJung

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 23, 2019

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

Centril added a commit to Centril/rust that referenced this pull request Jan 24, 2019

Rollup merge of rust-lang#57606 - oli-obk:shrink, r=RalfJung
Get rid of the fake stack frame for reading from constants

r? @RalfJung

fixes the ice in rust-lang#53708 but still keeps around the wrong "non-exhaustive match" error

cc @varkor

bors added a commit that referenced this pull request Jan 24, 2019

Auto merge of #57874 - Centril:rollup, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #57066 (Fix race condition when emitting stored diagnostics)
 - #57606 (Get rid of the fake stack frame for reading from constants)
 - #57734 (Fix evaluating trivial drop glue in constants)
 - #57846 (rustdoc: fix ICE from loading proc-macro stubs)
 - #57860 (Add os::fortanix_sgx::ffi module)
 - #57861 (Don't export table by default in wasm)
 - #57863 (Add suggestion for incorrect field syntax.)
 - #57867 (Fix std::future::from_generator documentation)
 - #57873 (Stabilize no_panic_pow)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Jan 24, 2019

Auto merge of #57874 - Centril:rollup, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #57066 (Fix race condition when emitting stored diagnostics)
 - #57606 (Get rid of the fake stack frame for reading from constants)
 - #57734 (Fix evaluating trivial drop glue in constants)
 - #57846 (rustdoc: fix ICE from loading proc-macro stubs)
 - #57860 (Add os::fortanix_sgx::ffi module)
 - #57861 (Don't export table by default in wasm)
 - #57863 (Add suggestion for incorrect field syntax.)
 - #57867 (Fix std::future::from_generator documentation)
 - #57873 (Stabilize no_panic_pow)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jan 24, 2019

Rollup merge of rust-lang#57606 - oli-obk:shrink, r=RalfJung
Get rid of the fake stack frame for reading from constants

r? @RalfJung

fixes the ice in rust-lang#53708 but still keeps around the wrong "non-exhaustive match" error

cc @varkor

bors added a commit that referenced this pull request Jan 24, 2019

Auto merge of #57879 - Centril:rollup, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #57380 (Fix Instant/Duration math precision & associativity on Windows)
 - #57606 (Get rid of the fake stack frame for reading from constants)
 - #57803 (Several changes to libunwind for SGX target)
 - #57846 (rustdoc: fix ICE from loading proc-macro stubs)
 - #57860 (Add os::fortanix_sgx::ffi module)
 - #57861 (Don't export table by default in wasm)
 - #57863 (Add suggestion for incorrect field syntax.)
 - #57867 (Fix std::future::from_generator documentation)
 - #57873 (Stabilize no_panic_pow)

Failed merges:

r? @ghost

@bors bors merged commit d4ee556 into rust-lang:master Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment