New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a faster early exit during region expansion #57697

Merged
merged 1 commit into from Jan 20, 2019

Conversation

Projects
None yet
7 participants
@dotdash
Copy link
Contributor

dotdash commented Jan 17, 2019

Turns out that the equality check for regions is rather expensive, and
the current early exit check works in such a way, that the comparison is
even done twice. As we only really care about the case of equal scopes,
we can perform a faster, more specialized check and move it up one
level, so we can eventually skip the additional full comparison as well.

Use a faster early exit during region expansion
Turns out that the equality check for regions is rather expensive, and
the current early exit check works in such a way, that the comparison is
even done twice. As we only really care about the case of equal scopes,
we can perform a faster, more specialized check and move it up one
level, so we can eventually skip the additional full comparison as well.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 17, 2019

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Jan 17, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 17, 2019

⌛️ Trying commit f0d3df3 with merge 2b619f5...

bors added a commit that referenced this pull request Jan 17, 2019

Auto merge of #57697 - dotdash:fast_lex_reg_resol_item_bodies, r=<try>
Use a faster early exit during region expansion

Turns out that the equality check for regions is rather expensive, and
the current early exit check works in such a way, that the comparison is
even done twice. As we only really care about the case of equal scopes,
we can perform a faster, more specialized check and move it up one
level, so we can eventually skip the additional full comparison as well.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 17, 2019

☀️ Test successful - checks-travis
State: approved= try=True

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Jan 17, 2019

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 17, 2019

Success: Queued 2b619f5 with parent daa53a5, comparison URL.

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 17, 2019

Finished benchmarking try commit 2b619f5

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Jan 17, 2019

@bors r+

@ishitatsuyuki

This comment has been minimized.

Copy link
Member

ishitatsuyuki commented Jan 20, 2019

@nagisa your r+ is probably missed.

@dotdash

This comment has been minimized.

Copy link
Contributor Author

dotdash commented Jan 20, 2019

@bors r=nagisa

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 20, 2019

📌 Commit f0d3df3 has been approved by nagisa

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 20, 2019

⌛️ Testing commit f0d3df3 with merge 794e228...

bors added a commit that referenced this pull request Jan 20, 2019

Auto merge of #57697 - dotdash:fast_lex_reg_resol_item_bodies, r=nagisa
Use a faster early exit during region expansion

Turns out that the equality check for regions is rather expensive, and
the current early exit check works in such a way, that the comparison is
even done twice. As we only really care about the case of equal scopes,
we can perform a faster, more specialized check and move it up one
level, so we can eventually skip the additional full comparison as well.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 20, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: nagisa
Pushing 794e228 to master...

@bors bors merged commit f0d3df3 into rust-lang:master Jan 20, 2019

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment