Install missing 'rust-gdbui'' #57708
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
src/bootstrap/dist.rs
Outdated
| // gdb debugger scripts | ||
| builder.install(&builder.src.join("src/etc/rust-gdb"), &sysroot.join("bin"), | ||
| 0o755); | ||
| builder.install(&builder.src.join("src/etc/rust-gdbui"), &sysroot.join("bin"), |
There was a problem hiding this comment.
Typo here: it should be src/etc/rust-gdbgui, with a g
There was a problem hiding this comment.
Good catch! Fixed in bf9c0fb.
|
@nbigaouette Erm, I wrote the original script, but given that several months has passed, have you tested that it still works? I only ask since I tend to use VSCode now that I have got debugging working in there. Though if this does work I may go back to using gdbgui! |
|
I didn't even know this script existed, and I don't really know how this installation stuff works. Moving this review to @Mark-Simulacrum, maybe they know who to reassign to, or whether this subsystem still works or what. =) |
|
@bors r+ |
|
📌 Commit bf9c0fb has been approved by |
bors
added
S-waiting-on-bors
|
What I did to try it out is create a symbolic link: It initially failed, but it was because I had But I do have problem launching gdb on my (mac) machine. I'm hit by #40787 and if I try the workaround, gdb launches, but running the binary just hangs. So I unfortunately cannot test gdbgui more than launching it for now... Wish I could :( |
|
@bors p=10 (preserves current ordering relative to other PRs) |
…stall, r=Mark-Simulacrum Install missing 'rust-gdbui'' PR #53774 added `rust-gdbui` as wrapper to launch [gdbui](https://gdbgui.com/), similar to `rust-gdb`. Unfortunately I've never seen the script in my local installation (from rustup, using rust 1.31.1). @tromey on the PR [suggested it might be missing](#53774 (comment)) from the installation process. This PR simply adds a line for `rust-gdbui` too.
|
☀️ Test successful - checks-travis, status-appveyor |
PR #53774 added
rust-gdbuias wrapper to launch gdbui, similar torust-gdb.Unfortunately I've never seen the script in my local installation (from rustup, using rust 1.31.1). @tromey on the PR suggested it might be missing from the installation process.
This PR simply adds a line for
rust-gdbuitoo.