New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "dereference boxed value" suggestion. #57783

Merged
merged 1 commit into from Jan 21, 2019

Conversation

Projects
None yet
4 participants
@davidtwco
Copy link
Member

davidtwco commented Jan 20, 2019

Fix #57741.

This PR adds a help: consider dereferencing the boxed value suggestion to discriminants of match statements when the match arms have type T and the discriminant has type Box<T>.

r? @estebank

Add "dereference boxed value" suggestion.
This commit adds a `help: consider dereferencing the boxed value`
suggestion to discriminants of match statements when the match arms have
type `T` and the discriminant has type `Box<T>`.

@davidtwco davidtwco force-pushed the davidtwco:issue-57741 branch from da9b003 to f13fe5f Jan 20, 2019

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Jan 20, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 20, 2019

📌 Commit f13fe5f has been approved by estebank

Centril added a commit to Centril/rust that referenced this pull request Jan 21, 2019

Rollup merge of rust-lang#57783 - davidtwco:issue-57741, r=estebank
Add "dereference boxed value" suggestion.

Contributes to rust-lang#57741.

This PR adds a `help: consider dereferencing the boxed value` suggestion to discriminants of match statements when the match arms have type `T` and the discriminant has type `Box<T>`.

r? @estebank

bors added a commit that referenced this pull request Jan 21, 2019

Auto merge of #57792 - Centril:rollup, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #56796 (Change bounds on `TryFrom` blanket impl to use `Into` instead of `From`)
 - #57768 (Continue parsing after parent type args and suggest using angle brackets)
 - #57769 (Suggest correct cast for struct fields with shorthand syntax)
 - #57783 (Add "dereference boxed value" suggestion.)
 - #57784 (Add span for bad doc comment)

Failed merges:

r? @ghost

@bors bors merged commit f13fe5f into rust-lang:master Jan 21, 2019

@davidtwco davidtwco deleted the davidtwco:issue-57741 branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment