/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "dereference boxed value" suggestion. #57783

Merged
merged 1 commit into from Jan 21, 2019
+183 −2

Conversation

Reviewers

@estebank estebank

Assignees

@estebank estebank

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
4 participants
@davidtwco @estebank @bors @rust-highfive
@davidtwco
Copy link
Member

davidtwco commented Jan 20, 2019 •
edited by estebank

Fix #57741.

This PR adds a help: consider dereferencing the boxed value suggestion to discriminants of match statements when the match arms have type T and the discriminant has type Box<T>.

r? @estebank

@rust-highfive rust-highfive assigned estebank Jan 20, 2019

@rust-highfive rust-highfive added the S-waiting-on-review label Jan 20, 2019

@davidtwco davidtwco referenced this pull request Jan 20, 2019

Closed

Suggest dereferencing boxed enum when matching #57741

@estebank

estebank reviewed Jan 20, 2019
View changes

Show resolved Hide resolved src/librustc/infer/error_reporting/mod.rs Outdated
@davidtwco
Add "dereference boxed value" suggestion. 
This commit adds a `help: consider dereferencing the boxed value`
suggestion to discriminants of match statements when the match arms have
type `T` and the discriminant has type `Box<T>`.
Verified
This commit was signed with a verified signature.
@davidtwco davidtwco David Wood
GPG key ID: 01760B4F9F53F154 Learn about signing commits
Loading status checks…
f13fe5f

@davidtwco davidtwco force-pushed the davidtwco:issue-57741 branch from da9b003 to f13fe5f Jan 20, 2019

@estebank

This comment has been minimized.

Sign in to view
Copy link
Contributor

estebank commented Jan 20, 2019

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 20, 2019

📌 Commit f13fe5f has been approved by estebank

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Jan 20, 2019

Centril added a commit to Centril/rust that referenced this pull request Jan 21, 2019

@Centril
Rollup merge of rust-lang#57783 - davidtwco:issue-57741, r=estebank 
Add "dereference boxed value" suggestion.

Contributes to rust-lang#57741.

This PR adds a `help: consider dereferencing the boxed value` suggestion to discriminants of match statements when the match arms have type `T` and the discriminant has type `Box<T>`.

r? @estebank
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
74b8cd4

@Centril Centril referenced this pull request Jan 21, 2019

Merged

Rollup of 5 pull requests #57792

bors added a commit that referenced this pull request Jan 21, 2019

@bors
Auto merge of #57792 - Centril:rollup, r=Centril 
Rollup of 5 pull requests

Successful merges:

 - #56796 (Change bounds on `TryFrom` blanket impl to use `Into` instead of `From`)
 - #57768 (Continue parsing after parent type args and suggest using angle brackets)
 - #57769 (Suggest correct cast for struct fields with shorthand syntax)
 - #57783 (Add "dereference boxed value" suggestion.)
 - #57784 (Add span for bad doc comment)

Failed merges:

r? @ghost
Loading status checks…
33b0b71

@bors bors merged commit f13fe5f into rust-lang:master Jan 21, 2019

@davidtwco davidtwco deleted the davidtwco:issue-57741 branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment