New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use structured suggestion in stead of notes #57795

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
5 participants
@estebank
Copy link
Contributor

estebank commented Jan 21, 2019

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 21, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 21, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:00feae5a:start=1548041956236506024,finish=1548041957210845898,duration=974339874
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[01:04:55] .................................................................................................... 3500/5312
[01:04:58] .................................................................................................... 3600/5312
[01:05:01] ............................................ii...................................................... 3700/5312
[01:05:03] ..............................................................i..................................... 3800/5312
[01:05:05] ..................F................................................................................. 3900/5312
[01:05:11] .................................................................................................... 4100/5312
[01:05:21] .................................................................................................... 4200/5312
[01:05:25] .................................................................................................... 4300/5312
[01:05:28] .................................................................................................... 4400/5312
---
[01:06:01] failures:
[01:06:01] 
[01:06:01] ---- [ui] ui/parser/issue-17718-const-mut.rs stdout ----
[01:06:01] 
[01:06:01] error: /checkout/src/test/ui/parser/issue-17718-const-mut.rs:1: unexpected help message: '1:1: 1:6: you might want to declare a static instead'
[01:06:01] 
[01:06:01] error: /checkout/src/test/ui/parser/issue-17718-const-mut.rs:2: expected help message not found: you might want to declare a static instead
[01:06:01] error: 1 unexpected errors found, 1 expected errors not found
[01:06:01] status: exit code: 1
[01:06:01] status: exit code: 1
[01:06:01] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/parser/issue-17718-const-mut.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/issue-17718-const-mut/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/issue-17718-const-mut/auxiliary" "-A" "unused"
[01:06:01]     Error {
[01:06:01]         line_num: 1,
[01:06:01]         kind: Some(
[01:06:01]             Help
[01:06:01]             Help
[01:06:01]         ),
[01:06:01]         msg: "1:1: 1:6: you might want to declare a static instead"
[01:06:01] ]
[01:06:01] 
[01:06:01] not found errors (from test file): [
[01:06:01]     Error {
[01:06:01]     Error {
[01:06:01]         line_num: 2,
[01:06:01]         kind: Some(
[01:06:01]             Help
[01:06:01]         ),
[01:06:01]         msg: "you might want to declare a static instead"
[01:06:01] ]
[01:06:01] 
[01:06:01] thread '[ui] ui/parser/issue-17718-const-mut.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1342:13
[01:06:01] 
---
[01:06:01] 
[01:06:01] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:495:22
[01:06:01] 
[01:06:01] 
[01:06:01] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:06:01] 
[01:06:01] 
[01:06:01] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:06:01] Build completed unsuccessfully in 0:04:09
[01:06:01] Build completed unsuccessfully in 0:04:09
[01:06:01] make: *** [check] Error 1
[01:06:01] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:34e7eee8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Jan 21 04:45:28 UTC 2019
---
travis_time:end:017e1250:start=1548045930034509422,finish=1548045930041359491,duration=6850069
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:26c43fb7
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:009af668
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank estebank force-pushed the estebank:did-you-mean branch from d6cab71 to 45a95b5 Jan 21, 2019

@zackmdavis

This comment has been minimized.

Copy link
Member

zackmdavis commented Jan 21, 2019

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 21, 2019

📌 Commit 45a95b5 has been approved by zackmdavis

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 21, 2019

Rollup merge of rust-lang#57795 - estebank:did-you-mean, r=zackmdavis
Use structured suggestion in stead of notes

bors added a commit that referenced this pull request Jan 21, 2019

Auto merge of #57816 - GuillaumeGomez:rollup, r=GuillaumeGomez
Rollup of 5 pull requests

Successful merges:

 - #57495 (Support multiple versions of MdBook for docs)
 - #57552 (Default images)
 - #57791 (Add regression test for #54582)
 - #57795 (Use structured suggestion in stead of notes)
 - #57798 (Corrected spelling inconsistency)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jan 21, 2019

Rollup merge of rust-lang#57795 - estebank:did-you-mean, r=zackmdavis
Use structured suggestion in stead of notes

bors added a commit that referenced this pull request Jan 22, 2019

Auto merge of #57823 - Centril:rollup, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #57294 (When using value after move, point at span of local)
 - #57552 (Default images)
 - #57667 (Fix memory leak in P::filter_map)
 - #57677 (const_eval: Predetermine the layout of all locals when pushing a stack frame)
 - #57730 (Merge visitors in AST validation)
 - #57791 (Add regression test for #54582)
 - #57795 (Use structured suggestion in stead of notes)
 - #57809 (Add powerpc64-unknown-freebsd)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jan 23, 2019

Rollup merge of rust-lang#57795 - estebank:did-you-mean, r=zackmdavis
Use structured suggestion in stead of notes

bors added a commit that referenced this pull request Jan 23, 2019

Auto merge of #57850 - Centril:rollup, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #55448 (Add 'partition_at_index/_by/_by_key' for slices.)
 - #57179 (Update std/lib.rs docs to reflect Rust 2018 usage)
 - #57730 (Merge visitors in AST validation)
 - #57779 (Recover from parse errors in literal struct fields and incorrect float literals)
 - #57793 (Explain type mismatch cause pointing to return type when it is `impl Trait`)
 - #57795 (Use structured suggestion in stead of notes)
 - #57817 (Add error for trailing angle brackets.)
 - #57834 (Stabilize Any::get_type_id and rename to type_id)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Jan 23, 2019

Auto merge of #57850 - Centril:rollup, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #55448 (Add 'partition_at_index/_by/_by_key' for slices.)
 - #57179 (Update std/lib.rs docs to reflect Rust 2018 usage)
 - #57730 (Merge visitors in AST validation)
 - #57779 (Recover from parse errors in literal struct fields and incorrect float literals)
 - #57793 (Explain type mismatch cause pointing to return type when it is `impl Trait`)
 - #57795 (Use structured suggestion in stead of notes)
 - #57817 (Add error for trailing angle brackets.)
 - #57834 (Stabilize Any::get_type_id and rename to type_id)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Jan 23, 2019

Auto merge of #57850 - Centril:rollup, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #55448 (Add 'partition_at_index/_by/_by_key' for slices.)
 - #57179 (Update std/lib.rs docs to reflect Rust 2018 usage)
 - #57730 (Merge visitors in AST validation)
 - #57779 (Recover from parse errors in literal struct fields and incorrect float literals)
 - #57793 (Explain type mismatch cause pointing to return type when it is `impl Trait`)
 - #57795 (Use structured suggestion in stead of notes)
 - #57817 (Add error for trailing angle brackets.)
 - #57834 (Stabilize Any::get_type_id and rename to type_id)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Jan 23, 2019

Auto merge of #57850 - Centril:rollup, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #55448 (Add 'partition_at_index/_by/_by_key' for slices.)
 - #57179 (Update std/lib.rs docs to reflect Rust 2018 usage)
 - #57730 (Merge visitors in AST validation)
 - #57779 (Recover from parse errors in literal struct fields and incorrect float literals)
 - #57793 (Explain type mismatch cause pointing to return type when it is `impl Trait`)
 - #57795 (Use structured suggestion in stead of notes)
 - #57817 (Add error for trailing angle brackets.)
 - #57834 (Stabilize Any::get_type_id and rename to type_id)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jan 23, 2019

Rollup merge of rust-lang#57795 - estebank:did-you-mean, r=zackmdavis
Use structured suggestion in stead of notes

bors added a commit that referenced this pull request Jan 24, 2019

Auto merge of #57869 - Centril:rollup, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #57179 (Update std/lib.rs docs to reflect Rust 2018 usage)
 - #57730 (Merge visitors in AST validation)
 - #57779 (Recover from parse errors in literal struct fields and incorrect float literals)
 - #57793 (Explain type mismatch cause pointing to return type when it is `impl Trait`)
 - #57795 (Use structured suggestion in stead of notes)
 - #57817 (Add error for trailing angle brackets.)
 - #57834 (Stabilize Any::get_type_id and rename to type_id)
 - #57836 (Fix some cross crate existential type ICEs)
 - #57840 (Fix issue 57762)
 - #57844 (use port 80 for retrieving GPG key)
 - #57858 (Ignore line ending on older git versions)

Failed merges:

r? @ghost

@bors bors merged commit 45a95b5 into rust-lang:master Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment