New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print visible name for types as well as modules. #57802

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
3 participants
@davidtwco
Copy link
Member

davidtwco commented Jan 21, 2019

Fixes #56943 and fixes #57713.

This commit extends previous work in #55007 where the name from the
visible parent was used for modules. Now, we also print the name from
the visible parent for types.

r? @estebank

Print visible name for types as well as modules.
This commit extends previous work in #55007 where the name from the
visible parent was used for modules. Now, we also print the name from
the visible parent for types.
@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Jan 24, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 24, 2019

📌 Commit 1db4275 has been approved by estebank

Centril added a commit to Centril/rust that referenced this pull request Jan 25, 2019

Rollup merge of rust-lang#57802 - davidtwco:issue-56943, r=estebank
Print visible name for types as well as modules.

Fixes rust-lang#56943 and fixes rust-lang#57713.

This commit extends previous work in rust-lang#55007 where the name from the
visible parent was used for modules. Now, we also print the name from
the visible parent for types.

r? @estebank

bors added a commit that referenced this pull request Jan 25, 2019

Auto merge of #57888 - Centril:rollup, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #56217 (Add grammar in docs for {f32,f64}::from_str, mention known bug.)
 - #57294 (When using value after move, point at span of local)
 - #57652 (Update/remove some old readmes)
 - #57802 (Print visible name for types as well as modules.)
 - #57865 (Don't ICE when logging unusual types)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 25, 2019

☔️ The latest upstream changes (presumably #57888) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit 1db4275 into rust-lang:master Jan 25, 2019

@davidtwco davidtwco deleted the davidtwco:issue-56943 branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment