Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move privacy checking later in the pipeline and make some passes run in parallel #58010

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
5 participants
@Zoxc
Copy link
Contributor

Zoxc commented Jan 30, 2019

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Feb 6, 2019

Looks good! Can you explain why you moved privacy checking?

@Zoxc

This comment has been minimized.

Copy link
Contributor Author

Zoxc commented Feb 6, 2019

I moved it so it could run in parallel with other more expensive non-incremental passes (helps with incremental compilation). I want to get stability checking down there too, but it was giving me strange errors if done after type collecting, so I skipped that for now.

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Feb 6, 2019

OK, makes sense. Thanks, @Zoxc!

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 6, 2019

📌 Commit 38bcd4b has been approved by michaelwoerister

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 7, 2019

⌛️ Testing commit 38bcd4b with merge ad43389...

bors added a commit that referenced this pull request Feb 7, 2019

Auto merge of #58010 - Zoxc:parallel-passes, r=michaelwoerister
Move privacy checking later in the pipeline and make some passes run in parallel

r? @michaelwoerister

@bors bors referenced this pull request Feb 7, 2019

Merged

Update minifier version #57884

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: michaelwoerister
Pushing ad43389 to master...

@bors bors merged commit 38bcd4b into rust-lang:master Feb 7, 2019

1 check passed

homu Test successful
Details

@Zoxc Zoxc deleted the Zoxc:parallel-passes branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.