New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search results interactions #58336

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
5 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Feb 9, 2019

The bug is visible when you search for "none": the second tab is empty and therefore it messes with the classes. Then when you try to use arrows on the third tab, it just crashes (because only 2 "search-results" are present and you're on tab 3).

r? @QuietMisdreavus

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Feb 18, 2019

Then when you try to use arrows on the third tab

I'm not sure what that means. I tried using arrow keys and it didn't do anything odd. What are the steps to reproduce this?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Feb 18, 2019

Search for "none". Then press tab twice (or MAJ+tab) to go to the third search tab results then press down arrow. Normally you should have a nice JS error. :)

To put it simply: if the first or the second tab is empty, the third one arrows interactions won't work.

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Feb 18, 2019

I didn't know we had arrow interactions, and they don't really seem to be working for me all that well anyway even if all the tabs have results. But the explanation and code change makes sense to me, so...

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 18, 2019

📌 Commit 69d948d has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 18, 2019

🌲 The tree is currently closed for pull requests below priority 160, this pull request will be tested once the tree is reopened

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Feb 18, 2019

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Feb 18, 2019

Rollup merge of rust-lang#58336 - GuillaumeGomez:fix-search-results-i…
…nteractions, r=oli-obk

Fix search results interactions

The bug is visible when you search for "none": the second tab is empty and therefore it messes with the classes. Then when you try to use arrows on the third tab, it just crashes (because only 2 "search-results" are present and you're on tab 3).

r? @QuietMisdreavus

bors added a commit that referenced this pull request Feb 19, 2019

Auto merge of #58566 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 16 pull requests

Successful merges:

 - #55632 (Deny the `overflowing_literals` lint for all editions)
 - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
 - #58198 (Suggest removing parentheses surrounding lifetimes)
 - #58199 (Add better error message for partial move)
 - #58303 (Improve stability tags display)
 - #58336 (Fix search results interactions)
 - #58392 (Use less explicit shifting in std::net::ip)
 - #58528 (Don't use an allocation for ItemId in StmtKind)
 - #58530 (Monomorphize less code in fs::{read|write})
 - #58534 (Mention capping forbid lints)
 - #58536 (Remove UB in pointer tests)
 - #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
 - #58544 (Fix doc for rustc "-g" flag)
 - #58545 (Add regression test for a specialization-related ICE (#39448))
 - #58551 (Explain a panic in test case net::tcp::tests::double_bind )
 - #58555 (Add a note about 2018e if someone uses `try {` in 2015e)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Feb 19, 2019

Auto merge of #58566 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 16 pull requests

Successful merges:

 - #55632 (Deny the `overflowing_literals` lint for all editions)
 - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
 - #58198 (Suggest removing parentheses surrounding lifetimes)
 - #58199 (Add better error message for partial move)
 - #58303 (Improve stability tags display)
 - #58336 (Fix search results interactions)
 - #58392 (Use less explicit shifting in std::net::ip)
 - #58528 (Don't use an allocation for ItemId in StmtKind)
 - #58530 (Monomorphize less code in fs::{read|write})
 - #58534 (Mention capping forbid lints)
 - #58536 (Remove UB in pointer tests)
 - #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
 - #58544 (Fix doc for rustc "-g" flag)
 - #58545 (Add regression test for a specialization-related ICE (#39448))
 - #58551 (Explain a panic in test case net::tcp::tests::double_bind )
 - #58555 (Add a note about 2018e if someone uses `try {` in 2015e)

Failed merges:

r? @ghost

kennytm added a commit to kennytm/rust that referenced this pull request Feb 19, 2019

Rollup merge of rust-lang#58336 - GuillaumeGomez:fix-search-results-i…
…nteractions, r=oli-obk

Fix search results interactions

The bug is visible when you search for "none": the second tab is empty and therefore it messes with the classes. Then when you try to use arrows on the third tab, it just crashes (because only 2 "search-results" are present and you're on tab 3).

r? @QuietMisdreavus

bors added a commit that referenced this pull request Feb 20, 2019

Auto merge of #58578 - kennytm:rollup, r=kennytm
Rollup of 24 pull requests

Successful merges:

 - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
 - #58232 (HirId-ify intravisit)
 - #58303 (Improve stability tags display)
 - #58336 (Fix search results interactions)
 - #58384 (Fix tables display)
 - #58392 (Use less explicit shifting in std::net::ip)
 - #58409 (rustdoc: respect alternate flag when formatting impl trait)
 - #58456 (Remove no longer accurate diagnostic code about NLL)
 - #58528 (Don't use an allocation for ItemId in StmtKind)
 - #58530 (Monomorphize less code in fs::{read|write})
 - #58534 (Mention capping forbid lints)
 - #58536 (Remove UB in pointer tests)
 - #58538 (Add missing fmt structs examples)
 - #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
 - #58544 (Fix doc for rustc "-g" flag)
 - #58545 (Add regression test for a specialization-related ICE (#39448))
 - #58546 (librustc_codegen_llvm => 2018)
 - #58551 (Explain a panic in test case net::tcp::tests::double_bind )
 - #58553 (Use more impl header lifetime elision)
 - #58562 (Fix style nits)
 - #58565 (Fix typo in std::future::Future docs)
 - #58568 (Fix a transposition in driver.rs.)
 - #58569 (Reduce Some Code Repetitions like `(n << amt) >> amt`)
 - #58576 (Stabilize iter::successors and iter::from_fn)

Failed merges:

r? @ghost

kennytm added a commit to kennytm/rust that referenced this pull request Feb 20, 2019

Rollup merge of rust-lang#58336 - GuillaumeGomez:fix-search-results-i…
…nteractions, r=oli-obk

Fix search results interactions

The bug is visible when you search for "none": the second tab is empty and therefore it messes with the classes. Then when you try to use arrows on the third tab, it just crashes (because only 2 "search-results" are present and you're on tab 3).

r? @QuietMisdreavus

bors added a commit that referenced this pull request Feb 20, 2019

Auto merge of #58578 - kennytm:rollup, r=kennytm
Rollup of 24 pull requests

Successful merges:

 - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
 - #58044 (Make overflowing and wrapping negation const)
 - #58303 (Improve stability tags display)
 - #58336 (Fix search results interactions)
 - #58384 (Fix tables display)
 - #58392 (Use less explicit shifting in std::net::ip)
 - #58409 (rustdoc: respect alternate flag when formatting impl trait)
 - #58456 (Remove no longer accurate diagnostic code about NLL)
 - #58528 (Don't use an allocation for ItemId in StmtKind)
 - #58530 (Monomorphize less code in fs::{read|write})
 - #58534 (Mention capping forbid lints)
 - #58536 (Remove UB in pointer tests)
 - #58538 (Add missing fmt structs examples)
 - #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
 - #58544 (Fix doc for rustc "-g" flag)
 - #58545 (Add regression test for a specialization-related ICE (#39448))
 - #58546 (librustc_codegen_llvm => 2018)
 - #58551 (Explain a panic in test case net::tcp::tests::double_bind)
 - #58553 (Use more impl header lifetime elision)
 - #58562 (Fix style nits)
 - #58565 (Fix typo in std::future::Future docs)
 - #58568 (Fix a transposition in driver.rs.)
 - #58569 (Reduce Some Code Repetitions like `(n << amt) >> amt`)
 - #58576 (Stabilize iter::successors and iter::from_fn)

bors added a commit that referenced this pull request Feb 20, 2019

Auto merge of #58578 - kennytm:rollup, r=kennytm
Rollup of 24 pull requests

Successful merges:

 - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
 - #58044 (Make overflowing and wrapping negation const)
 - #58303 (Improve stability tags display)
 - #58336 (Fix search results interactions)
 - #58384 (Fix tables display)
 - #58392 (Use less explicit shifting in std::net::ip)
 - #58409 (rustdoc: respect alternate flag when formatting impl trait)
 - #58456 (Remove no longer accurate diagnostic code about NLL)
 - #58528 (Don't use an allocation for ItemId in StmtKind)
 - #58530 (Monomorphize less code in fs::{read|write})
 - #58534 (Mention capping forbid lints)
 - #58536 (Remove UB in pointer tests)
 - #58538 (Add missing fmt structs examples)
 - #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
 - #58544 (Fix doc for rustc "-g" flag)
 - #58545 (Add regression test for a specialization-related ICE (#39448))
 - #58546 (librustc_codegen_llvm => 2018)
 - #58551 (Explain a panic in test case net::tcp::tests::double_bind)
 - #58553 (Use more impl header lifetime elision)
 - #58562 (Fix style nits)
 - #58565 (Fix typo in std::future::Future docs)
 - #58568 (Fix a transposition in driver.rs.)
 - #58569 (Reduce Some Code Repetitions like `(n << amt) >> amt`)
 - #58576 (Stabilize iter::successors and iter::from_fn)

@bors bors merged commit 69d948d into rust-lang:master Feb 20, 2019

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:fix-search-results-interactions branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment