Update Clippy, RLS and rustfmt #58337

flip1995 · 2019-02-10T00:36:56Z

Update Clippy to rust-lang/rust-clippy@32ee306
Update RLS to rust-lang/rls@0d6f53e
Update rustfmt to rust-lang/rustfmt@d6829d6

r? @Manishearth @oli-obk

rust-highfive · 2019-02-10T00:37:07Z

⚠️ Warning ⚠️

These commits modify submodules.

rust-highfive · 2019-02-10T00:41:04Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:333e754c:start=1549759091355204723,finish=1549759093484564248,duration=2129359525
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
####################################################################      94.8%
######################################################################## 100.0%
[00:02:10] extracting /checkout/obj/build/cache/2019-01-18/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:02:10]     Updating crates.io index
[00:02:21] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:21] Build completed unsuccessfully in 0:00:34
[00:02:21] Makefile:70: recipe for target 'prepare' failed
[00:02:21] make: *** [prepare] Error 1
[00:02:22] Command failed. Attempt 2/5:
[00:02:22] Command failed. Attempt 2/5:
[00:02:22]     Updating crates.io index
[00:02:22] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:22] Build completed unsuccessfully in 0:00:00
[00:02:22] make: *** [prepare] Error 1
[00:02:22] Makefile:70: recipe for target 'prepare' failed
[00:02:24] Command failed. Attempt 3/5:
[00:02:24] Command failed. Attempt 3/5:
[00:02:25]     Updating crates.io index
[00:02:25] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:25] Build completed unsuccessfully in 0:00:00
[00:02:25] Makefile:70: recipe for target 'prepare' failed
[00:02:25] make: *** [prepare] Error 1
[00:02:28] Command failed. Attempt 4/5:
[00:02:28] Command failed. Attempt 4/5:
[00:02:28]     Updating crates.io index
[00:02:29] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:29] Build completed unsuccessfully in 0:00:00
[00:02:29] make: *** [prepare] Error 1
[00:02:29] Makefile:70: recipe for target 'prepare' failed
[00:02:33] Command failed. Attempt 5/5:
[00:02:33] Command failed. Attempt 5/5:
[00:02:33]     Updating crates.io index
[00:02:33] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:33] Build completed unsuccessfully in 0:00:00
[00:02:33] make: *** [prepare] Error 1
[00:02:33] Makefile:70: recipe for target 'prepare' failed
[00:02:33] The command has failed after 5 attempts.
---
travis_time:end:003c43b3:start=1549759260691181591,finish=1549759260695901553,duration=4719962
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:113ca358
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0de1816b
travis_time:start:0de1816b
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:00c2e4c1
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2019-02-11T13:47:37Z

@bors r+ p=1

bors · 2019-02-11T13:47:38Z

📌 Commit 4613e4b6237a5cb637a2c993a050eaadf1364948 has been approved by oli-obk

bors · 2019-02-11T15:30:54Z

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout clippyup (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self clippyup --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

warning: Cannot merge binary files: Cargo.lock (HEAD vs. heads/homu-tmp)
Auto-merging Cargo.lock
CONFLICT (content): Merge conflict in Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

flip1995 · 2019-02-11T19:43:35Z

Rebased on master and re-updated Clippy and RLS

rust-highfive · 2019-02-11T20:42:02Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0878cf58:start=1549915340247387183,finish=1549915348378965833,duration=8131578650
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
tidy check
[00:04:15] * 565 error codes
[00:04:15] * highest error code: E0722
[00:04:16] * 250 features
[00:04:16] crate `rustc-ap-syntax` is duplicated in `Cargo.lock`
[00:04:16]   * rustc-ap-syntax 306.0.0 (registry+https://github.com/rust-lang/crates.io-index)
[00:04:16]   * rustc-ap-syntax 366.0.0 (registry+https://github.com/rust-lang/crates.io-index)
[00:04:16] some tidy checks failed
[00:04:16] 
[00:04:16] 
[00:04:16] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:16] 
[00:04:16] 
[00:04:16] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:16] Build completed unsuccessfully in 0:00:46
[00:04:16] Build completed unsuccessfully in 0:00:46
[00:04:16] make: *** [tidy] Error 1
[00:04:16] Makefile:68: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:179edd0f
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Feb 11 20:07:01 UTC 2019
---
travis_time:end:1287e9b0:start=1549915622149608599,finish=1549915622154391600,duration=4783001
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0ef71388
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0c14a7a1
travis_time:start:0c14a7a1
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1153c736
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Manishearth · 2019-02-11T20:47:46Z

[00:04:16] crate `rustc-ap-syntax` is duplicated in `Cargo.lock`
[00:04:16]   * rustc-ap-syntax 306.0.0 (registry+https://github.com/rust-lang/crates.io-index)
[00:04:16]   * rustc-ap-syntax 366.0.0 (registry+https://github.com/rust-lang/crates.io-index)
[00:04:16] some tidy checks failed

flip1995 · 2019-02-11T21:45:21Z

Also an update of rustfmt was required. This supersedes #58356 now.

Xanewok · 2019-02-13T15:58:58Z

@flip1995 Could we bump RLS version to rust-lang/rls@6c0bbf5? This should still only pull v366 of rustc-ap-* crates but most importantly it also changes project layout to monorepo (pulling other rls-* crates) and while I tested it locally in Rust repo, I'd like to verify that this works as intended and doesn't break toolstate.

flip1995 · 2019-02-13T19:11:11Z

@Xanewok Done!

rust-highfive · 2019-02-13T21:13:38Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1baeb5fa:start=1550085801047903504,finish=1550085892411712199,duration=91363808695
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-tools
---
[00:02:08]   Downloaded log_settings v0.1.2
[00:02:08]   Downloaded chalk-engine v0.9.0
[00:02:08]   Downloaded phf v0.7.22
[00:02:08]   Downloaded rand_isaac v0.1.1
[00:02:08]   Downloaded argon2rs v0.2.5
[00:02:08]   Downloaded strum_macros v0.11.0
[00:02:08]   Downloaded rustc-rayon-core v0.1.1
[00:02:08]   Downloaded cargo_metadata v0.6.2
[00:02:08]   Downloaded log v0.4.6
---
[00:02:10]   Downloaded curl v0.4.19
[00:02:10]   Downloaded miniz_oxide v0.2.0
[00:02:10]   Downloaded phf_generator v0.7.22
[00:02:10]   Downloaded rand_core v0.2.2
[00:02:10]   Downloaded blake2-rfc v0.2.18
[00:02:10]   Downloaded itertools v0.8.0
[00:02:10]   Downloaded mdbook v0.2.3
[00:02:10]   Downloaded mio-named-pipes v0.1.6
[00:02:10]   Downloaded semver-parser v0.7.0
---
[00:02:11]   Downloaded tokio-current-thread v0.1.4
[00:02:11]   Downloaded rusty-fork v0.2.1
[00:02:11]   Downloaded pkg-config v0.3.14
[00:02:11]   Downloaded yaml-rust v0.3.5
[00:02:11]   Downloaded constant_time_eq v0.1.3
[00:02:11]   Downloaded futf v0.1.4
[00:02:11]   Downloaded toml-query v0.7.0
[00:02:11]   Downloaded futures v0.1.21
[00:02:11]   Downloaded pretty_assertions v0.5.1
---
[01:20:24] +For more information about this error, try `rustc --explain E0080`.
[01:20:24] +
[01:20:24] 
[01:20:24] The actual stderr differed from the expected stderr.
[01:20:24] Actual stderr saved to /tmp/compiletestyV5hCm/function_pointers.stderr
[01:20:24] To update references, run this command from build directory:
[01:20:24] tests/run-pass/update-references.sh '/tmp/compiletestyV5hCm' 'function_pointers.rs'
[01:20:24] error: 1 errors occurred comparing output.
[01:20:24] status: exit code: 1
[01:20:24] status: exit code: 1
[01:20:24] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "tests/run-pass/function_pointers.rs" "-L" "/tmp/compiletestyV5hCm" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/tmp/compiletestyV5hCm/function_pointers.stage-id" "-Dwarnings" "-Dunused" "--edition" "2018" "-L" "/tmp/compiletestyV5hCm/function_pointers.stage-id.aux" "-A" "unused"
[01:20:24] ------------------------------------------
[01:20:24] 
[01:20:24] ------------------------------------------
[01:20:24] stderr:
---
[01:20:24] Verifying status of rust-by-example...
[01:20:24] Verifying status of rls...
[01:20:24] This PR updated 'src/tools/rls', verifying if status is 'test-pass'...
[01:20:24] 
[01:20:24] ⚠️ We detected that this PR updated 'rls', but its tests failed.
[01:20:24] 
[01:20:24] If you do intend to update 'rls', please check the error messages above and
[01:20:24] commit another update.
[01:20:24] 
[01:20:24] If you do NOT intend to update 'rls', please ensure you did not accidentally
[01:20:24] change the submodule at 'src/tools/rls'. You may ask your reviewer for the
[01:20:24] proper steps.
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 3.
travis_time:start:00cf9952
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed Feb 13 20:45:25 UTC 2019
---
travis_time:end:0a7f31ba:start=1550090726265737334,finish=1550090726270452418,duration=4715084
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:13856273
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0b6f4342
travis_time:start:0b6f4342
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:03df3329
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Xanewok · 2019-02-13T21:54:24Z

error[E0277]: the trait bound `std::borrow::Cow<'_, str>: std::convert::From<core::str::EscapeDefault<'_>>` is not satisfiedprobe, termcolor, rustc-serialize, rustc-ap-syntax(build.rs), same-file, num-derive(build.rs), rayon-core(build.rs), hex, ansi...
   --> /home/xanewok/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-graphviz-366.0.0/lib.rs:542:44
    |
542 |                     (&*s).escape_default().into()
    |                                            ^^^^ the trait `std::convert::From<core::str::EscapeDefault<'_>>` is not implemented for `std::borrow::Cow<'_, str>`
    |
    = help: the following implementations were found:
              <std::borrow::Cow<'a, [T]> as std::convert::From<&'a [T]>>
              <std::borrow::Cow<'a, [T]> as std::convert::From<&'a std::vec::Vec<T>>>
              <std::borrow::Cow<'a, [T]> as std::convert::From<std::vec::Vec<T>>>
              <std::borrow::Cow<'a, std::ffi::CStr> as std::convert::From<&'a std::ffi::CStr>>
            and 11 others
    = note: required because of the requirements on the impl of `std::convert::Into<std::borrow::Cow<'_, str>>` for `core::str::EscapeDefault<'_>`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.

Well, this is unsettling. We need to do another coordinated rustc-ap-* bump to a version that has no more than 12 days it seems due to this change,

and it seems clippy doesn't compile:

[01:15:52] �[0m�[0m�[1m�[32m   Compiling�[0m clippy_lints v0.0.212 (/checkout/src/tools/clippy/clippy_lints)
[01:15:57] �[0m�[1m�[38;5;9merror[E0599]�[0m�[0m�[1m: no method named `node_id_to_type` found for type `&'a rustc::ty::TypeckTables<'tcx>` in the current scope�[0m
[01:15:57] �[0m   �[0m�[0m�[1m�[38;5;12m--> �[0m�[0msrc/tools/clippy/clippy_lints/src/utils/inspector.rs:130:65�[0m
[01:15:57] �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
[01:15:57] �[0m�[1m�[38;5;12m130�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                println!("local variable of type {}", cx.tables.node_id_to_type(local.hir_id));�[0m

flip1995 · 2019-02-13T22:04:19Z

and it seems clippy doesn't compile:

I fixed this in rust-lang/rust-clippy#3760. Just waiting for AppVeyor so it can get merged. This PR already points to the commit with the fix.

We need to do another coordinated rustc-ap-* bump

Is there anything I can do to help with that?

Xanewok · 2019-02-13T22:10:42Z

It actually seems we need v373 because it pulls exactly the commit we need: 0f949c2

Is there anything I can do to help with that?

Unfortunately I think we need those changes both in Racer and Rustfmt :(

flip1995 · 2019-02-18T09:34:41Z

Updated Cargo.lock again. Let's go for take 5 (or 6?)

Does the delegate still apply?

@bors r=Xanewok

bors · 2019-02-18T09:34:42Z

📌 Commit 4c228cc has been approved by Xanewok

@Manishearth

Update Clippy, RLS and rustfmt Update Clippy to rust-lang/rust-clippy@32ee306 Update RLS to rust-lang/rls@0d6f53e Update rustfmt to rust-lang/rustfmt@d6829d6 r? @Manishearth @oli-obk

bors · 2019-02-18T20:40:26Z

⌛ Testing commit 4c228cc with merge 2cea257a50a4657b058d79362e77121a08bc4f4c...

bors · 2019-02-18T22:03:39Z

💔 Test failed - status-appveyor

mati865 · 2019-02-18T22:44:22Z

Network issue:

fatal: Could not parse object '57250b2b8fa63934f80e5376a29f7dcb3f759ad6'.
From https://github.com/servo/webrender
 * branch            master     -> FETCH_HEAD
fatal: Could not parse object '57250b2b8fa63934f80e5376a29f7dcb3f759ad6'.
fatal: unable to access 'https://github.com/servo/webrender/': Could not resolve host: github.com
thread 'main' panicked at 'assertion failed: status.success()', src\tools\cargotest\main.rs:116:13

sfackler · 2019-02-19T01:00:48Z

@bors retry

bors · 2019-02-19T03:28:21Z

⌛ Testing commit 4c228cc with merge cf3747e92262a4b7bde2276ac9f8e5c9f00ebf10...

bors · 2019-02-19T04:44:53Z

💔 Test failed - status-appveyor

kennytm · 2019-02-19T07:19:21Z

@bors r-

Please update clippy.

[01:09:39] error[E0004]: non-exhaustive patterns: `Const { .. }` not covered
[01:09:39]    --> src\tools\clippy\clippy_lints\src\lifetimes.rs:114:61
[01:09:39]     |
[01:09:39] 114 |     let types = generics.params.iter().filter(|param| match param.kind {
[01:09:39]     |                                                             ^^^^^^^^^^ pattern `Const { .. }` not covered
[01:09:39] 
[01:09:39] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:39]    --> src\tools\clippy\clippy_lints\src\lifetimes.rs:134:79
[01:09:39]     |
[01:09:39] 134 |                     let lifetimes = params.args.iter().filter_map(|arg| match arg {
[01:09:39]     |                                                                               ^^^ pattern `&Const(_)` not covered
[01:09:39] 
[01:09:39] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:39]    --> src\tools\clippy\clippy_lints\src\lifetimes.rs:317:67
[01:09:39]     |
[01:09:39] 317 |                 && !last_path_segment.args.iter().any(|arg| match arg {
[01:09:39]     |                                                                   ^^^ pattern `&Const(_)` not covered
[01:09:39] 
[01:09:40] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:40]    --> src\tools\clippy\clippy_lints\src\needless_pass_by_value.rs:235:87
[01:09:40]     |
[01:09:40] 235 |                                 .map(|params| params.args.iter().find_map(|arg| match arg {
[01:09:40]     |                                                                                       ^^^ pattern `&Const(_)` not covered
[01:09:40] 
[01:09:40] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:40]    --> src\tools\clippy\clippy_lints\src\ptr.rs:236:82
[01:09:40]     |
[01:09:40] 236 |                     if let Some(inner) = params.args.iter().find_map(|arg| match arg {
[01:09:40]     |                                                                                  ^^^ pattern `&Const(_)` not covered
[01:09:40] 
[01:09:40] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:40]    --> src\tools\clippy\clippy_lints\src\transmute.rs:498:72
[01:09:40]     |
[01:09:40] 498 |         if let Some(to_ty) = params.args.iter().filter_map(|arg| match arg {
[01:09:40]     |                                                                        ^^^ pattern `&Const(_)` not covered
[01:09:40] 
[01:09:40] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:40]    --> src\tools\clippy\clippy_lints\src\types.rs:224:67
[01:09:40]     |
[01:09:40] 224 |         if let Some(ty) = params.args.iter().find_map(|arg| match arg {
[01:09:40]     |                                                                   ^^^ pattern `&Const(_)` not covered
[01:09:40] 
[01:09:40] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:40]    --> src\tools\clippy\clippy_lints\src\types.rs:268:81
[01:09:40]     |
[01:09:40] 268 |                         if let Some(ty) = last.args.iter().find_map(|arg| match arg {
[01:09:40]     |                                                                                 ^^^ pattern `&Const(_)` not covered
[01:09:40] 
[01:09:40] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:40]    --> src\tools\clippy\clippy_lints\src\types.rs:279:87
[01:09:40]     |
[01:09:40] 279 |                         if let Some(boxed_ty) = last.args.iter().find_map(|arg| match arg {
[01:09:40]     |                                                                                       ^^^ pattern `&Const(_)` not covered
[01:09:40] 
[01:09:40] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:40]    --> src\tools\clippy\clippy_lints\src\types.rs:328:53
[01:09:40]     |
[01:09:40] 328 |                             .filter_map(|arg| match arg {
[01:09:40]     |                                                     ^^^ pattern `&Const(_)` not covered
[01:09:40] 
[01:09:40] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:40]    --> src\tools\clippy\clippy_lints\src\types.rs:341:53
[01:09:40]     |
[01:09:40] 341 |                             .filter_map(|arg| match arg {
[01:09:40]     |                                                     ^^^ pattern `&Const(_)` not covered
[01:09:40] 
[01:09:40] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:40]    --> src\tools\clippy\clippy_lints\src\types.rs:352:77
[01:09:40]     |
[01:09:40] 352 |                         for ty in params.args.iter().filter_map(|arg| match arg {
[01:09:40]     |                                                                             ^^^ pattern `&Const(_)` not covered
[01:09:40] 
[01:09:40] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:40]    --> src\tools\clippy\clippy_lints\src\types.rs:388:78
[01:09:40]     |
[01:09:40] 388 |                 if let Some(inner) = params.args.iter().find_map(|arg| match arg {
[01:09:40]     |                                                                              ^^^ pattern `&Const(_)` not covered
[01:09:40] 
[01:09:40] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:40]     --> src\tools\clippy\clippy_lints\src\types.rs:2139:41
[01:09:40]      |
[01:09:40] 2139 |                 .filter_map(|arg| match arg {
[01:09:40]      |                                         ^^^ pattern `&Const(_)` not covered
[01:09:40] 
[01:09:40] error[E0004]: non-exhaustive patterns: `&Const(_)` not covered
[01:09:40]    --> src\tools\clippy\clippy_lints\src\use_self.rs:182:82
[01:09:40]     |
[01:09:40] 182 |                     !params.parenthesized && !params.args.iter().any(|arg| match arg {
[01:09:40]     |                                                                                  ^^^ pattern `&Const(_)` not covered

Manishearth · 2019-02-19T07:35:48Z

rust-lang/rust-clippy#3786

Manishearth · 2019-02-19T08:30:36Z

Moving this to #58571 since I don't want to wait for more things to break

Update clippy, RLS, and rustfmt moved from #58337

rust-highfive assigned Manishearth Feb 10, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2019

flip1995 mentioned this pull request Feb 10, 2019

clippy and rls components are not available since nightly-2019-02-09 rust-lang/rust-clippy#3749

Closed

mati865 mentioned this pull request Feb 11, 2019

rustup: rls cannot be downloaded for nightly #57771

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 11, 2019

flip1995 force-pushed the clippyup branch from 4613e4b to c3b2557 Compare February 11, 2019 19:41

flip1995 force-pushed the clippyup branch from c3b2557 to 67e393d Compare February 11, 2019 20:00

flip1995 force-pushed the clippyup branch from 67e393d to 9557fb7 Compare February 11, 2019 21:44

flip1995 changed the title ~~Update Clippy and RLS~~ Update Clippy, RLS and rustfmt Feb 11, 2019

flip1995 force-pushed the clippyup branch 2 times, most recently from 0330d9b to b95fbff Compare February 13, 2019 19:10

flip1995 force-pushed the clippyup branch from b95fbff to 5ecd14b Compare February 13, 2019 21:20

flip1995 force-pushed the clippyup branch from ba59d28 to 4c228cc Compare February 18, 2019 09:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 18, 2019

kennytm mentioned this pull request Feb 18, 2019

Rollup of 16 pull requests #58559

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 18, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 19, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2019

Manishearth mentioned this pull request Feb 19, 2019

Update clippy, RLS, and rustfmt #58571

Merged

Manishearth closed this Feb 19, 2019

bors added a commit that referenced this pull request Feb 19, 2019

Auto merge of #58571 - Manishearth:rustup, r=Manishearth

4d66b7b

Update clippy, RLS, and rustfmt moved from #58337

Manishearth mentioned this pull request Feb 22, 2019

No RLS in nightlies in weeks rust-lang/rls#1321

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Clippy, RLS and rustfmt #58337

Update Clippy, RLS and rustfmt #58337

flip1995 commented Feb 10, 2019 •

edited

rust-highfive commented Feb 10, 2019

rust-highfive commented Feb 10, 2019

oli-obk commented Feb 11, 2019

bors commented Feb 11, 2019

bors commented Feb 11, 2019

flip1995 commented Feb 11, 2019

rust-highfive commented Feb 11, 2019

Manishearth commented Feb 11, 2019

flip1995 commented Feb 11, 2019

Xanewok commented Feb 13, 2019

flip1995 commented Feb 13, 2019

rust-highfive commented Feb 13, 2019

Xanewok commented Feb 13, 2019

flip1995 commented Feb 13, 2019

Xanewok commented Feb 13, 2019

flip1995 commented Feb 18, 2019

bors commented Feb 18, 2019

bors commented Feb 18, 2019

bors commented Feb 18, 2019

mati865 commented Feb 18, 2019

sfackler commented Feb 19, 2019

bors commented Feb 19, 2019

bors commented Feb 19, 2019

kennytm commented Feb 19, 2019

Manishearth commented Feb 19, 2019

Manishearth commented Feb 19, 2019

Update Clippy, RLS and rustfmt #58337

Update Clippy, RLS and rustfmt #58337

Conversation

flip1995 commented Feb 10, 2019 • edited

rust-highfive commented Feb 10, 2019

rust-highfive commented Feb 10, 2019

oli-obk commented Feb 11, 2019

bors commented Feb 11, 2019

bors commented Feb 11, 2019

flip1995 commented Feb 11, 2019

rust-highfive commented Feb 11, 2019

Manishearth commented Feb 11, 2019

flip1995 commented Feb 11, 2019

Xanewok commented Feb 13, 2019

flip1995 commented Feb 13, 2019

rust-highfive commented Feb 13, 2019

Xanewok commented Feb 13, 2019

flip1995 commented Feb 13, 2019

Xanewok commented Feb 13, 2019

flip1995 commented Feb 18, 2019

bors commented Feb 18, 2019

bors commented Feb 18, 2019

bors commented Feb 18, 2019

mati865 commented Feb 18, 2019

sfackler commented Feb 19, 2019

bors commented Feb 19, 2019

bors commented Feb 19, 2019

kennytm commented Feb 19, 2019

Manishearth commented Feb 19, 2019

Manishearth commented Feb 19, 2019

flip1995 commented Feb 10, 2019 •

edited