New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variant/struct field search tab #58364

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Feb 10, 2019

Fixes #58229.

screenshot 2019-02-10 at 00 05 27

I'm just wondering if it's really useful though. Any other opinions would be very appreciated!

r? @QuietMisdreavus

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Feb 18, 2019

At some point (when we get many of these), we should probably not make it a tab, but a dropdown menu

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Feb 18, 2019

I'm open to any suggestions. :)

@QuietMisdreavus

This comment has been minimized.

Copy link
Member

QuietMisdreavus commented Feb 18, 2019

Is this searching for types being used in structs/variants, or for the names of the field/variant? If it's the latter, this tab is not useful - it's duplicating a subset of the first tab. I'm not familiar with how the search code looks at the index, and your screenshot makes it look like it's searching through names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment