MaybeUninit: add read_initialized, add examples #58660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aidanhs (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Closed
3 tasks
Also remove a no-longer accurate comments
RalfJung
force-pushed
the
maybe-uninit
branch
2 times, most recently
from
b136922
to
48bba2c
Compare
RalfJung
force-pushed
the
maybe-uninit
branch
from
48bba2c
to
aa4a9b0
Compare
Centril
reviewed
Feb 22, 2019
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
I've been thinking maybe it should be called OTOH, |
Co-Authored-By: RalfJung <post@ralfj.de>
|
I think I'm really happy about the |
|
I always thought of these as To me, |
|
Yeah, my current inclination is to instead rename |
|
Well, let's do the bikeshedding later and add this as |
|
r? @Centril |
Centril
reviewed
Mar 5, 2019
| // FIXME before stabilizing, explain how to initialize a struct field-by-field. | ||
| #[allow(missing_debug_implementations)] | ||
| #[unstable(feature = "maybe_uninit", issue = "53491")] | ||
| // NOTE after stabilizing `MaybeUninit` proceed to deprecate `mem::{uninitialized,zeroed}` | ||
| #[derive(Copy)] |
There was a problem hiding this comment.
Can you remind me... what was the reason we didn't do this before?
There was a problem hiding this comment.
I don't think there was one.
Co-Authored-By: RalfJung <post@ralfj.de>
|
r=me with green CI :) |
RalfJung
commented
Mar 6, 2019
|
@bors r=Centril |
|
📌 Commit cefe9b0 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 50, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2019
MaybeUninit: add read_initialized, add examples This adds a new `read_initialized` method, similar to suggestions by @Amanieu and @shepmaster. I also added examples to this and other methods.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2019
MaybeUninit: add read_initialized, add examples This adds a new `read_initialized` method, similar to suggestions by @Amanieu and @shepmaster. I also added examples to this and other methods.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2019
MaybeUninit: add read_initialized, add examples This adds a new `read_initialized` method, similar to suggestions by @Amanieu and @shepmaster. I also added examples to this and other methods.
bors
added a commit
that referenced
this pull request
Mar 9, 2019
Rollup of 13 pull requests Successful merges: - #58518 (Use early unwraps instead of bubbling up errors just to unwrap in the end) - #58626 (rustdoc: add option to calculate "documentation coverage") - #58629 (rust-lldb: fix crash when printing empty string) - #58660 (MaybeUninit: add read_initialized, add examples) - #58670 (fixes #52482) - #58676 (look for python2 symlinks before bootstrap python) - #58679 (Refactor passes and pass execution to be more parallel) - #58750 (Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const) - #58762 (Mention `unwind(aborts)` in diagnostics for `#[unwind]`) - #58924 (Add as_slice() to slice::IterMut and vec::Drain) - #58990 (Actually publish miri in the manifest) - #59018 (std: Delete a by-definition spuriously failing test) - #59045 (Expose new_sub_parser_from_file) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
read_initializedmethod, similar to suggestions by @Amanieu and @shepmaster. I also added examples to this and other methods.