Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ExactSizeIterator for ToLowercase and ToUppercase #58778

Merged
merged 3 commits into from Mar 19, 2019

Conversation

Projects
None yet
8 participants
@xfix
Copy link
Contributor

commented Feb 27, 2019

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2019

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@xfix xfix force-pushed the xfix:exact_size_case_mapping_iter branch from fe9ed7f to 7b4e267 Feb 27, 2019

@xfix xfix force-pushed the xfix:exact_size_case_mapping_iter branch from 7b4e267 to 988b3d5 Feb 27, 2019

Show resolved Hide resolved src/libcore/tests/char.rs Outdated
@Centril

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

@rust-highfive rust-highfive assigned SimonSapin and unassigned kennytm Feb 27, 2019

Remove copy paste error in char tests
Co-Authored-By: xfix <konrad@borowski.pw>
@Dylan-DPC

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

ping from triage can anyone from @rust-lang/libs review this?

@SimonSapin

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

Looks good, thanks!

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

📌 Commit 911a633 has been approved by SimonSapin

@Centril Centril added this to the 1.35 milestone Mar 18, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

⌛️ Testing commit 911a633 with merge 3fa9e36...

bors added a commit that referenced this pull request Mar 19, 2019

Auto merge of #58778 - xfix:exact_size_case_mapping_iter, r=SimonSapin
Implement ExactSizeIterator for ToLowercase and ToUppercase
Update since annotation for ExactSizeIterator for ToUppercase/Lowercase
This functionality was added in 1.35.0, not 1.34.0.

@xfix xfix force-pushed the xfix:exact_size_case_mapping_iter branch from 86cc560 to 8f261a6 Mar 19, 2019

@kennytm

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

r? @SimonSapin needs reapproval after force-push.

BTW does this PR still "needs-fcp"?

@SimonSapin

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

We usually do FCP when adding new stable APIs. But in this case I’m gonna unilaterally declare this obvious enough. CC @rust-lang/libs

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

📌 Commit 8f261a6 has been approved by SimonSapin

Centril added a commit to Centril/rust that referenced this pull request Mar 19, 2019

Rollup merge of rust-lang#58778 - xfix:exact_size_case_mapping_iter, …
…r=SimonSapin

Implement ExactSizeIterator for ToLowercase and ToUppercase

bors added a commit that referenced this pull request Mar 19, 2019

Auto merge of #59293 - Centril:rollup, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #56348 (Add todo!() macro)
 - #57729 (extra testing of how NLL handles wildcard type `_`)
 - #57847 (dbg!() without parameters)
 - #58778 (Implement ExactSizeIterator for ToLowercase and ToUppercase)
 - #58812 (Clarify distinction between floor() and trunc())
 - #58939 (Fix a tiny error in documentation of std::pin.)
 - #59116 (Be more discerning on when to attempt suggesting a comma in a macro invocation)
 - #59252 (add self to mailmap)
 - #59275 (Replaced self-reflective explicit types with clearer `Self` or `Self::…` in stdlib docs)
 - #59280 (Stabilize refcell_map_split feature)
 - #59290 (Run branch cleanup after copy prop)

Failed merges:

r? @ghost

@bors bors merged commit 8f261a6 into rust-lang:master Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.