Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Read bounds on a bunch of BufReader<R> methods #58423

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
8 participants
@nox
Copy link
Contributor

nox commented Feb 13, 2019

No description provided.

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Feb 13, 2019

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 22, 2019

@rust-highfive rust-highfive assigned dtolnay and unassigned aidanhs Feb 22, 2019

@dtolnay dtolnay added the T-libs label Feb 23, 2019

@dtolnay

This comment has been minimized.

Copy link
Member

dtolnay commented Feb 23, 2019

@rfcbot fcp merge

Stable methods:

  impl<R> BufReader<R>
- where
-     R: Read,
  {
      pub fn get_ref(&self) -> &R { &self.inner }
      pub fn get_mut(&mut self) -> &mut R { &mut self.inner }
      pub fn into_inner(self) -> R { self.inner }
  }

Unstable methods (#45323):

  impl<R> BufReader<R>
- where
-     R: Read,
  {
      pub fn buffer(&self) -> &[u8] { &self.buf[self.pos..self.cap] }
  }
@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 23, 2019

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 23, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@Dylan-DPC

This comment has been minimized.

Copy link
Member

Dylan-DPC commented Mar 4, 2019

ping from triage @dtolnay any updates?

@dtolnay

This comment has been minimized.

Copy link
Member

dtolnay commented Mar 4, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 4, 2019

📌 Commit 95840b3 has been approved by dtolnay

bors added a commit that referenced this pull request Mar 5, 2019

Auto merge of #58423 - nox:relax-bounds-buf-reader, r=dtolnay
Relax Read bounds on a bunch of BufReader<R> methods
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 5, 2019

⌛️ Testing commit 95840b3 with merge f22dca0...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 5, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: dtolnay
Pushing f22dca0 to master...

@bors bors added the merged-by-bors label Mar 5, 2019

@bors bors merged commit 95840b3 into rust-lang:master Mar 5, 2019

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.