New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD armv6 and armv7 targets #58080

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@MikaelUrankar
Copy link

MikaelUrankar commented Feb 2, 2019

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 2, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@MikaelUrankar

This comment has been minimized.

Copy link
Author

MikaelUrankar commented Feb 12, 2019

Anyone?

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 12, 2019

r? @nagisa

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Feb 12, 2019

@bors r+

LGTM, thanks!

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 12, 2019

📌 Commit 6d85669 has been approved by nagisa

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 13, 2019

Failed in rollup (#58412 (comment)) due to 2018 changes, @bors r-

@MikaelUrankar MikaelUrankar force-pushed the MikaelUrankar:freebsd_arm branch from 6d85669 to adddee4 Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment