Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and clean up several parts of CONTRIBUTING.md #59172

Merged
merged 8 commits into from Mar 23, 2019

Conversation

Projects
None yet
7 participants
@varkor
Copy link
Member

varkor commented Mar 14, 2019

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Mar 14, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Mar 14, 2019

@TimNN

This comment has been minimized.

Copy link
Contributor

TimNN commented Mar 19, 2019

Ping from triage @steveklabnik: This PR requires you review.

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Mar 19, 2019

Thanks for this!

@bors: r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 19, 2019

📌 Commit 037596c has been approved by steveklabnik

Centril added a commit to Centril/rust that referenced this pull request Mar 19, 2019

Rollup merge of rust-lang#59172 - varkor:contributing-contributions, …
…r=steveklabnik

Update and clean up several parts of CONTRIBUTING.md

bors added a commit that referenced this pull request Mar 20, 2019

Auto merge of #59300 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #58902 (Fixes for the generator transform)
 - #58913 (Add new test case for possible bug in BufReader)
 - #58927 (Add default keyword handling in rustdoc)
 - #58995 (Refactor tools/build-mainfest)
 - #59172 (Update and clean up several parts of CONTRIBUTING.md)
 - #59239 (Remove inline assembly from hint::spin_loop)
 - #59251 (Use a valid name for graphviz graphs)
 - #59256 (Make meta-item API compatible with `LocalInternedString::get` soundness fix)
 - #59266 (Do not complain about non-existing fields after parse recovery)
 - #59296 (Do not encode gensymed imports in metadata)

Failed merges:

r? @ghost

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 22, 2019

Rollup merge of rust-lang#59172 - varkor:contributing-contributions, …
…r=steveklabnik

Update and clean up several parts of CONTRIBUTING.md

Centril added a commit to Centril/rust that referenced this pull request Mar 22, 2019

Rollup merge of rust-lang#59172 - varkor:contributing-contributions, …
…r=steveklabnik

Update and clean up several parts of CONTRIBUTING.md

bors added a commit that referenced this pull request Mar 22, 2019

Auto merge of #59370 - Centril:rollup, r=Centril
Rollup of 18 pull requests

Successful merges:

 - #59106 (Add peer_addr function to UdpSocket)
 - #59170 (Add const generics to rustdoc)
 - #59172 (Update and clean up several parts of CONTRIBUTING.md)
 - #59190 (consistent naming for Rhs type parameter in libcore/ops)
 - #59236 (Rename miri component to miri-preview)
 - #59266 (Do not complain about non-existing fields after parse recovery)
 - #59273 (some small HIR doc improvements)
 - #59291 (Make Option<ThreadId> no larger than ThreadId, with NonZeroU64)
 - #59297 (convert field/method confusion help to suggestions)
 - #59304 (Move some bench tests back from libtest)
 - #59309 (Add messages for different verbosity levels. Output copy actions.)
 - #59321 (Unify E0109, E0110 and E0111)
 - #59322 (Tweak incorrect escaped char diagnostic)
 - #59323 (use suggestions for "enum instead of variant" error)
 - #59327 (Add NAN test to docs)
 - #59329 (cleanup: Remove compile-fail-fulldeps directory again)
 - #59347 (Move one test from run-make-fulldeps to ui)
 - #59360 (Add tracking issue number for `seek_convenience`)

Failed merges:

r? @ghost

@bors bors merged commit 037596c into rust-lang:master Mar 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.