Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make meta-item API compatible with `LocalInternedString::get` soundness fix #59256

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Projects
None yet
5 participants
@petrochenkov
Copy link
Contributor

commented Mar 17, 2019

r? @Zoxc

@Zoxc

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

The rest of the changes look good to me.

@Zoxc

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

📌 Commit db74efc has been approved by Zoxc

Centril added a commit to Centril/rust that referenced this pull request Mar 19, 2019

Rollup merge of rust-lang#59256 - petrochenkov:derval2, r=Zoxc
Make meta-item API compatible with `LocalInternedString::get` soundness fix

r? @Zoxc
@mati865

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Smells like broken Clippy (again) 😄

bors added a commit that referenced this pull request Mar 20, 2019

Auto merge of #59300 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #58902 (Fixes for the generator transform)
 - #58913 (Add new test case for possible bug in BufReader)
 - #58927 (Add default keyword handling in rustdoc)
 - #58995 (Refactor tools/build-mainfest)
 - #59172 (Update and clean up several parts of CONTRIBUTING.md)
 - #59239 (Remove inline assembly from hint::spin_loop)
 - #59251 (Use a valid name for graphviz graphs)
 - #59256 (Make meta-item API compatible with `LocalInternedString::get` soundness fix)
 - #59266 (Do not complain about non-existing fields after parse recovery)
 - #59296 (Do not encode gensymed imports in metadata)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

⌛️ Testing commit db74efc with merge d91b32b...

bors added a commit that referenced this pull request Mar 25, 2019

Auto merge of #59256 - petrochenkov:derval2, r=Zoxc
Make meta-item API compatible with `LocalInternedString::get` soundness fix

r? @Zoxc
@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Zoxc
Pushing d91b32b to master...

@bors bors added the merged-by-bors label Mar 25, 2019

@bors bors merged commit db74efc into rust-lang:master Mar 25, 2019

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.