Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursion #59539

Merged
merged 1 commit into from Mar 30, 2019

Conversation

Projects
None yet
4 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Mar 29, 2019

Temporary fix for #59502.

r? @eddyb

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Mar 29, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:05f96b9e:start=1553900359729395407,finish=1553900360960514042,duration=1231118635
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---

[00:03:45] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:45] tidy error: /checkout/src/librustdoc/clean/mod.rs:1773: TODO is deprecated; use FIXME
[00:03:47] some tidy checks failed
[00:03:47] 
[00:03:47] 
[00:03:47] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:47] 
[00:03:47] 
[00:03:47] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:47] Build completed unsuccessfully in 0:00:46
[00:03:47] Build completed unsuccessfully in 0:00:46
[00:03:47] Makefile:67: recipe for target 'tidy' failed
[00:03:47] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:00997424
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Mar 29 23:03:19 UTC 2019
---
travis_time:end:01098cd0:start=1553900601239204546,finish=1553900601244590314,duration=5385768
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0cf87cba
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1a99ae64
travis_time:start:1a99ae64
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:12b2ec56
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eddyb

This comment has been minimized.

Copy link
Member

eddyb commented Mar 30, 2019

r=me with tidy fixed

@bors p=1 (unbreaks rustfmt)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Mar 30, 2019

@bors: r=eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 30, 2019

📌 Commit 29885ff has been approved by eddyb

Centril added a commit to Centril/rust that referenced this pull request Mar 30, 2019

Rollup merge of rust-lang#59539 - GuillaumeGomez:rustdoc-infinite-rec…
…ursion, r=eddyb

Fix infinite recursion

Temporary fix for rust-lang#59502.

r? @eddyb

bors added a commit that referenced this pull request Mar 30, 2019

Auto merge of #59561 - Centril:rollup, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #59343 (rustc(codegen): uncache `def_symbol_name` prefix from `symbol_name`.)
 - #59380 (Fix invalid DWARF for enums when using ThinLTO)
 - #59463 (skip dyn keyword lint under macros)
 - #59539 (Fix infinite recursion)
 - #59544 (manifest: only include miri on the nightly channel)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 30, 2019

⌛️ Testing commit 29885ff with merge fc8581d...

@bors bors merged commit 29885ff into rust-lang:master Mar 30, 2019

1 check was pending

homu Testing commit 29885ff2915665f1e5b53c6c21609a12812bf29e with merge fc8581d7420b63b2cc5eac1c57a40de785859448...
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:rustdoc-infinite-recursion branch Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.