Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve worst-case performance of HashSet.is_subset #59665

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
4 participants
@ssomers
Copy link
Contributor

commented Apr 3, 2019

One more simple optimization opportunity for HashSet that was applied in BTreeSet in #59186 (and wasn't in #57043). Already covered by the existing unit test.

r? @KodrAus

@KodrAus

KodrAus approved these changes Apr 5, 2019

Copy link
Contributor

left a comment

Looks good to me!

@KodrAus

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

📌 Commit 5b8bfe0 has been approved by KodrAus

Centril added a commit to Centril/rust that referenced this pull request Apr 5, 2019

Rollup merge of rust-lang#59665 - ssomers:hashset_revisited, r=KodrAus
improve worst-case performance of HashSet.is_subset

One more simple optimization opportunity for HashSet that was applied in BTreeSet in rust-lang#59186 (and wasn't in rust-lang#57043). Already covered by the existing unit test.

r? @KodrAus

@Centril Centril referenced this pull request Apr 5, 2019

Merged

Rollup of 5 pull requests #59721

bors added a commit that referenced this pull request Apr 5, 2019

Auto merge of #59721 - Centril:rollup-ieam9ke, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #59665 (improve worst-case performance of HashSet.is_subset)
 - #59687 (cleanup shebang handling in the lexer)
 - #59690 (Mark unix::ffi::OsStrExt methods as inline)
 - #59702 (Use declare_lint_pass! and impl_lint_pass! in more places)
 - #59712 (wasm32: Default to a "static" relocation model)

Failed merges:

r? @ghost

@bors bors merged commit 5b8bfe0 into rust-lang:master Apr 5, 2019

@ssomers ssomers deleted the ssomers:hashset_revisited branch Apr 6, 2019

Amanieu added a commit to rust-lang/hashbrown that referenced this pull request Apr 12, 2019

bors bot added a commit to rust-lang/hashbrown that referenced this pull request Apr 12, 2019

Merge #61 #62
61: Improve worst-case performance of HashSet.is_subset r=Amanieu a=Amanieu

Ported from rust-lang/rust#59665

62: Remove incorrect debug_assert r=Amanieu a=Amanieu

Fixes #60 

Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>

bors bot added a commit to rust-lang/hashbrown that referenced this pull request Apr 13, 2019

Merge #61
61: Improve worst-case performance of HashSet.is_subset r=Amanieu a=Amanieu

Ported from rust-lang/rust#59665

Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>

bors bot added a commit to rust-lang/hashbrown that referenced this pull request Apr 13, 2019

Merge #61
61: Improve worst-case performance of HashSet.is_subset r=Amanieu a=Amanieu

Ported from rust-lang/rust#59665

Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>

bors bot added a commit to rust-lang/hashbrown that referenced this pull request Apr 13, 2019

Merge #61
61: Improve worst-case performance of HashSet.is_subset r=Amanieu a=Amanieu

Ported from rust-lang/rust#59665

Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.