Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfix coverage: Skip UI tests with non-json error-format #59677

Merged

Conversation

@phansch
Copy link
Member

@phansch phansch commented Apr 3, 2019

When using the rustfix-coverage flag, some tests currently fail
because they define a different error-format than json.

The current implementation crashes when encountering those tests. Since
we don't care about non-json test output when collecting the coverage
data, we handle those tests by returning an empty Vec instead.

r? @oli-obk

When using the `rustfix-coverage` flag, some tests currently fail
because they define a different error-format than `json`.

The current implementation crashes when encountering those tests. Since
we don't care about non-json test output when collecting the coverage
data, we handle those tests by returning an empty `Vec` instead.
@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Apr 3, 2019

@bors r+ rollup

@bors
Copy link
Contributor

@bors bors commented Apr 3, 2019

📌 Commit da99f46 has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this issue Apr 3, 2019
…er_error_formats, r=oli-obk

rustfix coverage: Skip UI tests with non-json error-format

When using the `rustfix-coverage` flag, some tests currently fail
because they define a different error-format than `json`.

The current implementation crashes when encountering those tests. Since
we don't care about non-json test output when collecting the coverage
data, we handle those tests by returning an empty `Vec` instead.

r? @oli-obk
bors added a commit that referenced this issue Apr 3, 2019
Rollup of 8 pull requests

Successful merges:

 - #59316 (Internal lints take 2)
 - #59663 (Be more direct about borrow contract)
 - #59664 (Updated the documentation of spin_loop and spin_loop_hint)
 - #59666 (Updated the environment description in rustc.)
 - #59669 (Reduce repetition in librustc(_lint) wrt. impl LintPass by using macros)
 - #59672 (Revert rust-lld place changes)
 - #59676 (std: Avoid usage of `Once` in `Instant`)
 - #59677 (rustfix coverage: Skip UI tests with non-json error-format)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this issue Apr 3, 2019
…er_error_formats, r=oli-obk

rustfix coverage: Skip UI tests with non-json error-format

When using the `rustfix-coverage` flag, some tests currently fail
because they define a different error-format than `json`.

The current implementation crashes when encountering those tests. Since
we don't care about non-json test output when collecting the coverage
data, we handle those tests by returning an empty `Vec` instead.

r? @oli-obk
bors added a commit that referenced this issue Apr 4, 2019
Rollup of 6 pull requests

Successful merges:

 - #59316 (Internal lints take 2)
 - #59663 (Be more direct about borrow contract)
 - #59664 (Updated the documentation of spin_loop and spin_loop_hint)
 - #59666 (Updated the environment description in rustc.)
 - #59669 (Reduce repetition in librustc(_lint) wrt. impl LintPass by using macros)
 - #59677 (rustfix coverage: Skip UI tests with non-json error-format)

Failed merges:

r? @ghost
@bors bors merged commit da99f46 into rust-lang:master Apr 4, 2019
1 check passed
1 check passed
@travis-ci[bot]
Travis CI - Pull Request Build Passed
Details
@phansch phansch deleted the rustfix_coverage_handle_other_error_formats branch Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants