Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfix coverage: Skip UI tests with non-json error-format #59677

Merged

Conversation

Projects
None yet
4 participants
@phansch
Copy link
Contributor

commented Apr 3, 2019

When using the rustfix-coverage flag, some tests currently fail
because they define a different error-format than json.

The current implementation crashes when encountering those tests. Since
we don't care about non-json test output when collecting the coverage
data, we handle those tests by returning an empty Vec instead.

r? @oli-obk

rustfix coverage: Skip UI tests with non-json error-format
When using the `rustfix-coverage` flag, some tests currently fail
because they define a different error-format than `json`.

The current implementation crashes when encountering those tests. Since
we don't care about non-json test output when collecting the coverage
data, we handle those tests by returning an empty `Vec` instead.
@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

📌 Commit da99f46 has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Apr 3, 2019

Rollup merge of rust-lang#59677 - phansch:rustfix_coverage_handle_oth…
…er_error_formats, r=oli-obk

rustfix coverage: Skip UI tests with non-json error-format

When using the `rustfix-coverage` flag, some tests currently fail
because they define a different error-format than `json`.

The current implementation crashes when encountering those tests. Since
we don't care about non-json test output when collecting the coverage
data, we handle those tests by returning an empty `Vec` instead.

r? @oli-obk

@Centril Centril referenced this pull request Apr 3, 2019

Closed

Rollup of 8 pull requests #59682

bors added a commit that referenced this pull request Apr 3, 2019

Auto merge of #59682 - Centril:rollup-ncm5ojo, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #59316 (Internal lints take 2)
 - #59663 (Be more direct about borrow contract)
 - #59664 (Updated the documentation of spin_loop and spin_loop_hint)
 - #59666 (Updated the environment description in rustc.)
 - #59669 (Reduce repetition in librustc(_lint) wrt. impl LintPass by using macros)
 - #59672 (Revert rust-lld place changes)
 - #59676 (std: Avoid usage of `Once` in `Instant`)
 - #59677 (rustfix coverage: Skip UI tests with non-json error-format)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Apr 3, 2019

Rollup merge of rust-lang#59677 - phansch:rustfix_coverage_handle_oth…
…er_error_formats, r=oli-obk

rustfix coverage: Skip UI tests with non-json error-format

When using the `rustfix-coverage` flag, some tests currently fail
because they define a different error-format than `json`.

The current implementation crashes when encountering those tests. Since
we don't care about non-json test output when collecting the coverage
data, we handle those tests by returning an empty `Vec` instead.

r? @oli-obk

@Centril Centril referenced this pull request Apr 3, 2019

Merged

Rollup of 6 pull requests #59684

bors added a commit that referenced this pull request Apr 4, 2019

Auto merge of #59684 - Centril:rollup-n7pnare, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #59316 (Internal lints take 2)
 - #59663 (Be more direct about borrow contract)
 - #59664 (Updated the documentation of spin_loop and spin_loop_hint)
 - #59666 (Updated the environment description in rustc.)
 - #59669 (Reduce repetition in librustc(_lint) wrt. impl LintPass by using macros)
 - #59677 (rustfix coverage: Skip UI tests with non-json error-format)

Failed merges:

r? @ghost

@bors bors merged commit da99f46 into rust-lang:master Apr 4, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@phansch phansch deleted the phansch:rustfix_coverage_handle_other_error_formats branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.