Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miri: unsized locals and by-value dyn traits #59780

Merged
merged 7 commits into from Apr 11, 2019

Conversation

Projects
None yet
6 participants
@RalfJung
Copy link
Member

commented Apr 7, 2019

r? @oli-obk
Cc @eddyb

Fixes rust-lang/miri#449

@oli-obk

oli-obk approved these changes Apr 8, 2019

Show resolved Hide resolved src/librustc_mir/interpret/place.rs Outdated

RalfJung added some commits Apr 8, 2019

Apply suggestions from code review
typos

Co-Authored-By: RalfJung <post@ralfj.de>
@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

📌 Commit 4d79d39 has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Apr 8, 2019

Rollup merge of rust-lang#59780 - RalfJung:miri-unsized, r=oli-obk
Miri: unsized locals and by-value dyn traits

r? @oli-obk
Cc @eddyb

Fixes rust-lang/miri#449

@Centril Centril referenced this pull request Apr 8, 2019

Closed

Rollup of 6 pull requests #59801

bors added a commit that referenced this pull request Apr 8, 2019

Auto merge of #59801 - Centril:rollup-0c3lsz3, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #58972 (rustdoc: don't process `Crate::external_traits` when collecting intra-doc links)
 - #59708 (Mark variables captured by reference as mutable correctly)
 - #59735 (remove lookup_char_pos_adj)
 - #59752 (Limit dylib symbols)
 - #59779 (Uplift `get_def_path` from Clippy)
 - #59780 (Miri: unsized locals and by-value dyn traits)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Apr 9, 2019

Auto merge of #59801 - Centril:rollup-0c3lsz3, r=Manishearth
Rollup of 6 pull requests

Successful merges:

 - #58972 (rustdoc: don't process `Crate::external_traits` when collecting intra-doc links)
 - #59708 (Mark variables captured by reference as mutable correctly)
 - #59735 (remove lookup_char_pos_adj)
 - #59752 (Limit dylib symbols)
 - #59779 (Uplift `get_def_path` from Clippy)
 - #59780 (Miri: unsized locals and by-value dyn traits)

Failed merges:

r? @ghost
@RalfJung

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

@bors p=1 needed to make Miri work again

Miri's toolstate is green but that is a bug.

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

⌛️ Testing commit 4d79d39 with merge 3de0106...

bors added a commit that referenced this pull request Apr 11, 2019

Auto merge of #59780 - RalfJung:miri-unsized, r=oli-obk
Miri: unsized locals and by-value dyn traits

r? @oli-obk
Cc @eddyb

Fixes rust-lang/miri#449
// We have to implement all "object safe receivers". Currently we
// support built-in pointers (&, &mut, Box) as well as unsized-self. We do
// not yet support custom self types.
// Also see librustc_codegen_llvm/abi.rs and librustc_codegen_llvm/mir/block.rs.

This comment has been minimized.

Copy link
@eddyb

eddyb Apr 11, 2019

Member

These paths may be outdated.

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 3de0106 to master...

@bors bors added the merged-by-bors label Apr 11, 2019

@bors bors merged commit 4d79d39 into rust-lang:master Apr 11, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

📣 Toolstate changed by #59780!

Tested on commit 3de0106.
Direct link to PR: #59780

💔 miri on windows: test-pass → test-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
💔 miri on linux: test-pass → test-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 11, 2019

📣 Toolstate changed by rust-lang/rust#59780!
Tested on commit rust-lang/rust@3de0106.
Direct link to PR: <rust-lang/rust#59780>

💔 miri on windows: test-pass → test-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
💔 miri on linux: test-pass → test-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.