Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Remove default keyword from re-exported trait methods #59978

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
5 participants
@ollie27
Copy link
Contributor

commented Apr 14, 2019

Fixes #59977

r? @QuietMisdreavus

As this fixes a stable to beta regression, could it be backported?

@QuietMisdreavus
Copy link
Member

left a comment

Nice catch, thanks!

@QuietMisdreavus

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Accepting beta nomination; the PR is small and fixes something that could cause confusion.

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

📌 Commit 1db76c1 has been approved by QuietMisdreavus

Centril added a commit to Centril/rust that referenced this pull request Apr 15, 2019

Rollup merge of rust-lang#59978 - ollie27:rustdoc_default, r=QuietMis…
…dreavus

rustdoc: Remove default keyword from re-exported trait methods

Fixes rust-lang#59977

r? @QuietMisdreavus

As this fixes a stable to beta regression, could it be backported?

bors added a commit that referenced this pull request Apr 15, 2019

Auto merge of #59991 - Centril:rollup-bqxt4w3, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #59648 (Add must_use annotations to Result::is_ok and is_err)
 - #59748 (Add summary and reference to Rust trademark guide)
 - #59779 (Uplift `get_def_path` from Clippy)
 - #59955 (bump stdsimd; make intra_doc_link_resolution_failure an error again; make lints more consistent)
 - #59978 (rustdoc: Remove default keyword from re-exported trait methods)
 - #59989 (Fix links to Atomic* in RELEASES.md)

Failed merges:

r? @ghost

@bors bors merged commit 1db76c1 into rust-lang:master Apr 15, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@ollie27 ollie27 deleted the ollie27:rustdoc_default branch Apr 15, 2019

bors added a commit that referenced this pull request Apr 26, 2019

Auto merge of #60311 - pietroalbini:beta-rollup, r=pietroalbini
[beta] Rollup backports

Cherry-picked:

* #59886:  musl: do not compress debug section
* #59891:  Fix the link to sort_by_cached_key
* #59911: Revert "compile crates under test w/ -Zemit-stack-sizes"
* #59978: rustdoc: Remove default keyword from re-exported trait methods
* #59989: Fix links to Atomic* in RELEASES.md
* #60186: Temporarily accept [i|u][32|size] suffixes on a tuple index and warn
* #60309: Add 1.34.1 release notes

Rolled up:

* #60273: [beta] bootstrap; remove redundant imports.

r? @ghost

bors added a commit that referenced this pull request Apr 26, 2019

Auto merge of #60311 - pietroalbini:beta-rollup, r=pietroalbini
[beta] Rollup backports

Cherry-picked:

* #59886:  musl: do not compress debug section
* #59891:  Fix the link to sort_by_cached_key
* #59911: Revert "compile crates under test w/ -Zemit-stack-sizes"
* #59978: rustdoc: Remove default keyword from re-exported trait methods
* #59989: Fix links to Atomic* in RELEASES.md
* #60186: Temporarily accept [i|u][32|size] suffixes on a tuple index and warn
* #60309: Add 1.34.1 release notes

Rolled up:

* #60273: [beta] bootstrap; remove redundant imports.

r? @ghost

bors added a commit that referenced this pull request Apr 27, 2019

Auto merge of #60311 - pietroalbini:beta-rollup, r=pietroalbini
[beta] Rollup backports

Cherry-picked:

* #59886:  musl: do not compress debug section
* #59891:  Fix the link to sort_by_cached_key
* #59911: Revert "compile crates under test w/ -Zemit-stack-sizes"
* #59978: rustdoc: Remove default keyword from re-exported trait methods
* #59989: Fix links to Atomic* in RELEASES.md
* #60186: Temporarily accept [i|u][32|size] suffixes on a tuple index and warn
* #60309: Add 1.34.1 release notes

Rolled up:

* #60273: [beta] bootstrap; remove redundant imports.

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.