Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue evaluating after missing main #59903

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
4 participants
@estebank
Copy link
Contributor

commented Apr 12, 2019

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 12, 2019

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@@ -939,7 +940,10 @@ fn analysis<'tcx>(

// Abort so we don't try to construct MIR with liveness errors.
// We also won't want to continue with errors from rvalue promotion

This comment has been minimized.

Copy link
@oli-obk

oli-obk Apr 13, 2019

Contributor

well, we actually want to, but that's not really a problem of this PR. Have you checked how bad the fallout is if we remove this abort_if_errors?

This comment has been minimized.

Copy link
@estebank

estebank Apr 14, 2019

Author Contributor

I believe that there were some useless errors coming from const evaluation, but those might have come from removing the later check at https://github.com/rust-lang/rust/pull/59903/files/13a05a27e9a5747cad090b1670c0a6b0baa624b9#diff-24c5c945888bb0d041e769bfb852de6cR976

This comment has been minimized.

Copy link
@oli-obk

oli-obk Apr 15, 2019

Contributor

Can you check? I'd rather remove it entirely. Const eval should not evaluate MIR with typeck errors or borrowck errors.

This comment has been minimized.

Copy link
@estebank

estebank Apr 15, 2019

Author Contributor

@oli-obk most of the extra errors are not too bad, but src/test/ui/consts/match_ice.rs starts ICEing again. I'll need to dig deeper to fix the ICE and would like to remove the duplicated errors/warnings before merging that change, but it is certainly doable.

This comment has been minimized.

Copy link
@oli-obk

oli-obk Apr 15, 2019

Contributor

Hmm... Those look like deeper issues to me where some things should be querified more or just produce dummy values in case of errors. Please open an issue linking to the fallout of 8395dbd and mentioning the problems.

@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@bors r+

We'll do the full fix later, needs some investigation

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

📌 Commit 13a05a2 has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Apr 15, 2019

Rollup merge of rust-lang#59903 - estebank:after-main, r=oli-obk
Continue evaluating after missing main

bors added a commit that referenced this pull request Apr 15, 2019

Auto merge of #60001 - Centril:rollup-tq1rzfl, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #59717 (improve docs for std::hint::unreachable_unchecked())
 - #59752 (Limit dylib symbols)
 - #59903 (Continue evaluating after missing main)
 - #59974 (Bump bootstrap compiler to 2019-04-11)
 - #59992 (rustdoc: use --static-root-path for settings.js)
 - #59997 (Update cargo)
 - #60000 (Add repo-specific triagebot configuration)

Failed merges:

r? @ghost
@estebank

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

@oli-obk, made one further change in a separate branch that gets rid of the ICE, but I'm not sure it is the right solution.

Centril added a commit to Centril/rust that referenced this pull request Apr 16, 2019

Rollup merge of rust-lang#59903 - estebank:after-main, r=oli-obk
Continue evaluating after missing main

bors added a commit that referenced this pull request Apr 16, 2019

Auto merge of #60004 - Centril:rollup-05cj65e, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #59717 (improve docs for std::hint::unreachable_unchecked())
 - #59752 (Limit dylib symbols)
 - #59903 (Continue evaluating after missing main)
 - #59973 (Fix rustdoc sidebar z-index)
 - #59992 (rustdoc: use --static-root-path for settings.js)
 - #59993 (include mode in unused binding suggestion span)
 - #59997 (Update cargo)
 - #60000 (Add repo-specific triagebot configuration)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Apr 16, 2019

Rollup merge of rust-lang#59903 - estebank:after-main, r=oli-obk
Continue evaluating after missing main

bors added a commit that referenced this pull request Apr 16, 2019

Auto merge of #60007 - Centril:rollup-gdh1er4, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #59717 (improve docs for std::hint::unreachable_unchecked())
 - #59903 (Continue evaluating after missing main)
 - #59973 (Fix rustdoc sidebar z-index)
 - #59992 (rustdoc: use --static-root-path for settings.js)
 - #59993 (include mode in unused binding suggestion span)
 - #60000 (Add repo-specific triagebot configuration)

Failed merges:

r? @ghost

@bors bors merged commit 13a05a2 into rust-lang:master Apr 16, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

bors added a commit that referenced this pull request Apr 23, 2019

Auto merge of #60125 - estebank:continue-evaluating, r=oli-obk
Don't stop evaluating due to errors before borrow checking

r? @oli-obk

Fix #60005. Follow up to #59903. Blocked on #53708, fixing the ICE in `src/test/ui/consts/match_ice.rs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.